mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boris Belyavtsev <bbelyavtsev@usergate.com>
To: <hare@suse.com>
Cc: <linux-scsi@vger.kernel.org>,<linux-kernel@vger.kernel.org>,<lvc-project@linuxtesting.org>,Boris
	Belyavtsev <bbelyavtsev@usergate.com>
Subject: [PATCH 6.1 v2 1/3] scsi: aic79xx: check for non-NULL scb in ahd_handle_seqint
Date: Mon, 21 Apr 2025 15:16:02 +0700	[thread overview]
Message-ID: <20250421081604.655282-2-bbelyavtsev@usergate.com> (raw)
In-Reply-To: <20250421081604.655282-1-bbelyavtsev@usergate.com>

NULL pointer dereference is possible when compiled with AHD_DEBUG and
AHD_SHOW_RECOVERY is set if data in SCBPTR и SCBPTR+1 ports is
incorrect.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Boris Belyavtsev <bbelyavtsev@usergate.com>
---
 drivers/scsi/aic7xxx/aic79xx_core.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c
index f9372a81cd4e..a4d5376123d3 100644
--- a/drivers/scsi/aic7xxx/aic79xx_core.c
+++ b/drivers/scsi/aic7xxx/aic79xx_core.c
@@ -2205,13 +2205,16 @@ ahd_handle_seqint(struct ahd_softc *ahd, u_int intstat)
 			ahd_print_path(ahd, scb);
 			printk("data overrun detected %s.  Tag == 0x%x.\n",
 			       ahd_lookup_phase_entry(lastphase)->phasemsg,
-			       SCB_GET_TAG(scb));
+			       scb != NULL ? SCB_GET_TAG(scb) : 0);
 			ahd_print_path(ahd, scb);
 			printk("%s seen Data Phase.  Length = %ld.  "
 			       "NumSGs = %d.\n",
 			       ahd_inb(ahd, SEQ_FLAGS) & DPHASE
 			       ? "Have" : "Haven't",
-			       ahd_get_transfer_length(scb), scb->sg_count);
+			       scb != NULL ? ahd_get_transfer_length(scb) : -1,
+			       scb != NULL ? scb->sg_count : -1);
+			if (scb == NULL)
+				break;
 			ahd_dump_sglist(scb);
 		}
 #endif
-- 
2.43.0


  reply	other threads:[~2025-04-21  8:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21  8:16 [PATCH 6.1 v2 0/3] aic79xx: Add some non-NULL checks Boris Belyavtsev
2025-04-21  8:16 ` Boris Belyavtsev [this message]
2025-04-21  8:16 ` [PATCH 6.1 v2 2/3] scsi: aic79xx: check for non-NULL scb in ahd_handle_pkt_busfree Boris Belyavtsev
2025-04-21  8:16 ` [PATCH 6.1 v2 3/3] scsi: aic79xx: check for non-NULL scb in ahd_linux_queue_abort_cmd Boris Belyavtsev
2025-04-21 12:12 ` [PATCH 6.1 v2 0/3] aic79xx: Add some non-NULL checks James Bottomley
2025-04-28  4:32   ` Boris Belyavtsev
2025-04-28 12:07     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250421081604.655282-2-bbelyavtsev@usergate.com \
    --to=bbelyavtsev@usergate.com \
    --cc=hare@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®