From: Inochi Amaoto <inochiama@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Inochi Amaoto <inochiama@gmail.com>,
Chen Wang <unicorn_wang@outlook.com>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: [PATCH] irqchip/sg2042-msi: Fix wrong type cast in sg2044_msi_irq_ack
Date: Tue, 22 Apr 2025 08:38:03 +0800 [thread overview]
Message-ID: <20250422003804.214264-1-inochiama@gmail.com> (raw)
The type cast in sg2044_msi_irq_ack lost __iomem attribute,
which make the pointer type incorrect.
Add the miss "__iomem" attribute to fix it.
Fixes: e96b93a97c90 ("irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller")
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504211251.B3aesulq-lkp@intel.com/
---
drivers/irqchip/irq-sg2042-msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sg2042-msi.c b/drivers/irqchip/irq-sg2042-msi.c
index 8a83c690b760..a3e2a26d8495 100644
--- a/drivers/irqchip/irq-sg2042-msi.c
+++ b/drivers/irqchip/irq-sg2042-msi.c
@@ -98,7 +98,7 @@ static void sg2044_msi_irq_ack(struct irq_data *d)
{
struct sg204x_msi_chipdata *data = irq_data_get_irq_chip_data(d);
- writel(0, (u32 *)data->reg_clr + d->hwirq);
+ writel(0, (u32 __iomem *)data->reg_clr + d->hwirq);
irq_chip_ack_parent(d);
}
--
2.49.0
next reply other threads:[~2025-04-22 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 0:38 Inochi Amaoto [this message]
2025-04-22 1:46 ` Chen Wang
2025-04-24 12:28 ` [tip: irq/drivers] irqchip/sg2042-msi: Fix wrong type cast in sg2044_msi_irq_ack() tip-bot2 for Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422003804.214264-1-inochiama@gmail.com \
--to=inochiama@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tglx@linutronix.de \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®