[PATCH] irqchip/sg2042-msi: Fix wrong type cast in sg2044_msi_irq_ack

[PATCH] irqchip/sg2042-msi: Fix wrong type cast in sg2044_msi_irq_ack

[Inochi Amaoto]

The type cast in sg2044_msi_irq_ack lost __iomem attribute,
which make the pointer type incorrect.

Add the miss "__iomem" attribute to fix it.

Fixes: e96b93a97c90 ("irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller")
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504211251.B3aesulq-lkp@intel.com/
---
 drivers/irqchip/irq-sg2042-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-sg2042-msi.c b/drivers/irqchip/irq-sg2042-msi.c
index 8a83c690b760..a3e2a26d8495 100644
--- a/drivers/irqchip/irq-sg2042-msi.c
+++ b/drivers/irqchip/irq-sg2042-msi.c
@@ -98,7 +98,7 @@ static void sg2044_msi_irq_ack(struct irq_data *d)
 {
 	struct sg204x_msi_chipdata *data = irq_data_get_irq_chip_data(d);

-	writel(0, (u32 *)data->reg_clr + d->hwirq);
+	writel(0, (u32 __iomem *)data->reg_clr + d->hwirq);
 	irq_chip_ack_parent(d);
 }

--
2.49.0

Re: [PATCH] irqchip/sg2042-msi: Fix wrong type cast in sg2044_msi_irq_ack

[Chen Wang]

On 2025/4/22 8:38, Inochi Amaoto wrote:
> The type cast in sg2044_msi_irq_ack lost __iomem attribute,
> which make the pointer type incorrect.
>
> Add the miss "__iomem" attribute to fix it.
>
> Fixes: e96b93a97c90 ("irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller")
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504211251.B3aesulq-lkp@intel.com/
> ---
>   drivers/irqchip/irq-sg2042-msi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sg2042-msi.c b/drivers/irqchip/irq-sg2042-msi.c
> index 8a83c690b760..a3e2a26d8495 100644
> --- a/drivers/irqchip/irq-sg2042-msi.c
> +++ b/drivers/irqchip/irq-sg2042-msi.c
> @@ -98,7 +98,7 @@ static void sg2044_msi_irq_ack(struct irq_data *d)
>   {
>   	struct sg204x_msi_chipdata *data = irq_data_get_irq_chip_data(d);
>
> -	writel(0, (u32 *)data->reg_clr + d->hwirq);
> +	writel(0, (u32 __iomem *)data->reg_clr + d->hwirq);
>   	irq_chip_ack_parent(d);
>   }
>
> --
> 2.49.0

Reviewed-by: Chen Wang <unicorn_wang@outlook.com>

Thanks,

Chen

[tip: irq/drivers] irqchip/sg2042-msi: Fix wrong type cast in sg2044_msi_irq_ack()

[tip-bot2 for Inochi Amaoto]

The following commit has been merged into the irq/drivers branch of tip:

Commit-ID:     76b66e8c9d159eb3d1699e0fa80ceacf9a9ae627
Gitweb:        https://git.kernel.org/tip/76b66e8c9d159eb3d1699e0fa80ceacf9a9ae627
Author:        Inochi Amaoto <inochiama@gmail.com>
AuthorDate:    Tue, 22 Apr 2025 08:38:03 +08:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 24 Apr 2025 14:22:09 +02:00

irqchip/sg2042-msi: Fix wrong type cast in sg2044_msi_irq_ack()

The type cast in sg2044_msi_irq_ack() lost the __iomem attribute, which
makes the pointer type incorrect.

Add it back.

Fixes: e96b93a97c90 ("irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
Link: https://lore.kernel.org/all/20250422003804.214264-1-inochiama@gmail.com
Closes: https://lore.kernel.org/oe-kbuild-all/202504211251.B3aesulq-lkp@intel.com/
---
 drivers/irqchip/irq-sg2042-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-sg2042-msi.c b/drivers/irqchip/irq-sg2042-msi.c
index 8a83c69..a3e2a26 100644
--- a/drivers/irqchip/irq-sg2042-msi.c
+++ b/drivers/irqchip/irq-sg2042-msi.c
@@ -98,7 +98,7 @@ static void sg2044_msi_irq_ack(struct irq_data *d)
 {
 	struct sg204x_msi_chipdata *data = irq_data_get_irq_chip_data(d);
 
-	writel(0, (u32 *)data->reg_clr + d->hwirq);
+	writel(0, (u32 __iomem *)data->reg_clr + d->hwirq);
 	irq_chip_ack_parent(d);
 }