* [PATCH] drivers/acpi: Improve logging around acpi_initialize_tables
@ 2025-04-23 8:56 Bartosz Szczepanek
2025-05-09 18:35 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Szczepanek @ 2025-04-23 8:56 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: nh-open-source, Bartosz Szczepanek, linux-acpi, linux-kernel
Emit warning that includes return code in a readable format. Example:
ACPI: Failed to initialize tables, status=0x5 (AE_NOT_FOUND)
This commit intends to make no other functional change.
Signed-off-by: Bartosz Szczepanek <bsz@amazon.de>
---
drivers/acpi/tables.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 2295abbecd14..6a017cc92d4e 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -719,8 +719,12 @@ int __init acpi_locate_initial_tables(void)
}
status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
- if (ACPI_FAILURE(status))
+ if (ACPI_FAILURE(status)) {
+ const char *msg = acpi_format_exception(status);
+
+ pr_warn("Failed to initialize tables, status=0x%x (%s)", status, msg);
return -EINVAL;
+ }
return 0;
}
--
2.47.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/acpi: Improve logging around acpi_initialize_tables
2025-04-23 8:56 [PATCH] drivers/acpi: Improve logging around acpi_initialize_tables Bartosz Szczepanek
@ 2025-05-09 18:35 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2025-05-09 18:35 UTC (permalink / raw)
To: Bartosz Szczepanek
Cc: Rafael J. Wysocki, Len Brown, nh-open-source, linux-acpi, linux-kernel
On Wed, Apr 23, 2025 at 10:56 AM Bartosz Szczepanek <bsz@amazon.de> wrote:
>
> Emit warning that includes return code in a readable format. Example:
> ACPI: Failed to initialize tables, status=0x5 (AE_NOT_FOUND)
>
> This commit intends to make no other functional change.
>
> Signed-off-by: Bartosz Szczepanek <bsz@amazon.de>
> ---
> drivers/acpi/tables.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 2295abbecd14..6a017cc92d4e 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -719,8 +719,12 @@ int __init acpi_locate_initial_tables(void)
> }
>
> status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0);
> - if (ACPI_FAILURE(status))
> + if (ACPI_FAILURE(status)) {
> + const char *msg = acpi_format_exception(status);
> +
> + pr_warn("Failed to initialize tables, status=0x%x (%s)", status, msg);
> return -EINVAL;
> + }
>
> return 0;
> }
> --
Applied as 6.16 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-09 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-23 8:56 [PATCH] drivers/acpi: Improve logging around acpi_initialize_tables Bartosz Szczepanek
2025-05-09 18:35 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®