Re: [PATCH v4 1/6] media: dt-bindings: mt9m114: Add slew-rate DT-binding

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Mathis,

Thank you for the patch.

On Fri, Mar 07, 2025 at 10:31:35AM +0100, Mathis Foerst wrote:
> The MT9M114 supports the different slew rates (0 to 7) on the output pads.
> At the moment, this is hardcoded to 7 (the fastest rate).
> The user might want to change this values due to EMC requirements.
> 
> Add the 'slew-rate' property to the MT9M114 DT-bindings for selecting
> the desired slew rate.
> 
> Signed-off-by: Mathis Foerst <mathis.foerst@mt.com>
> ---
>  .../devicetree/bindings/media/i2c/onnn,mt9m114.yaml      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> index f6b87892068a..a89f740214f7 100644
> --- a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> @@ -70,6 +70,15 @@ properties:
>            - bus-type
>            - link-frequencies
>  
> +  slew-rate:

Shouldn't this be a vendor property, with a vendor prefix (i.e.
'onnn,slew-rate') ? There's a 'slew-rate' property defined in
Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml, but that's
for pin config nodes.

The rest looks good, so with this change (or without it if there's a
consensus we don't need a vendor prefix),

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Slew rate ot the output pads DOUT[7:0], LINE_VALID, FRAME_VALID and
> +      PIXCLK. Higher values imply steeper voltage-flanks on the pads.
> +    minimum: 0
> +    maximum: 7
> +    default: 7
> +
>  required:
>    - compatible
>    - reg

-- 
Regards,

Laurent Pinchart