From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nipun Gupta <nipun.gupta@amd.com>,
Nikhil Agarwal <nikhil.agarwal@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 3/5] cdx: controller: Drop useless probe success message
Date: Fri, 25 Apr 2025 08:54:39 +0200 [thread overview]
Message-ID: <20250425-cdx-clean-v1-3-ea2002dd400d@linaro.org> (raw)
In-Reply-To: <20250425-cdx-clean-v1-0-ea2002dd400d@linaro.org>
Drivers should be silent on probe success, unless they print some useful
information. Printing "hey I probed" is not useful and kernel already
gives mechanism to investigate that (e.g. sysfs, tracing, initcall
debug).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/cdx/controller/cdx_controller.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
index 3df35833f0e0a994af0606eee0dc1dfc9c7c22f9..fce90926d3378ae60166426cbf8e4a4fe014af86 100644
--- a/drivers/cdx/controller/cdx_controller.c
+++ b/drivers/cdx/controller/cdx_controller.c
@@ -205,7 +205,6 @@ static int xlnx_cdx_probe(struct platform_device *pdev)
goto cdx_rpmsg_fail;
}
- dev_info(&pdev->dev, "Successfully registered CDX controller with RPMsg as transport\n");
return 0;
cdx_rpmsg_fail:
--
2.45.2
next prev parent reply other threads:[~2025-04-25 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 6:54 [PATCH 0/5] cdx: Minor cleanups Krzysztof Kozlowski
2025-04-25 6:54 ` [PATCH 1/5] cdx: Enable compile testing Krzysztof Kozlowski
2025-04-25 6:54 ` [PATCH 2/5] cdx: controller: Simplify with dev_err_probe() Krzysztof Kozlowski
2025-04-25 6:54 ` Krzysztof Kozlowski [this message]
2025-04-25 6:54 ` [PATCH 4/5] cdx: controller: Do not open-code module_platform_driver() Krzysztof Kozlowski
2025-04-25 6:59 ` Krzysztof Kozlowski
2025-04-25 6:54 ` [PATCH 5/5] cdx: MAINTAINERS: Explicitly mention Greg who handles patches Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425-cdx-clean-v1-3-ea2002dd400d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®