mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Nipun Gupta <nipun.gupta@amd.com>,
	Nikhil Agarwal <nikhil.agarwal@amd.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] cdx: controller: Do not open-code module_platform_driver()
Date: Fri, 25 Apr 2025 08:59:21 +0200	[thread overview]
Message-ID: <c7b61835-e139-43f9-b402-ca49c2a95dce@linaro.org> (raw)
In-Reply-To: <20250425-cdx-clean-v1-4-ea2002dd400d@linaro.org>

On 25/04/2025 08:54, Krzysztof Kozlowski wrote:
> Replace standard platform_driver_register() boilerplate with
> module_platform_driver() to make code smaller.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/cdx/controller/cdx_controller.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
> 
> diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
> index fce90926d3378ae60166426cbf8e4a4fe014af86..fca83141e3e66e68e6916077833db2b7d816395f 100644
> --- a/drivers/cdx/controller/cdx_controller.c
> +++ b/drivers/cdx/controller/cdx_controller.c
> @@ -243,31 +243,13 @@ MODULE_DEVICE_TABLE(of, cdx_match_table);
>  static struct platform_driver cdx_pdriver = {
>  	.driver = {
>  		   .name = "cdx-controller",
> -		   .pm = NULL,


Too big chunk in `git add -p`. This should be separate patch.

I will wait a day for more reviews and then send v2.


Best regards,
Krzysztof

  reply	other threads:[~2025-04-25  6:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25  6:54 [PATCH 0/5] cdx: Minor cleanups Krzysztof Kozlowski
2025-04-25  6:54 ` [PATCH 1/5] cdx: Enable compile testing Krzysztof Kozlowski
2025-04-25  6:54 ` [PATCH 2/5] cdx: controller: Simplify with dev_err_probe() Krzysztof Kozlowski
2025-04-25  6:54 ` [PATCH 3/5] cdx: controller: Drop useless probe success message Krzysztof Kozlowski
2025-04-25  6:54 ` [PATCH 4/5] cdx: controller: Do not open-code module_platform_driver() Krzysztof Kozlowski
2025-04-25  6:59   ` Krzysztof Kozlowski [this message]
2025-04-25  6:54 ` [PATCH 5/5] cdx: MAINTAINERS: Explicitly mention Greg who handles patches Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7b61835-e139-43f9-b402-ca49c2a95dce@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikhil.agarwal@amd.com \
    --cc=nipun.gupta@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®