* [PATCH] Staging: comedi: das16: Fixed a stucture warning in code
@ 2025-04-26 11:36 Darshan Rathod
2025-04-26 15:26 ` kernel test robot
2025-04-26 19:05 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Darshan Rathod @ 2025-04-26 11:36 UTC (permalink / raw)
To: abbotti; +Cc: hsweeten, linux-kernel, Darshan Rathod
Fixed a warning message in das16.c file.
Signed-off-by: Darshan Rathod <darshanrathod475@gmail.com>
---
drivers/comedi/drivers/das16.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/comedi/drivers/das16.c b/drivers/comedi/drivers/das16.c
index f5ca6c0d4d0c..73717f75d60f 100644
--- a/drivers/comedi/drivers/das16.c
+++ b/drivers/comedi/drivers/das16.c
@@ -956,8 +956,8 @@ static const struct comedi_lrange *das16_ai_range(struct comedi_device *dev,
/* get any user-defined input range */
if (pg_type == das16_pg_none && (min || max)) {
- struct comedi_lrange *lrange;
- struct comedi_krange *krange;
+ const struct comedi_lrange *lrange;
+ const struct comedi_krange *krange;
/* allocate single-range range table */
lrange = comedi_alloc_spriv(s,
@@ -990,8 +990,8 @@ static const struct comedi_lrange *das16_ao_range(struct comedi_device *dev,
/* get any user-defined output range */
if (min || max) {
- struct comedi_lrange *lrange;
- struct comedi_krange *krange;
+ const struct comedi_lrange *lrange;
+ const struct comedi_krange *krange;
/* allocate single-range range table */
lrange = comedi_alloc_spriv(s,
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: comedi: das16: Fixed a stucture warning in code
2025-04-26 11:36 [PATCH] Staging: comedi: das16: Fixed a stucture warning in code Darshan Rathod
@ 2025-04-26 15:26 ` kernel test robot
2025-04-26 19:05 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-04-26 15:26 UTC (permalink / raw)
To: Darshan Rathod, abbotti
Cc: llvm, oe-kbuild-all, hsweeten, linux-kernel, Darshan Rathod
Hi Darshan,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Darshan-Rathod/Staging-comedi-das16-Fixed-a-stucture-warning-in-code/20250426-193741
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20250426113627.36525-1-darshanrathod475%40gmail.com
patch subject: [PATCH] Staging: comedi: das16: Fixed a stucture warning in code
config: arm64-randconfig-003-20250426 (https://download.01.org/0day-ci/archive/20250426/202504262332.cRQb8NpG-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250426/202504262332.cRQb8NpG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504262332.cRQb8NpG-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/comedi/drivers/das16.c:969:18: error: cannot assign to variable 'lrange' with const-qualified type 'const struct comedi_lrange *'
969 | lrange->length = 1;
| ~~~~~~~~~~~~~~ ^
drivers/comedi/drivers/das16.c:959:31: note: variable 'lrange' declared const here
959 | const struct comedi_lrange *lrange;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
>> drivers/comedi/drivers/das16.c:971:15: error: cannot assign to variable 'krange' with const-qualified type 'const struct comedi_krange *'
971 | krange->min = min;
| ~~~~~~~~~~~ ^
drivers/comedi/drivers/das16.c:960:31: note: variable 'krange' declared const here
960 | const struct comedi_krange *krange;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
drivers/comedi/drivers/das16.c:972:15: error: cannot assign to variable 'krange' with const-qualified type 'const struct comedi_krange *'
972 | krange->max = max;
| ~~~~~~~~~~~ ^
drivers/comedi/drivers/das16.c:960:31: note: variable 'krange' declared const here
960 | const struct comedi_krange *krange;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
drivers/comedi/drivers/das16.c:973:17: error: cannot assign to variable 'krange' with const-qualified type 'const struct comedi_krange *'
973 | krange->flags = UNIT_volt;
| ~~~~~~~~~~~~~ ^
drivers/comedi/drivers/das16.c:960:31: note: variable 'krange' declared const here
960 | const struct comedi_krange *krange;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
drivers/comedi/drivers/das16.c:1003:18: error: cannot assign to variable 'lrange' with const-qualified type 'const struct comedi_lrange *'
1003 | lrange->length = 1;
| ~~~~~~~~~~~~~~ ^
drivers/comedi/drivers/das16.c:993:31: note: variable 'lrange' declared const here
993 | const struct comedi_lrange *lrange;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
drivers/comedi/drivers/das16.c:1005:15: error: cannot assign to variable 'krange' with const-qualified type 'const struct comedi_krange *'
1005 | krange->min = min;
| ~~~~~~~~~~~ ^
drivers/comedi/drivers/das16.c:994:31: note: variable 'krange' declared const here
994 | const struct comedi_krange *krange;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
drivers/comedi/drivers/das16.c:1006:15: error: cannot assign to variable 'krange' with const-qualified type 'const struct comedi_krange *'
1006 | krange->max = max;
| ~~~~~~~~~~~ ^
drivers/comedi/drivers/das16.c:994:31: note: variable 'krange' declared const here
994 | const struct comedi_krange *krange;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
drivers/comedi/drivers/das16.c:1007:17: error: cannot assign to variable 'krange' with const-qualified type 'const struct comedi_krange *'
1007 | krange->flags = UNIT_volt;
| ~~~~~~~~~~~~~ ^
drivers/comedi/drivers/das16.c:994:31: note: variable 'krange' declared const here
994 | const struct comedi_krange *krange;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
8 errors generated.
vim +969 drivers/comedi/drivers/das16.c
742c4a095973f69 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-12 947
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 948 static const struct comedi_lrange *das16_ai_range(struct comedi_device *dev,
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 949 struct comedi_subdevice *s,
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 950 struct comedi_devconfig *it,
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 951 unsigned int pg_type,
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 952 unsigned int status)
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 953 {
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 954 unsigned int min = it->options[4];
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 955 unsigned int max = it->options[5];
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 956
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 957 /* get any user-defined input range */
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 958 if (pg_type == das16_pg_none && (min || max)) {
5c47473ec0f437f drivers/comedi/drivers/das16.c Darshan Rathod 2025-04-26 959 const struct comedi_lrange *lrange;
5c47473ec0f437f drivers/comedi/drivers/das16.c Darshan Rathod 2025-04-26 960 const struct comedi_krange *krange;
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 961
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 962 /* allocate single-range range table */
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 963 lrange = comedi_alloc_spriv(s,
ee8ed0141d532d6 drivers/comedi/drivers/das16.c Gustavo A. R. Silva 2022-01-25 964 struct_size(lrange, range, 1));
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 965 if (!lrange)
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 966 return &range_unknown;
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 967
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 968 /* initialize ai range */
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 @969 lrange->length = 1;
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 970 krange = lrange->range;
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 @971 krange->min = min;
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 972 krange->max = max;
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 973 krange->flags = UNIT_volt;
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 974
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 975 return lrange;
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 976 }
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 977
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 978 /* use software programmable range */
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 979 if (status & DAS16_STATUS_UNIPOLAR)
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 980 return das16_ai_uni_lranges[pg_type];
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 981 return das16_ai_bip_lranges[pg_type];
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 982 }
0ce8280e2876091 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 983
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: comedi: das16: Fixed a stucture warning in code
2025-04-26 11:36 [PATCH] Staging: comedi: das16: Fixed a stucture warning in code Darshan Rathod
2025-04-26 15:26 ` kernel test robot
@ 2025-04-26 19:05 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-04-26 19:05 UTC (permalink / raw)
To: Darshan Rathod, abbotti
Cc: oe-kbuild-all, hsweeten, linux-kernel, Darshan Rathod
Hi Darshan,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Darshan-Rathod/Staging-comedi-das16-Fixed-a-stucture-warning-in-code/20250426-193741
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20250426113627.36525-1-darshanrathod475%40gmail.com
patch subject: [PATCH] Staging: comedi: das16: Fixed a stucture warning in code
config: powerpc-randconfig-003-20250426 (https://download.01.org/0day-ci/archive/20250427/202504270205.NwA93W44-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250427/202504270205.NwA93W44-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504270205.NwA93W44-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/comedi/drivers/das16.c: In function 'das16_ai_range':
>> drivers/comedi/drivers/das16.c:969:18: error: assignment of member 'length' in read-only object
lrange->length = 1;
^
>> drivers/comedi/drivers/das16.c:971:15: error: assignment of member 'min' in read-only object
krange->min = min;
^
>> drivers/comedi/drivers/das16.c:972:15: error: assignment of member 'max' in read-only object
krange->max = max;
^
>> drivers/comedi/drivers/das16.c:973:17: error: assignment of member 'flags' in read-only object
krange->flags = UNIT_volt;
^
drivers/comedi/drivers/das16.c: In function 'das16_ao_range':
drivers/comedi/drivers/das16.c:1003:18: error: assignment of member 'length' in read-only object
lrange->length = 1;
^
drivers/comedi/drivers/das16.c:1005:15: error: assignment of member 'min' in read-only object
krange->min = min;
^
drivers/comedi/drivers/das16.c:1006:15: error: assignment of member 'max' in read-only object
krange->max = max;
^
drivers/comedi/drivers/das16.c:1007:17: error: assignment of member 'flags' in read-only object
krange->flags = UNIT_volt;
^
vim +/length +969 drivers/comedi/drivers/das16.c
742c4a095973f6 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-12 947
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 948 static const struct comedi_lrange *das16_ai_range(struct comedi_device *dev,
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 949 struct comedi_subdevice *s,
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 950 struct comedi_devconfig *it,
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 951 unsigned int pg_type,
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 952 unsigned int status)
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 953 {
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 954 unsigned int min = it->options[4];
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 955 unsigned int max = it->options[5];
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 956
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 957 /* get any user-defined input range */
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 958 if (pg_type == das16_pg_none && (min || max)) {
5c47473ec0f437 drivers/comedi/drivers/das16.c Darshan Rathod 2025-04-26 959 const struct comedi_lrange *lrange;
5c47473ec0f437 drivers/comedi/drivers/das16.c Darshan Rathod 2025-04-26 960 const struct comedi_krange *krange;
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 961
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 962 /* allocate single-range range table */
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 963 lrange = comedi_alloc_spriv(s,
ee8ed0141d532d drivers/comedi/drivers/das16.c Gustavo A. R. Silva 2022-01-25 964 struct_size(lrange, range, 1));
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 965 if (!lrange)
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 966 return &range_unknown;
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 967
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 968 /* initialize ai range */
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 @969 lrange->length = 1;
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 970 krange = lrange->range;
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 @971 krange->min = min;
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 @972 krange->max = max;
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 @973 krange->flags = UNIT_volt;
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 974
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 975 return lrange;
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 976 }
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 977
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 978 /* use software programmable range */
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 979 if (status & DAS16_STATUS_UNIPOLAR)
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 980 return das16_ai_uni_lranges[pg_type];
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 981 return das16_ai_bip_lranges[pg_type];
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 982 }
0ce8280e287609 drivers/staging/comedi/drivers/das16.c H Hartley Sweeten 2015-01-26 983
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-26 19:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-26 11:36 [PATCH] Staging: comedi: das16: Fixed a stucture warning in code Darshan Rathod
2025-04-26 15:26 ` kernel test robot
2025-04-26 19:05 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®