* [PATCH 0/2] arm64: tegra: Clean up serial nodes
@ 2025-04-29 1:51 Aaron Kling via B4 Relay
2025-04-29 1:51 ` [PATCH 1/2] arm64: tegra: Drop remaining serial clock-names and reset-names Aaron Kling via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aaron Kling via B4 Relay @ 2025-04-29 1:51 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter
Cc: Krzysztof Kozlowski, Thierry Reding, devicetree, linux-tegra,
linux-kernel, Aaron Kling
Several Tegra186 and Tegra194 serial nodes still have invalid properties
and/or are missing dma properties. This series corrects those.
Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
Aaron Kling (2):
arm64: tegra: Drop remaining serial clock-names and reset-names
arm64: tegra: Add DMA properties for Tegra186 and Tegra194 UARTs
arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi | 2 ++
.../dts/nvidia/tegra186-p3509-0000+p3636-0001.dts | 2 ++
arch/arm64/boot/dts/nvidia/tegra186.dtsi | 26 ++++++++++----------
arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 ++
arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi | 2 ++
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 28 ++++++++++++----------
6 files changed, 38 insertions(+), 24 deletions(-)
---
base-commit: ca91b9500108d4cf083a635c2e11c884d5dd20ea
change-id: 20250428-tegra-serial-fixes-9fcdc8fd5020
Best regards,
--
Aaron Kling <webgeek1234@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] arm64: tegra: Drop remaining serial clock-names and reset-names
2025-04-29 1:51 [PATCH 0/2] arm64: tegra: Clean up serial nodes Aaron Kling via B4 Relay
@ 2025-04-29 1:51 ` Aaron Kling via B4 Relay
2025-04-29 1:51 ` [PATCH 2/2] arm64: tegra: Add DMA properties for Tegra186 and Tegra194 UARTs Aaron Kling via B4 Relay
2025-05-08 20:59 ` [PATCH 0/2] arm64: tegra: Clean up serial nodes Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Aaron Kling via B4 Relay @ 2025-04-29 1:51 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter
Cc: Krzysztof Kozlowski, Thierry Reding, devicetree, linux-tegra,
linux-kernel, Aaron Kling
From: Aaron Kling <webgeek1234@gmail.com>
The referenced commit only removed some of the names, missing all that
weren't in use at the time. The commit removes the rest.
Fixes: 71de0a054d0e ("arm64: tegra: Drop serial clock-names and reset-names")
Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
arch/arm64/boot/dts/nvidia/tegra186.dtsi | 12 ------------
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 12 ------------
2 files changed, 24 deletions(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
index 2b3bb5d0af17bd521f87db0484fcbe943dd1a797..f0b7949df92c0583d0e710e5e2b93818434a913f 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
@@ -621,9 +621,7 @@ uartb: serial@3110000 {
reg-shift = <2>;
interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTB>;
- clock-names = "serial";
resets = <&bpmp TEGRA186_RESET_UARTB>;
- reset-names = "serial";
status = "disabled";
};
@@ -633,9 +631,7 @@ uartd: serial@3130000 {
reg-shift = <2>;
interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTD>;
- clock-names = "serial";
resets = <&bpmp TEGRA186_RESET_UARTD>;
- reset-names = "serial";
status = "disabled";
};
@@ -645,9 +641,7 @@ uarte: serial@3140000 {
reg-shift = <2>;
interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTE>;
- clock-names = "serial";
resets = <&bpmp TEGRA186_RESET_UARTE>;
- reset-names = "serial";
status = "disabled";
};
@@ -657,9 +651,7 @@ uartf: serial@3150000 {
reg-shift = <2>;
interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTF>;
- clock-names = "serial";
resets = <&bpmp TEGRA186_RESET_UARTF>;
- reset-names = "serial";
status = "disabled";
};
@@ -1236,9 +1228,7 @@ uartc: serial@c280000 {
reg-shift = <2>;
interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTC>;
- clock-names = "serial";
resets = <&bpmp TEGRA186_RESET_UARTC>;
- reset-names = "serial";
status = "disabled";
};
@@ -1248,9 +1238,7 @@ uartg: serial@c290000 {
reg-shift = <2>;
interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTG>;
- clock-names = "serial";
resets = <&bpmp TEGRA186_RESET_UARTG>;
- reset-names = "serial";
status = "disabled";
};
diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
index 33f92b77cd9d9e530eae87a4bb8ba61993ceffeb..c3695077478514708933934f06f25ef7dbe6f923 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
@@ -766,9 +766,7 @@ uartd: serial@3130000 {
reg-shift = <2>;
interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTD>;
- clock-names = "serial";
resets = <&bpmp TEGRA194_RESET_UARTD>;
- reset-names = "serial";
status = "disabled";
};
@@ -778,9 +776,7 @@ uarte: serial@3140000 {
reg-shift = <2>;
interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTE>;
- clock-names = "serial";
resets = <&bpmp TEGRA194_RESET_UARTE>;
- reset-names = "serial";
status = "disabled";
};
@@ -790,9 +786,7 @@ uartf: serial@3150000 {
reg-shift = <2>;
interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTF>;
- clock-names = "serial";
resets = <&bpmp TEGRA194_RESET_UARTF>;
- reset-names = "serial";
status = "disabled";
};
@@ -817,9 +811,7 @@ uarth: serial@3170000 {
reg-shift = <2>;
interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTH>;
- clock-names = "serial";
resets = <&bpmp TEGRA194_RESET_UARTH>;
- reset-names = "serial";
status = "disabled";
};
@@ -1616,9 +1608,7 @@ uartc: serial@c280000 {
reg-shift = <2>;
interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTC>;
- clock-names = "serial";
resets = <&bpmp TEGRA194_RESET_UARTC>;
- reset-names = "serial";
status = "disabled";
};
@@ -1628,9 +1618,7 @@ uartg: serial@c290000 {
reg-shift = <2>;
interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTG>;
- clock-names = "serial";
resets = <&bpmp TEGRA194_RESET_UARTG>;
- reset-names = "serial";
status = "disabled";
};
--
2.48.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: tegra: Add DMA properties for Tegra186 and Tegra194 UARTs
2025-04-29 1:51 [PATCH 0/2] arm64: tegra: Clean up serial nodes Aaron Kling via B4 Relay
2025-04-29 1:51 ` [PATCH 1/2] arm64: tegra: Drop remaining serial clock-names and reset-names Aaron Kling via B4 Relay
@ 2025-04-29 1:51 ` Aaron Kling via B4 Relay
2025-05-08 20:59 ` [PATCH 0/2] arm64: tegra: Clean up serial nodes Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Aaron Kling via B4 Relay @ 2025-04-29 1:51 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter
Cc: Krzysztof Kozlowski, Thierry Reding, devicetree, linux-tegra,
linux-kernel, Aaron Kling
From: Aaron Kling <webgeek1234@gmail.com>
Adding the missing dmas and dma-names properties which are required
for uart when using with the Tegra HSUART driver.
Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi | 2 ++
.../boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts | 2 ++
arch/arm64/boot/dts/nvidia/tegra186.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 ++
arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi | 2 ++
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 16 ++++++++++++++++
6 files changed, 38 insertions(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi b/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
index e2d6857a37097c5acc38dcbfd12800d59510f1c6..51ced62cd42be27f837832d8033766c1050b4b39 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi
@@ -61,6 +61,8 @@ memory-controller@2c00000 {
};
serial@3100000 {
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts b/arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts
index 26f71651933d1d8ef32bbd1645cac1820bd2e104..4ab66ebd874d05407373f98d7f76ce4b338ed089 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra186-p3509-0000+p3636-0001.dts
@@ -549,6 +549,8 @@ timer@3010000 {
};
serial@3100000 {
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
index f0b7949df92c0583d0e710e5e2b93818434a913f..f0c9295f55e77cd0733ec0ad0c05967fc1bdced7 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
@@ -612,6 +612,8 @@ uarta: serial@3100000 {
interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTA>;
resets = <&bpmp TEGRA186_RESET_UARTA>;
+ dmas = <&gpcdma 8>, <&gpcdma 8>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -622,6 +624,8 @@ uartb: serial@3110000 {
interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTB>;
resets = <&bpmp TEGRA186_RESET_UARTB>;
+ dmas = <&gpcdma 9>, <&gpcdma 9>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -632,6 +636,8 @@ uartd: serial@3130000 {
interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTD>;
resets = <&bpmp TEGRA186_RESET_UARTD>;
+ dmas = <&gpcdma 19>, <&gpcdma 19>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -642,6 +648,8 @@ uarte: serial@3140000 {
interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTE>;
resets = <&bpmp TEGRA186_RESET_UARTE>;
+ dmas = <&gpcdma 20>, <&gpcdma 20>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -652,6 +660,8 @@ uartf: serial@3150000 {
interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTF>;
resets = <&bpmp TEGRA186_RESET_UARTF>;
+ dmas = <&gpcdma 12>, <&gpcdma 12>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -1229,6 +1239,8 @@ uartc: serial@c280000 {
interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTC>;
resets = <&bpmp TEGRA186_RESET_UARTC>;
+ dmas = <&gpcdma 3>, <&gpcdma 3>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -1239,6 +1251,8 @@ uartg: serial@c290000 {
interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA186_CLK_UARTG>;
resets = <&bpmp TEGRA186_RESET_UARTG>;
+ dmas = <&gpcdma 2>, <&gpcdma 2>;
+ dma-names = "rx", "tx";
status = "disabled";
};
diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
index e8b296d9e0d3e66a6739ad085ee38cc73f86e0fe..43942db6eac9a9b10b61eb1af82df34c759657ec 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
@@ -104,6 +104,8 @@ input@2 {
};
serial@3110000 {
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi
index 59860d19f0f6a5a32719dcdb7f868b60c2551a1f..a410fc335fa3bb8d9961b2e8aa8681e4b6128afe 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi
@@ -78,6 +78,8 @@ input@2 {
};
serial@3100000 {
+ /delete-property/ dmas;
+ /delete-property/ dma-names;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
index c3695077478514708933934f06f25ef7dbe6f923..3a4e086dcc8c5e9bd2b40f54eda6a7b935c81c77 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
@@ -747,6 +747,8 @@ uarta: serial@3100000 {
interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTA>;
resets = <&bpmp TEGRA194_RESET_UARTA>;
+ dmas = <&gpcdma 8>, <&gpcdma 8>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -757,6 +759,8 @@ uartb: serial@3110000 {
interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTB>;
resets = <&bpmp TEGRA194_RESET_UARTB>;
+ dmas = <&gpcdma 9>, <&gpcdma 9>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -767,6 +771,8 @@ uartd: serial@3130000 {
interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTD>;
resets = <&bpmp TEGRA194_RESET_UARTD>;
+ dmas = <&gpcdma 19>, <&gpcdma 19>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -777,6 +783,8 @@ uarte: serial@3140000 {
interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTE>;
resets = <&bpmp TEGRA194_RESET_UARTE>;
+ dmas = <&gpcdma 20>, <&gpcdma 20>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -787,6 +795,8 @@ uartf: serial@3150000 {
interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTF>;
resets = <&bpmp TEGRA194_RESET_UARTF>;
+ dmas = <&gpcdma 12>, <&gpcdma 12>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -812,6 +822,8 @@ uarth: serial@3170000 {
interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTH>;
resets = <&bpmp TEGRA194_RESET_UARTH>;
+ dmas = <&gpcdma 13>, <&gpcdma 13>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -1609,6 +1621,8 @@ uartc: serial@c280000 {
interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTC>;
resets = <&bpmp TEGRA194_RESET_UARTC>;
+ dmas = <&gpcdma 3>, <&gpcdma 3>;
+ dma-names = "rx", "tx";
status = "disabled";
};
@@ -1619,6 +1633,8 @@ uartg: serial@c290000 {
interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&bpmp TEGRA194_CLK_UARTG>;
resets = <&bpmp TEGRA194_RESET_UARTG>;
+ dmas = <&gpcdma 2>, <&gpcdma 2>;
+ dma-names = "rx", "tx";
status = "disabled";
};
--
2.48.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] arm64: tegra: Clean up serial nodes
2025-04-29 1:51 [PATCH 0/2] arm64: tegra: Clean up serial nodes Aaron Kling via B4 Relay
2025-04-29 1:51 ` [PATCH 1/2] arm64: tegra: Drop remaining serial clock-names and reset-names Aaron Kling via B4 Relay
2025-04-29 1:51 ` [PATCH 2/2] arm64: tegra: Add DMA properties for Tegra186 and Tegra194 UARTs Aaron Kling via B4 Relay
@ 2025-05-08 20:59 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2025-05-08 20:59 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Aaron Kling
Cc: Krzysztof Kozlowski, devicetree, linux-tegra, linux-kernel
From: Thierry Reding <treding@nvidia.com>
On Mon, 28 Apr 2025 20:51:46 -0500, Aaron Kling wrote:
> Several Tegra186 and Tegra194 serial nodes still have invalid properties
> and/or are missing dma properties. This series corrects those.
>
>
Applied, thanks!
[1/2] arm64: tegra: Drop remaining serial clock-names and reset-names
commit: 4cd763297c2203c6ba587d7d4a9105f96597b998
[2/2] arm64: tegra: Add DMA properties for Tegra186 and Tegra194 UARTs
commit: 39e1cbf57e3034bff1272b83b9e606a0bc2c3dc3
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-08 20:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-29 1:51 [PATCH 0/2] arm64: tegra: Clean up serial nodes Aaron Kling via B4 Relay
2025-04-29 1:51 ` [PATCH 1/2] arm64: tegra: Drop remaining serial clock-names and reset-names Aaron Kling via B4 Relay
2025-04-29 1:51 ` [PATCH 2/2] arm64: tegra: Add DMA properties for Tegra186 and Tegra194 UARTs Aaron Kling via B4 Relay
2025-05-08 20:59 ` [PATCH 0/2] arm64: tegra: Clean up serial nodes Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®