* [PATCH] nvmem: rmem: select CONFIG_CRC32
@ 2025-04-28 15:08 Arnd Bergmann
2025-04-29 19:37 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-04-28 15:08 UTC (permalink / raw)
To: Srinivas Kandagatla, Greg Kroah-Hartman, Théo Lebrun
Cc: Arnd Bergmann, Miquel Raynal, Geert Uytterhoeven,
Rafał Miłecki, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added crc checking leads to a link failure if CRC32
itself is disabled:
x86_64-linux-ld: vmlinux.o: in function `rmem_eyeq5_checksum':
rmem.c:(.text+0x52341b): undefined reference to `crc32_le_arch'
Fixes: 7e606c311f70 ("nvmem: rmem: add CRC validation for Mobileye EyeQ5 NVMEM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/nvmem/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 8671b7c974b9..eceb3cdb421f 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -260,6 +260,7 @@ config NVMEM_RCAR_EFUSE
config NVMEM_RMEM
tristate "Reserved Memory Based Driver Support"
depends on HAS_IOMEM
+ select CRC32
help
This driver maps reserved memory into an nvmem device. It might be
useful to expose information left by firmware in memory.
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nvmem: rmem: select CONFIG_CRC32
2025-04-28 15:08 [PATCH] nvmem: rmem: select CONFIG_CRC32 Arnd Bergmann
@ 2025-04-29 19:37 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2025-04-29 19:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Théo Lebrun, Arnd Bergmann
Cc: Arnd Bergmann, Miquel Raynal, Geert Uytterhoeven,
Rafał Miłecki, linux-kernel
On Mon, 28 Apr 2025 17:08:26 +0200, Arnd Bergmann wrote:
> The newly added crc checking leads to a link failure if CRC32
> itself is disabled:
>
> x86_64-linux-ld: vmlinux.o: in function `rmem_eyeq5_checksum':
> rmem.c:(.text+0x52341b): undefined reference to `crc32_le_arch'
>
>
> [...]
Applied, thanks!
[1/1] nvmem: rmem: select CONFIG_CRC32
commit: f1a714e1cd0d29f7b0ffa5ec404784aac15e9af4
Best regards,
--
Srinivas Kandagatla <srini@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-29 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-28 15:08 [PATCH] nvmem: rmem: select CONFIG_CRC32 Arnd Bergmann
2025-04-29 19:37 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®