mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Artur Weber <aweber.kernel@gmail.com>
To: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	 Mark Brown <broonie@kernel.org>,
	 Florian Fainelli <florian.fainelli@broadcom.com>,
	 Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	 Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>
Cc: Stanislav Jakubek <stano.jakubek@gmail.com>,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 ~postmarketos/upstreaming@lists.sr.ht,
	 Artur Weber <aweber.kernel@gmail.com>
Subject: [PATCH v8 6/9] regulator: bcm590xx: Use dev_err_probe for regulator register error
Date: Wed, 30 Apr 2025 09:07:10 +0200	[thread overview]
Message-ID: <20250430-bcm59054-v8-6-e4cf638169a4@gmail.com> (raw)
In-Reply-To: <20250430-bcm59054-v8-0-e4cf638169a4@gmail.com>

Instead of calling dev_err() and returning PTR_ERR(...) separately, use
a single "return dev_err_probe" statement.

Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
Changes in v4:
- Added this commit
---
 drivers/regulator/bcm590xx-regulator.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
index 9f0cda46b01506080ae5fa709104a8df4d174a8d..a17311fa30e4d48c0a4925778d7bed486ac7a982 100644
--- a/drivers/regulator/bcm590xx-regulator.c
+++ b/drivers/regulator/bcm590xx-regulator.c
@@ -340,12 +340,10 @@ static int bcm590xx_probe(struct platform_device *pdev)
 
 		rdev = devm_regulator_register(&pdev->dev, &pmu->desc[i],
 					       &config);
-		if (IS_ERR(rdev)) {
-			dev_err(bcm590xx->dev,
-				"failed to register %s regulator\n",
-				pdev->name);
-			return PTR_ERR(rdev);
-		}
+		if (IS_ERR(rdev))
+			return dev_err_probe(bcm590xx->dev, PTR_ERR(rdev),
+					     "failed to register %s regulator\n",
+					     pdev->name);
 	}
 
 	return 0;

-- 
2.49.0


  parent reply	other threads:[~2025-04-30  7:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30  7:07 [PATCH v8 0/9] mfd: bcm590xx: Add support for BCM59054 Artur Weber
2025-04-30  7:07 ` [PATCH v8 1/9] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2025-04-30  7:07 ` [PATCH v8 2/9] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2025-04-30  7:07 ` [PATCH v8 3/9] ARM: dts: Drop DTS for BCM59056 PMU Artur Weber
2025-05-06 15:08   ` Stanislav Jakubek
2025-04-30  7:07 ` [PATCH v8 4/9] mfd: bcm590xx: Add support for multiple device types + BCM59054 compatible Artur Weber
2025-05-09 14:09   ` Lee Jones
2025-05-14  8:52     ` Mark Brown
2025-05-15  7:13       ` Lee Jones
2025-05-15  8:02         ` Mark Brown
2025-05-15  9:20           ` Lee Jones
2025-05-15  9:33             ` Mark Brown
2025-05-15 11:28               ` Artur Weber
2025-05-15 11:30                 ` Mark Brown
2025-05-15 13:13                   ` Lee Jones
2025-05-15 15:46                     ` Artur Weber
2025-04-30  7:07 ` [PATCH v8 5/9] mfd: bcm590xx: Add PMU ID/revision parsing function Artur Weber
2025-05-06 16:11   ` Stanislav Jakubek
2025-05-06 19:03     ` Artur Weber
2025-05-06 20:27       ` Stanislav Jakubek
2025-05-09 14:12   ` Lee Jones
2025-04-30  7:07 ` Artur Weber [this message]
2025-04-30  7:07 ` [PATCH v8 7/9] regulator: bcm590xx: Store regulator descriptions in table Artur Weber
2025-04-30  7:07 ` [PATCH v8 8/9] regulator: bcm590xx: Rename BCM59056-specific data as such Artur Weber
2025-04-30  7:07 ` [PATCH v8 9/9] regulator: bcm590xx: Add support for BCM59054 regulators Artur Weber
2025-05-06 20:33 ` [PATCH v8 0/9] mfd: bcm590xx: Add support for BCM59054 Stanislav Jakubek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250430-bcm59054-v8-6-e4cf638169a4@gmail.com \
    --to=aweber.kernel@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stano.jakubek@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®