mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Artur Weber <aweber.kernel@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Stanislav Jakubek <stano.jakubek@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v8 4/9] mfd: bcm590xx: Add support for multiple device types + BCM59054 compatible
Date: Thu, 15 May 2025 10:20:00 +0100	[thread overview]
Message-ID: <20250515092000.GF2936510@google.com> (raw)
In-Reply-To: <aCWfre2-n_PSuhxR@finisterre.sirena.org.uk>

On Thu, 15 May 2025, Mark Brown wrote:

> On Thu, May 15, 2025 at 08:13:57AM +0100, Lee Jones wrote:
> > On Wed, 14 May 2025, Mark Brown wrote:
> 
> > > Could you be more explicit what you're looking for here, the diffstat is
> > > entirely MFD?
> 
> > Okay, more explicitly, I can merge this and MFD will have no issue.
> > However, the Regulator commits make use of 'pmu_id' introduced in this
> > change and would therefore cause a compile break.  So we could:
> 
> >   1. Apply this now and merge the dependents next cycle
> >   2. Apply this now and provide an IB
> >   3. Wait for all Acks and apply as a unified set
> 
> > We usually choose 3, hence my assumptions above.
> 
> Well, you choose 3 - I do think it'd be a lot easier to go with option
> 2, or with applying the rest to your tree as acks come in.  There seemed
> to still be a reasonable amount of discussion on the MFD bits (eg,
> there's some formatting comments still) so I was expecting this series
> to churn some more and was waiting for a resend.

Yes, I expected to apply v9 with your Ack.

I can go with 2 in this case.  Applying in dribs-and-drabs as Acks come
in would be sub-optimal and would likely end up in a mess.

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2025-05-15  9:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30  7:07 [PATCH v8 0/9] mfd: bcm590xx: Add support for BCM59054 Artur Weber
2025-04-30  7:07 ` [PATCH v8 1/9] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2025-04-30  7:07 ` [PATCH v8 2/9] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2025-04-30  7:07 ` [PATCH v8 3/9] ARM: dts: Drop DTS for BCM59056 PMU Artur Weber
2025-05-06 15:08   ` Stanislav Jakubek
2025-04-30  7:07 ` [PATCH v8 4/9] mfd: bcm590xx: Add support for multiple device types + BCM59054 compatible Artur Weber
2025-05-09 14:09   ` Lee Jones
2025-05-14  8:52     ` Mark Brown
2025-05-15  7:13       ` Lee Jones
2025-05-15  8:02         ` Mark Brown
2025-05-15  9:20           ` Lee Jones [this message]
2025-05-15  9:33             ` Mark Brown
2025-05-15 11:28               ` Artur Weber
2025-05-15 11:30                 ` Mark Brown
2025-05-15 13:13                   ` Lee Jones
2025-05-15 15:46                     ` Artur Weber
2025-04-30  7:07 ` [PATCH v8 5/9] mfd: bcm590xx: Add PMU ID/revision parsing function Artur Weber
2025-05-06 16:11   ` Stanislav Jakubek
2025-05-06 19:03     ` Artur Weber
2025-05-06 20:27       ` Stanislav Jakubek
2025-05-09 14:12   ` Lee Jones
2025-04-30  7:07 ` [PATCH v8 6/9] regulator: bcm590xx: Use dev_err_probe for regulator register error Artur Weber
2025-04-30  7:07 ` [PATCH v8 7/9] regulator: bcm590xx: Store regulator descriptions in table Artur Weber
2025-04-30  7:07 ` [PATCH v8 8/9] regulator: bcm590xx: Rename BCM59056-specific data as such Artur Weber
2025-04-30  7:07 ` [PATCH v8 9/9] regulator: bcm590xx: Add support for BCM59054 regulators Artur Weber
2025-05-06 20:33 ` [PATCH v8 0/9] mfd: bcm590xx: Add support for BCM59054 Stanislav Jakubek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250515092000.GF2936510@google.com \
    --to=lee@kernel.org \
    --cc=aweber.kernel@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=robh@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stano.jakubek@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®