From: Michal Luczaj <mhal@rbox.co>
To: "Stefano Garzarella" <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Michal Luczaj <mhal@rbox.co>
Subject: [PATCH net-next v4 0/3] vsock: SOCK_LINGER rework
Date: Thu, 01 May 2025 10:05:21 +0200 [thread overview]
Message-ID: <20250501-vsock-linger-v4-0-beabbd8a0847@rbox.co> (raw)
Change vsock's lingerning to wait on close() until all data is sent, i.e.
until workers picked all the packets for processing.
Changes in v4:
- While in virtio, stick to virtio_transport_unsent_bytes() [Stefano]
- Squash the indentation reduction [Stefano]
- Pull SOCK_LINGER check into vsock_linger() [Stefano]
- Don't explicitly pass sk->sk_lingertime [Stefano]
- Link to v3: https://lore.kernel.org/r/20250430-vsock-linger-v3-0-ddbe73b53457@rbox.co
Changes in v3:
- Set "vsock/virtio" topic where appropriate
- Do not claim that Hyper-V and VMCI ever lingered [Stefano]
- Move lingering to af_vsock core [Stefano]
- Link to v2: https://lore.kernel.org/r/20250421-vsock-linger-v2-0-fe9febd64668@rbox.co
Changes in v2:
- Comment that some transports do not implement unsent_bytes [Stefano]
- Reduce the indentation of virtio_transport_wait_close() [Stefano]
- Do not linger on shutdown(), expand the commit messages [Paolo]
- Link to v1: https://lore.kernel.org/r/20250407-vsock-linger-v1-0-1458038e3492@rbox.co
Changes in v1:
- Do not assume `unsent_bytes()` is implemented by all transports [Stefano]
- Link to v0: https://lore.kernel.org/netdev/df2d51fd-03e7-477f-8aea-938446f47864@rbox.co/
Signed-off-by: Michal Luczaj <mhal@rbox.co>
---
Michal Luczaj (3):
vsock/virtio: Linger on unsent data
vsock: Move lingering logic to af_vsock core
vsock/test: Expand linger test to ensure close() does not misbehave
include/net/af_vsock.h | 1 +
net/vmw_vsock/af_vsock.c | 30 ++++++++++++++++++++++++++++++
net/vmw_vsock/virtio_transport_common.c | 21 ++-------------------
tools/testing/vsock/vsock_test.c | 30 +++++++++++++++++++++++++++---
4 files changed, 60 insertions(+), 22 deletions(-)
---
base-commit: deeed351e982ac4d521598375b34b071304533b0
change-id: 20250304-vsock-linger-9026e5f9986c
Best regards,
--
Michal Luczaj <mhal@rbox.co>
next reply other threads:[~2025-05-01 8:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 8:05 Michal Luczaj [this message]
2025-05-01 8:05 ` [PATCH net-next v4 1/3] vsock/virtio: Linger on unsent data Michal Luczaj
2025-05-06 9:44 ` Stefano Garzarella
2025-05-01 8:05 ` [PATCH net-next v4 2/3] vsock: Move lingering logic to af_vsock core Michal Luczaj
2025-05-06 9:53 ` Stefano Garzarella
2025-05-06 22:47 ` Michal Luczaj
2025-05-01 8:05 ` [PATCH net-next v4 3/3] vsock/test: Expand linger test to ensure close() does not misbehave Michal Luczaj
2025-05-06 9:43 ` Stefano Garzarella
2025-05-06 9:46 ` Stefano Garzarella
2025-05-06 22:47 ` Michal Luczaj
2025-05-07 8:26 ` Stefano Garzarella
2025-05-12 12:23 ` Michal Luczaj
2025-05-20 8:54 ` Stefano Garzarella
2025-05-20 9:01 ` Stefano Garzarella
2025-05-20 10:20 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501-vsock-linger-v4-0-beabbd8a0847@rbox.co \
--to=mhal@rbox.co \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®