From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>, NeilBrown <neil@brown.name>
Cc: Sargun Dillon <sargun@sargun.me>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH v3 00/17] nfsd: observability improvements
Date: Sat, 03 May 2025 11:11:16 -0400 [thread overview]
Message-ID: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org> (raw)
Sorry these took a while! This version moves the new tracepoints closer
to the vfs layer, into the non-version specific common vfs helpers.
I've also made separate patches that remove the dprintks. Since the new
tracepoints aren't in the same places as the old dprintk's, there could
be an argument for keeping them. I'm fine with either.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Changes in v3:
- move most of the tracepoints into non-version specific nfsd/vfs.c calls
- rename them with a nfsd_vfs_* prefix
- remove the dprintks in separate patches
- Link to v2: https://lore.kernel.org/r/20250409-nfsd-tracepoints-v2-0-cf4e084fdd9c@kernel.org
Changes in v2:
- Break tracepoints out into multiple patches
- Flesh out the tracepoints in these locations to display the same info
as legacy dprintks.
- have all the tracepoints SVC_XPRT_ENDPOINT_* info
- update svc_xprt_dequeue tracepoint to show how long xprt was on queue
- Link to v1: https://lore.kernel.org/r/20250306-nfsd-tracepoints-v1-0-4405bf41b95f@kernel.org
---
Jeff Layton (17):
sunrpc: move the SVC_RQST_EVENT_*() macros to common header
nfsd: add a tracepoint for nfsd_setattr
nfsd: add a tracepoint to nfsd_lookup_dentry
nfsd: add nfsd_vfs_create tracepoints
nfsd: add tracepoint to nfsd_symlink
nfsd: add tracepoint to nfsd_link()
nfsd: add tracepoints for unlink events
nfsd: add tracepoint to nfsd_rename
nfsd: add tracepoint to nfsd_readdir
nfsd: add tracepoint for getattr and statfs events
nfsd: remove old v2/3 create path dprintks
nfsd: remove old v2/3 SYMLINK dprintks
nfsd: remove old LINK dprintks
nfsd: remove REMOVE/RMDIR dprintks
nfsd: remove dprintks for v2/3 RENAME events
nfsd: remove legacy READDIR dprintks
nfsd: remove legacy dprintks from GETATTR and STATFS codepaths
fs/nfsd/nfs3proc.c | 63 +-----------
fs/nfsd/nfs4proc.c | 2 +
fs/nfsd/nfsproc.c | 35 +------
fs/nfsd/trace.h | 218 ++++++++++++++++++++++++++++++++++++++++++
fs/nfsd/vfs.c | 18 +++-
include/trace/events/sunrpc.h | 23 -----
include/trace/misc/fs.h | 21 ++++
include/trace/misc/sunrpc.h | 23 +++++
8 files changed, 287 insertions(+), 116 deletions(-)
---
base-commit: d417fc0a03710ea5ed4c50d8eff3cf29cd86c87f
change-id: 20250303-nfsd-tracepoints-c82add9155a6
Best regards,
--
Jeff Layton <jlayton@kernel.org>
next reply other threads:[~2025-05-03 15:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 15:11 Jeff Layton [this message]
2025-05-03 15:11 ` [PATCH v3 01/17] sunrpc: move the SVC_RQST_EVENT_*() macros to common header Jeff Layton
2025-05-03 15:11 ` [PATCH v3 02/17] nfsd: add a tracepoint for nfsd_setattr Jeff Layton
2025-05-03 15:11 ` [PATCH v3 03/17] nfsd: add a tracepoint to nfsd_lookup_dentry Jeff Layton
2025-05-03 15:11 ` [PATCH v3 04/17] nfsd: add nfsd_vfs_create tracepoints Jeff Layton
2025-05-03 15:11 ` [PATCH v3 05/17] nfsd: add tracepoint to nfsd_symlink Jeff Layton
2025-05-03 15:11 ` [PATCH v3 06/17] nfsd: add tracepoint to nfsd_link() Jeff Layton
2025-05-03 15:11 ` [PATCH v3 07/17] nfsd: add tracepoints for unlink events Jeff Layton
2025-05-03 15:11 ` [PATCH v3 08/17] nfsd: add tracepoint to nfsd_rename Jeff Layton
2025-05-03 15:11 ` [PATCH v3 09/17] nfsd: add tracepoint to nfsd_readdir Jeff Layton
2025-05-03 15:11 ` [PATCH v3 10/17] nfsd: add tracepoint for getattr and statfs events Jeff Layton
2025-05-03 15:11 ` [PATCH v3 11/17] nfsd: remove old v2/3 create path dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 12/17] nfsd: remove old v2/3 SYMLINK dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 13/17] nfsd: remove old LINK dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 14/17] nfsd: remove REMOVE/RMDIR dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 15/17] nfsd: remove dprintks for v2/3 RENAME events Jeff Layton
2025-05-03 15:11 ` [PATCH v3 16/17] nfsd: remove legacy READDIR dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 17/17] nfsd: remove legacy dprintks from GETATTR and STATFS codepaths Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=sargun@sargun.me \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®