mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>,
	 Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>,  Tom Talpey <tom@talpey.com>,
	Trond Myklebust <trondmy@kernel.org>,
	 Anna Schumaker <anna@kernel.org>, NeilBrown <neil@brown.name>
Cc: Sargun Dillon <sargun@sargun.me>,
	linux-nfs@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Jeff Layton <jlayton@kernel.org>
Subject: [PATCH v3 17/17] nfsd: remove legacy dprintks from GETATTR and STATFS codepaths
Date: Sat, 03 May 2025 11:11:33 -0400	[thread overview]
Message-ID: <20250503-nfsd-tracepoints-v3-17-d89f445969af@kernel.org> (raw)
In-Reply-To: <20250503-nfsd-tracepoints-v3-0-d89f445969af@kernel.org>

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/nfsd/nfs3proc.c | 6 ------
 fs/nfsd/nfsproc.c  | 4 ----
 2 files changed, 10 deletions(-)

diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
index 5b0b5a00e13062a5e9387431aaf5d6a1adfea50f..59b1987a1e16f5dad2efe627e8c81e654edc1413 100644
--- a/fs/nfsd/nfs3proc.c
+++ b/fs/nfsd/nfs3proc.c
@@ -72,9 +72,6 @@ nfsd3_proc_getattr(struct svc_rqst *rqstp)
 
 	trace_nfsd_vfs_getattr(rqstp, &argp->fh);
 
-	dprintk("nfsd: GETATTR(3)  %s\n",
-		SVCFH_fmt(&argp->fh));
-
 	fh_copy(&resp->fh, &argp->fh);
 	resp->status = fh_verify(rqstp, &resp->fh, 0,
 				 NFSD_MAY_NOP | NFSD_MAY_BYPASS_GSS_ON_ROOT);
@@ -647,9 +644,6 @@ nfsd3_proc_fsstat(struct svc_rqst *rqstp)
 	struct nfsd_fhandle *argp = rqstp->rq_argp;
 	struct nfsd3_fsstatres *resp = rqstp->rq_resp;
 
-	dprintk("nfsd: FSSTAT(3)   %s\n",
-				SVCFH_fmt(&argp->fh));
-
 	resp->status = nfsd_statfs(rqstp, &argp->fh, &resp->stats, 0);
 	fh_put(&argp->fh);
 	resp->status = nfsd3_map_status(resp->status);
diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c
index 80f3c0c6c63d16c9324c92dca52c8814d9429bb1..1d1825cc3eda96b678dcb1fee62fbe84a144c9e2 100644
--- a/fs/nfsd/nfsproc.c
+++ b/fs/nfsd/nfsproc.c
@@ -57,8 +57,6 @@ nfsd_proc_getattr(struct svc_rqst *rqstp)
 
 	trace_nfsd_vfs_getattr(rqstp, &argp->fh);
 
-	dprintk("nfsd: GETATTR  %s\n", SVCFH_fmt(&argp->fh));
-
 	fh_copy(&resp->fh, &argp->fh);
 	resp->status = fh_verify(rqstp, &resp->fh, 0,
 				 NFSD_MAY_NOP | NFSD_MAY_BYPASS_GSS_ON_ROOT);
@@ -615,8 +613,6 @@ nfsd_proc_statfs(struct svc_rqst *rqstp)
 	struct nfsd_fhandle *argp = rqstp->rq_argp;
 	struct nfsd_statfsres *resp = rqstp->rq_resp;
 
-	dprintk("nfsd: STATFS   %s\n", SVCFH_fmt(&argp->fh));
-
 	resp->status = nfsd_statfs(rqstp, &argp->fh, &resp->stats,
 				   NFSD_MAY_BYPASS_GSS_ON_ROOT);
 	fh_put(&argp->fh);

-- 
2.49.0


      parent reply	other threads:[~2025-05-03 15:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-03 15:11 [PATCH v3 00/17] nfsd: observability improvements Jeff Layton
2025-05-03 15:11 ` [PATCH v3 01/17] sunrpc: move the SVC_RQST_EVENT_*() macros to common header Jeff Layton
2025-05-03 15:11 ` [PATCH v3 02/17] nfsd: add a tracepoint for nfsd_setattr Jeff Layton
2025-05-03 15:11 ` [PATCH v3 03/17] nfsd: add a tracepoint to nfsd_lookup_dentry Jeff Layton
2025-05-03 15:11 ` [PATCH v3 04/17] nfsd: add nfsd_vfs_create tracepoints Jeff Layton
2025-05-03 15:11 ` [PATCH v3 05/17] nfsd: add tracepoint to nfsd_symlink Jeff Layton
2025-05-03 15:11 ` [PATCH v3 06/17] nfsd: add tracepoint to nfsd_link() Jeff Layton
2025-05-03 15:11 ` [PATCH v3 07/17] nfsd: add tracepoints for unlink events Jeff Layton
2025-05-03 15:11 ` [PATCH v3 08/17] nfsd: add tracepoint to nfsd_rename Jeff Layton
2025-05-03 15:11 ` [PATCH v3 09/17] nfsd: add tracepoint to nfsd_readdir Jeff Layton
2025-05-03 15:11 ` [PATCH v3 10/17] nfsd: add tracepoint for getattr and statfs events Jeff Layton
2025-05-03 15:11 ` [PATCH v3 11/17] nfsd: remove old v2/3 create path dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 12/17] nfsd: remove old v2/3 SYMLINK dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 13/17] nfsd: remove old LINK dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 14/17] nfsd: remove REMOVE/RMDIR dprintks Jeff Layton
2025-05-03 15:11 ` [PATCH v3 15/17] nfsd: remove dprintks for v2/3 RENAME events Jeff Layton
2025-05-03 15:11 ` [PATCH v3 16/17] nfsd: remove legacy READDIR dprintks Jeff Layton
2025-05-03 15:11 ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250503-nfsd-tracepoints-v3-17-d89f445969af@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=sargun@sargun.me \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®