From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH 06/10] timers: Rename NEXT_TIMER_MAX_DELTA => TIMER_NEXT_MAX_DELTA
Date: Wed, 7 May 2025 19:53:34 +0200 [thread overview]
Message-ID: <20250507175338.672442-7-mingo@kernel.org> (raw)
In-Reply-To: <20250507175338.672442-1-mingo@kernel.org>
Move this macro to the canonical TIMER_* namespace.
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/powerpc/kvm/booke.c | 8 ++++----
include/linux/timer.h | 2 +-
kernel/time/timer.c | 12 ++++++------
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 6a4805968966..791d1942a058 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -572,7 +572,7 @@ static int kvmppc_booke_irqprio_deliver(struct kvm_vcpu *vcpu,
/*
* Return the number of jiffies until the next timeout. If the timeout is
- * longer than the NEXT_TIMER_MAX_DELTA, then return NEXT_TIMER_MAX_DELTA
+ * longer than the TIMER_NEXT_MAX_DELTA, then return TIMER_NEXT_MAX_DELTA
* because the larger value can break the timer APIs.
*/
static unsigned long watchdog_next_timeout(struct kvm_vcpu *vcpu)
@@ -598,7 +598,7 @@ static unsigned long watchdog_next_timeout(struct kvm_vcpu *vcpu)
if (do_div(nr_jiffies, tb_ticks_per_jiffy))
nr_jiffies++;
- return min_t(unsigned long long, nr_jiffies, NEXT_TIMER_MAX_DELTA);
+ return min_t(unsigned long long, nr_jiffies, TIMER_NEXT_MAX_DELTA);
}
static void arm_next_watchdog(struct kvm_vcpu *vcpu)
@@ -616,10 +616,10 @@ static void arm_next_watchdog(struct kvm_vcpu *vcpu)
spin_lock_irqsave(&vcpu->arch.wdt_lock, flags);
nr_jiffies = watchdog_next_timeout(vcpu);
/*
- * If the number of jiffies of watchdog timer >= NEXT_TIMER_MAX_DELTA
+ * If the number of jiffies of watchdog timer >= TIMER_NEXT_MAX_DELTA
* then do not run the watchdog timer as this can break timer APIs.
*/
- if (nr_jiffies < NEXT_TIMER_MAX_DELTA)
+ if (nr_jiffies < TIMER_NEXT_MAX_DELTA)
mod_timer(&vcpu->arch.wdt_timer, jiffies + nr_jiffies);
else
timer_delete(&vcpu->arch.wdt_timer);
diff --git a/include/linux/timer.h b/include/linux/timer.h
index 4e1237ff4b24..68cf8e28bbe0 100644
--- a/include/linux/timer.h
+++ b/include/linux/timer.h
@@ -156,7 +156,7 @@ extern int timer_reduce(struct timer_list *timer, unsigned long expires);
* The jiffies value which is added to now, when there is no timer
* in the timer wheel:
*/
-#define NEXT_TIMER_MAX_DELTA ((1UL << 30) - 1)
+#define TIMER_NEXT_MAX_DELTA ((1UL << 30) - 1)
extern void add_timer(struct timer_list *timer);
extern void add_timer_local(struct timer_list *timer);
diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index 6f520e5f548b..11c6a11a3569 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1900,7 +1900,7 @@ static void timer_recalc_next_expiry(struct timer_base *base)
unsigned long clk, next, adj;
unsigned lvl, offset = 0;
- next = base->clk + NEXT_TIMER_MAX_DELTA;
+ next = base->clk + TIMER_NEXT_MAX_DELTA;
clk = base->clk;
for (lvl = 0; lvl < LVL_DEPTH; lvl++, offset += LVL_SIZE) {
int pos = next_pending_bucket(base, offset, clk & LVL_MASK);
@@ -1963,7 +1963,7 @@ static void timer_recalc_next_expiry(struct timer_base *base)
WRITE_ONCE(base->next_expiry, next);
base->next_expiry_recalc = false;
- base->timers_pending = !(next == base->clk + NEXT_TIMER_MAX_DELTA);
+ base->timers_pending = !(next == base->clk + TIMER_NEXT_MAX_DELTA);
}
#ifdef CONFIG_NO_HZ_COMMON
@@ -2015,7 +2015,7 @@ static unsigned long next_timer_interrupt(struct timer_base *base,
* easy comparable to find out which base holds the first pending timer.
*/
if (!base->timers_pending)
- WRITE_ONCE(base->next_expiry, basej + NEXT_TIMER_MAX_DELTA);
+ WRITE_ONCE(base->next_expiry, basej + TIMER_NEXT_MAX_DELTA);
return base->next_expiry;
}
@@ -2399,7 +2399,7 @@ static inline void __run_timers(struct timer_base *base)
* timer at this clk are that all matching timers have been
* dequeued or no timer has been queued since
* base::next_expiry was set to base::clk +
- * NEXT_TIMER_MAX_DELTA.
+ * TIMER_NEXT_MAX_DELTA.
*/
WARN_ON_ONCE(!levels && !base->next_expiry_recalc
&& base->timers_pending);
@@ -2544,7 +2544,7 @@ int timers_prepare_cpu(unsigned int cpu)
for (b = 0; b < NR_BASES; b++) {
base = per_cpu_ptr(&timer_bases[b], cpu);
base->clk = jiffies;
- base->next_expiry = base->clk + NEXT_TIMER_MAX_DELTA;
+ base->next_expiry = base->clk + TIMER_NEXT_MAX_DELTA;
base->next_expiry_recalc = false;
base->timers_pending = false;
base->is_idle = false;
@@ -2599,7 +2599,7 @@ static void __init init_timer_cpu(int cpu)
base->cpu = cpu;
raw_spin_lock_init(&base->lock);
base->clk = jiffies;
- base->next_expiry = base->clk + NEXT_TIMER_MAX_DELTA;
+ base->next_expiry = base->clk + TIMER_NEXT_MAX_DELTA;
timer_base_init_expiry_lock(base);
}
}
--
2.45.2
next prev parent reply other threads:[~2025-05-07 17:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 17:53 [PATCH -v2 00/10] timers: Simple cleanup of the timer API namespace Ingo Molnar
2025-05-07 17:53 ` [PATCH 01/10] rust: Rename timer_container_of() to hrtimer_container_of() Ingo Molnar
2025-05-07 18:04 ` Andreas Hindborg
2025-05-07 19:38 ` Ingo Molnar
2025-05-12 9:29 ` Andreas Hindborg
2025-05-12 10:33 ` Andreas Hindborg
2025-05-15 17:23 ` [PATCH -v2 " Ingo Molnar
2025-05-07 17:53 ` [PATCH 02/10] timers: Rename init_timer_key() => timer_init_key() Ingo Molnar
2025-05-08 17:54 ` [tip: timers/cleanups] timers: Rename init_timer_key() as timer_init_key() tip-bot2 for Ingo Molnar
2025-05-07 17:53 ` [PATCH 03/10] timers: Rename init_timer_on_stack_key() => timer_init_key_on_stack() Ingo Molnar
2025-05-08 17:54 ` [tip: timers/cleanups] timers: Rename init_timer_on_stack_key() as timer_init_key_on_stack() tip-bot2 for Ingo Molnar
2025-05-07 17:53 ` [PATCH 04/10] timers: Rename __init_timer() => __timer_init() Ingo Molnar
2025-05-08 17:54 ` [tip: timers/cleanups] timers: Rename __init_timer() as __timer_init() tip-bot2 for Ingo Molnar
2025-05-07 17:53 ` [PATCH 05/10] timers: Rename __init_timer_on_stack() => __timer_init_on_stack() Ingo Molnar
2025-05-08 17:54 ` [tip: timers/cleanups] timers: Rename __init_timer_on_stack() as __timer_init_on_stack() tip-bot2 for Ingo Molnar
2025-05-07 17:53 ` Ingo Molnar [this message]
2025-05-08 17:54 ` [tip: timers/cleanups] timers: Rename NEXT_TIMER_MAX_DELTA as TIMER_NEXT_MAX_DELTA tip-bot2 for Ingo Molnar
2025-05-07 17:53 ` [PATCH 07/10] timers: Rename init_timers() => timers_init() Ingo Molnar
2025-05-08 17:54 ` [tip: timers/cleanups] timers: Rename init_timers() as timers_init() tip-bot2 for Ingo Molnar
2025-05-07 17:53 ` [PATCH 08/10] treewide, timers: Rename try_to_del_timer_sync() => timer_delete_sync_try() Ingo Molnar
2025-05-08 17:54 ` [tip: timers/cleanups] treewide, timers: Rename try_to_del_timer_sync() as timer_delete_sync_try() tip-bot2 for Ingo Molnar
2025-05-07 17:53 ` [PATCH 09/10] treewide, timers: Rename destroy_timer_on_stack() => timer_destroy_on_stack() Ingo Molnar
2025-05-08 17:54 ` [tip: timers/cleanups] treewide, timers: Rename destroy_timer_on_stack() as timer_destroy_on_stack() tip-bot2 for Ingo Molnar
2025-05-07 17:53 ` [PATCH 10/10] treewide, timers: Rename from_timer() => timer_container_of() Ingo Molnar
2025-05-09 5:51 ` [PATCH -v2 " Ingo Molnar
2025-06-08 7:13 ` [tip: timers/cleanups] treewide, timers: Rename from_timer() to timer_container_of() tip-bot2 for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507175338.672442-7-mingo@kernel.org \
--to=mingo@kernel.org \
--cc=frederic@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®