[PATCH] mtd: rawnand: brcmnand: remove unused parameters

[PATCH] mtd: rawnand: brcmnand: remove unused parameters

[Álvaro Fernández Rojas]

last_cmd and last_byte are now unused brcmnand_host members.
last_addr is only written and never read so we can remove it too.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 drivers/mtd/nand/raw/brcmnand/brcmnand.c | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 17f6d9723df9..5ef5d075a30c 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -310,9 +310,6 @@ struct brcmnand_host {
 	struct platform_device	*pdev;
 	int			cs;
 
-	unsigned int		last_cmd;
-	unsigned int		last_byte;
-	u64			last_addr;
 	struct brcmnand_cfg	hwcfg;
 	struct brcmnand_controller *ctrl;
 };
@@ -2237,10 +2234,8 @@ static int brcmnand_read_page(struct nand_chip *chip, uint8_t *buf,
 	u8 *oob = oob_required ? (u8 *)chip->oob_poi : NULL;
 	u64 addr = (u64)page << chip->page_shift;
 
-	host->last_addr = addr;
-
-	return brcmnand_read(mtd, chip, host->last_addr,
-			mtd->writesize >> FC_SHIFT, (u32 *)buf, oob);
+	return brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
+			     (u32 *)buf, oob);
 }
 
 static int brcmnand_read_page_raw(struct nand_chip *chip, uint8_t *buf,
@@ -2252,11 +2247,9 @@ static int brcmnand_read_page_raw(struct nand_chip *chip, uint8_t *buf,
 	int ret;
 	u64 addr = (u64)page << chip->page_shift;
 
-	host->last_addr = addr;
-
 	brcmnand_set_ecc_enabled(host, 0);
-	ret = brcmnand_read(mtd, chip, host->last_addr,
-			mtd->writesize >> FC_SHIFT, (u32 *)buf, oob);
+	ret = brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
+			    (u32 *)buf, oob);
 	brcmnand_set_ecc_enabled(host, 1);
 	return ret;
 }
@@ -2367,9 +2360,7 @@ static int brcmnand_write_page(struct nand_chip *chip, const uint8_t *buf,
 	void *oob = oob_required ? chip->oob_poi : NULL;
 	u64 addr = (u64)page << chip->page_shift;
 
-	host->last_addr = addr;
-
-	return brcmnand_write(mtd, chip, host->last_addr, (const u32 *)buf, oob);
+	return brcmnand_write(mtd, chip, addr, (const u32 *)buf, oob);
 }
 
 static int brcmnand_write_page_raw(struct nand_chip *chip, const uint8_t *buf,
@@ -2381,9 +2372,8 @@ static int brcmnand_write_page_raw(struct nand_chip *chip, const uint8_t *buf,
 	u64 addr = (u64)page << chip->page_shift;
 	int ret = 0;
 
-	host->last_addr = addr;
 	brcmnand_set_ecc_enabled(host, 0);
-	ret = brcmnand_write(mtd, chip, host->last_addr, (const u32 *)buf, oob);
+	ret = brcmnand_write(mtd, chip, addr, (const u32 *)buf, oob);
 	brcmnand_set_ecc_enabled(host, 1);
 
 	return ret;
-- 
2.39.5

Re: [PATCH] mtd: rawnand: brcmnand: remove unused parameters

[Florian Fainelli]

On 5/13/2025 8:10 AM, Álvaro Fernández Rojas wrote:
> last_cmd and last_byte are now unused brcmnand_host members.
> last_addr is only written and never read so we can remove it too.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

Re: [PATCH] mtd: rawnand: brcmnand: remove unused parameters

[kernel test robot]

Hi Álvaro,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mtd/nand/next]
[also build test WARNING on linus/master v6.15-rc6 next-20250513]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/lvaro-Fern-ndez-Rojas/mtd-rawnand-brcmnand-remove-unused-parameters/20250513-141316
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
patch link:    https://lore.kernel.org/r/20250513061052.547392-1-noltari%40gmail.com
patch subject: [PATCH] mtd: rawnand: brcmnand: remove unused parameters
config: arc-randconfig-002-20250514 (https://download.01.org/0day-ci/archive/20250514/202505140147.koX7Q1tn-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250514/202505140147.koX7Q1tn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505140147.koX7Q1tn-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/mtd/nand/raw/brcmnand/brcmnand.c: In function 'brcmnand_read_page':
>> drivers/mtd/nand/raw/brcmnand/brcmnand.c:2233:31: warning: unused variable 'host' [-Wunused-variable]
    2233 |         struct brcmnand_host *host = nand_get_controller_data(chip);
         |                               ^~~~
   drivers/mtd/nand/raw/brcmnand/brcmnand.c: In function 'brcmnand_write_page':
   drivers/mtd/nand/raw/brcmnand/brcmnand.c:2359:31: warning: unused variable 'host' [-Wunused-variable]
    2359 |         struct brcmnand_host *host = nand_get_controller_data(chip);
         |                               ^~~~


vim +/host +2233 drivers/mtd/nand/raw/brcmnand/brcmnand.c

27c5b17cd1b105 drivers/mtd/nand/brcmnand/brcmnand.c     Brian Norris           2015-03-06  2228  
b976168757f7f4 drivers/mtd/nand/raw/brcmnand/brcmnand.c Boris Brezillon        2018-09-06  2229  static int brcmnand_read_page(struct nand_chip *chip, uint8_t *buf,
b976168757f7f4 drivers/mtd/nand/raw/brcmnand/brcmnand.c Boris Brezillon        2018-09-06  2230  			      int oob_required, int page)
27c5b17cd1b105 drivers/mtd/nand/brcmnand/brcmnand.c     Brian Norris           2015-03-06  2231  {
b976168757f7f4 drivers/mtd/nand/raw/brcmnand/brcmnand.c Boris Brezillon        2018-09-06  2232  	struct mtd_info *mtd = nand_to_mtd(chip);
d699ed250c0738 drivers/mtd/nand/brcmnand/brcmnand.c     Boris Brezillon        2015-12-10 @2233  	struct brcmnand_host *host = nand_get_controller_data(chip);
27c5b17cd1b105 drivers/mtd/nand/brcmnand/brcmnand.c     Brian Norris           2015-03-06  2234  	u8 *oob = oob_required ? (u8 *)chip->oob_poi : NULL;
3c8260ce766342 drivers/mtd/nand/raw/brcmnand/brcmnand.c David Regan            2023-11-24  2235  	u64 addr = (u64)page << chip->page_shift;
27c5b17cd1b105 drivers/mtd/nand/brcmnand/brcmnand.c     Brian Norris           2015-03-06  2236  
898f67d076dde5 drivers/mtd/nand/raw/brcmnand/brcmnand.c Álvaro Fernández Rojas 2025-05-13  2237  	return brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
898f67d076dde5 drivers/mtd/nand/raw/brcmnand/brcmnand.c Álvaro Fernández Rojas 2025-05-13  2238  			     (u32 *)buf, oob);
27c5b17cd1b105 drivers/mtd/nand/brcmnand/brcmnand.c     Brian Norris           2015-03-06  2239  }
27c5b17cd1b105 drivers/mtd/nand/brcmnand/brcmnand.c     Brian Norris           2015-03-06  2240  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki