Re: [PATCH] dt-bindings: display: bridge: renesas,dsi: allow properties from dsi-controller

[Hugo Villeneuve <hugo@hugovil.com>]

On Wed, 14 May 2025 06:00:28 +0000
Biju Das <biju.das.jz@bp.renesas.com> wrote:

> Hi Hugo Villeneuve,
> 
> Thanks for your patch.
> 
> > -----Original Message-----
> > From: Hugo Villeneuve <hugo@hugovil.com>
> > Sent: 13 May 2025 17:23
> > Subject: [PATCH] dt-bindings: display: bridge: renesas,dsi: allow properties from dsi-controller
> > 
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > Allow to inherit valid properties from the dsi-controller. This fixes the following warning when
> > adding a panel property:
> > 
> > rzg2lc.dtb: dsi@10850000: '#address-cells', '#size-cells', 'panel@0' do not
> >     match any of the regexes: 'pinctrl-[0-9]+'
> >     from schema $id:
> >         http://devicetree.org/schemas/display/bridge/renesas,dsi.yaml#
> > 
> > Also add a panel property to the example.
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > ---
> >  .../bindings/display/bridge/renesas,dsi.yaml  | 21 +++++++++++++++++--
> >  1 file changed, 19 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > b/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > index e08c24633926b..e0906a46fb118 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> > @@ -128,14 +128,17 @@ required:
> >    - power-domains
> >    - ports
> > 
> > -additionalProperties: false
> > +unevaluatedProperties: false
> > 
> >  examples:
> >    - |
> > +    #include <dt-bindings/gpio/gpio.h>
> >      #include <dt-bindings/clock/r9a07g044-cpg.h>
> >      #include <dt-bindings/interrupt-controller/arm-gic.h>
> > 
> >      dsi0: dsi@10850000 {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> >          compatible = "renesas,r9a07g044-mipi-dsi", "renesas,rzg2l-mipi-dsi";
> >          reg = <0x10850000 0x20000>;
> >          interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>, @@ -160,6 +163,20 @@ examples:
> >          reset-names = "rst", "arst", "prst";
> >          power-domains = <&cpg>;
> > 
> > +        panel@0 {
> > +            compatible = "rocktech,jh057n00900";
> > +            reg = <0>;
> > +            vcc-supply = <&reg_2v8_p>;
> > +            iovcc-supply = <&reg_1v8_p>;
> > +            reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
> > +
> > +            port {
> > +                panel_in: endpoint {
> > +                    remote-endpoint = <&dsi0_out>;
> > +                };
> > +            };
> > +        };
> > +
> >          ports {
> >              #address-cells = <1>;
> >              #size-cells = <0>;
> > @@ -175,7 +192,7 @@ examples:
> >                  reg = <1>;
> >                  dsi0_out: endpoint {
> >                      data-lanes = <1 2 3 4>;
> > -                    remote-endpoint = <&adv7535_in>;
> > +                    remote-endpoint = <&panel_in>;
> 
> Can we make panel example as separate one?
> 
> 1) One example for using bridge device
> 2) One example for using direct panel.

Hi Biju,
sure, will do in V2.

Thank you,
Hugo.


> 
> Cheers,
> Biju
> 
> >                  };
> >              };
> >          };
> > 
> > base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
> > --
> > 2.39.5
> 
> 


-- 
Hugo Villeneuve