[PATCH linux next v2] taskstats: adjust indentation of xxx_delay_max/min

[PATCH linux next v2] taskstats: adjust indentation of xxx_delay_max/min

[jiang.kun2]

From: Wang Yaxin <wang.yaxin@zte.com.cn>

adjust indentation of xxx_delay_max/min in struct taskstats.

Signed-off-by: Wang Yaxin <wang.yaxin@zte.com.cn>
Signed-off-by: Jiang Kun <jiang.kun2@zte.com.cn>
---
v1->v2:
Some fixes according to:
https://lore.kernel.org/all/202505191436188855ReOYCghNWSoD1i2A4r9h@zte.com.cn/
1. remove the explain about xxx_delay_min/max

 include/uapi/linux/taskstats.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/uapi/linux/taskstats.h b/include/uapi/linux/taskstats.h
index d71aa022b2ef..5929030d4e8b 100644
--- a/include/uapi/linux/taskstats.h
+++ b/include/uapi/linux/taskstats.h
@@ -225,11 +225,11 @@ struct taskstats {
 	__u64	compact_delay_max;
 	__u64	compact_delay_min;

-	__u64    wpcopy_delay_max;
-	__u64    wpcopy_delay_min;
+	__u64	wpcopy_delay_max;
+	__u64	wpcopy_delay_min;

-	__u64    irq_delay_max;
-	__u64    irq_delay_min;
+	__u64	irq_delay_max;
+	__u64	irq_delay_min;
 };


-- 
2.25.1

Re: [PATCH linux next v2] taskstats: adjust indentation of xxx_delay_max/min

[yang.yang29]

[-- Attachment #1.1.1: Type: text/plain, Size: 309 bytes --]

> adjust indentation of xxx_delay_max/min in struct taskstats.
I think fixing indentation alone isn't worth a separate patch. There
are still a lot work to do, for example: reduce redundant assignment
and calculation code in delayacct_add_tsk(). So should we fix the
indentation as part of the next patch.

[-- Attachment #1.1.2: Type: text/html , Size: 375 bytes --]

Re: [PATCH linux next v2] taskstats: adjust indentation of xxx_delay_max/min

[Andrew Morton]

On Mon, 19 May 2025 22:32:44 +0800 (CST) <yang.yang29@zte.com.cn> wrote:

> > adjust indentation of xxx_delay_max/min in struct taskstats.
> I think fixing indentation alone isn't worth a separate patch. There
> are still a lot work to do, for example: reduce redundant assignment
> and calculation code in delayacct_add_tsk(). So should we fix the
> indentation as part of the next patch.

Ordinarily I'd agree.  But
taskstats-fix-struct-taskstats-breaks-backward-compatibility-since-version-15.patch
is presently in mm.git in quilt form, in the "mm-nonmm-unstable"
branch.  So I can add Jiang's fix and later fold it into the base patch
before moving it all into the non-rebasing "mm-stable" branch.

This is one of the reasons why I use this hybrid quilt/git scheme - so
patches and changelogs can easily be updated during their stabilization
phase.