[PATCH 0/4] gpio: select GPIOLIB_IRQCHIP for various entries

[PATCH 0/4] gpio: select GPIOLIB_IRQCHIP for various entries

[Peng Fan (OSS)]

There was an effort to make irq_chip immutable for several drivers,
but kernel test robot reports build errors for:
gpio-mpc8xxx
gpio-pxa
gpio-davinci

Thanks to Bartosz for helping on this.

To avoid potential build failure with random config, select
GPIOLIB_IRQCHIP for bcm-kona, grgpio, lpc18xx, timberdale.

Build pass with:
 for i in `ls arch/arm/configs`
 do
 echo $i
 make ARCH=arm $i
 make ARCH=arm zImage -j32  > /dev/null
 done

And build with arm64 defconfig.

Hope all is good now.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Peng Fan (4):
      gpio: bcm-kona: select GPIOLIB_IRQCHIP
      gpio: grgpio: select GPIOLIB_IRQCHIP
      gpio: lpc18xx: select GPIOLIB_IRQCHIP
      gpio: timberdale: select GPIOLIB_IRQCHIP

 drivers/gpio/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
base-commit: 4e9d73034196ac8ab496bb47583197b36ba13327
change-id: 20250522-gpio-fix-bea5cc4ace8f

Best regards,
-- 
Peng Fan <peng.fan@nxp.com>

[PATCH 1/4] gpio: bcm-kona: select GPIOLIB_IRQCHIP

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: 7b04f98027af ("gpio: bcm-kona: make irq_chip immutable")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index c3465fd82b08f83a07b0afbca7d42e7e5bdccf70..ac0c646451a549f6db4d58c2fa4aa8270c9513e9 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -201,6 +201,7 @@ config GPIO_RASPBERRYPI_EXP
 config GPIO_BCM_KONA
 	bool "Broadcom Kona GPIO"
 	depends on ARCH_BCM_MOBILE || COMPILE_TEST
+	select GPIOLIB_IRQCHIP
 	help
 	  Turn on GPIO support for Broadcom "Kona" chips.
 

-- 
2.37.1

[PATCH 2/4] gpio: grgpio: select GPIOLIB_IRQCHIP

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: a30be40bf1d4 ("gpio: grgpio: Make irq_chip immutable")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index ac0c646451a549f6db4d58c2fa4aa8270c9513e9..2ff53b00cf7c956acc9d995e4cf07da1587a4035 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -354,7 +354,7 @@ config GPIO_GRGPIO
 	tristate "Aeroflex Gaisler GRGPIO support"
 	depends on OF || COMPILE_TEST
 	select GPIO_GENERIC
-	select IRQ_DOMAIN
+	select GPIOLIB_IRQCHIP
 	help
 	  Select this to support Aeroflex Gaisler GRGPIO cores from the GRLIB
 	  VHDL IP core library.

-- 
2.37.1

[PATCH 3/4] gpio: lpc18xx: select GPIOLIB_IRQCHIP

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: 289e42df1358 ("gpio: lpc18xx: Make irq_chip immutable")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 2ff53b00cf7c956acc9d995e4cf07da1587a4035..c75fc8fc7bb23088a4f15d61d4b40172a41ae078 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -438,6 +438,7 @@ config GPIO_LPC18XX
 	default y if ARCH_LPC18XX
 	depends on OF_GPIO && (ARCH_LPC18XX || COMPILE_TEST)
 	select IRQ_DOMAIN_HIERARCHY
+	select GPIOLIB_IRQCHIP
 	help
 	  Select this option to enable GPIO driver for
 	  NXP LPC18XX/43XX devices.

-- 
2.37.1

Re: [PATCH 3/4] gpio: lpc18xx: select GPIOLIB_IRQCHIP

[Vladimir Zapolskiy]

On 5/22/25 10:11, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
> 
> Fixes: 289e42df1358 ("gpio: lpc18xx: Make irq_chip immutable")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>

--
Best wishes,
Vladimir

[PATCH 4/4] gpio: timberdale: select GPIOLIB_IRQCHIP

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: 2993d2dd8ff4 ("gpio: timberdale: Make irq_chip immutable")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index c75fc8fc7bb23088a4f15d61d4b40172a41ae078..44f922e10db2f8dcbdacf79ccd27b0fd9cd93564 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1557,6 +1557,7 @@ config GPIO_TC3589X
 config GPIO_TIMBERDALE
 	bool "Support for timberdale GPIO IP"
 	depends on MFD_TIMBERDALE
+	select GPIOLIB_IRQCHIP
 	help
 	Add support for the GPIO IP in the timberdale FPGA.
 

-- 
2.37.1

Re: [PATCH 0/4] gpio: select GPIOLIB_IRQCHIP for various entries

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Thu, 22 May 2025 15:11:49 +0800, Peng Fan (OSS) wrote:
> There was an effort to make irq_chip immutable for several drivers,
> but kernel test robot reports build errors for:
> gpio-mpc8xxx
> gpio-pxa
> gpio-davinci
> 
> Thanks to Bartosz for helping on this.
> 
> [...]

Applied, thanks!

[1/4] gpio: bcm-kona: select GPIOLIB_IRQCHIP
      https://git.kernel.org/brgl/linux/c/86fabf1b174069465ea12b4140cb35543fd0c738
[2/4] gpio: grgpio: select GPIOLIB_IRQCHIP
      https://git.kernel.org/brgl/linux/c/3dff3563cc11e90f046902f0b2be40e82f5ee251
[3/4] gpio: lpc18xx: select GPIOLIB_IRQCHIP
      https://git.kernel.org/brgl/linux/c/01e4397d0c1c9ae434c574f45359ad0c226a864b
[4/4] gpio: timberdale: select GPIOLIB_IRQCHIP
      https://git.kernel.org/brgl/linux/c/8b8ef309093ff196967a21ee51a9cdb404a13bf6

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>