Re: [PATCH] EDAC/bluefield: dont use bluefield_edac_readl result on error

[Borislav Petkov <bp@alien8.de>]

On Thu, May 22, 2025 at 03:41:23PM +0000, David Thompson wrote:
> > -----Original Message-----
> > From: David Thompson <davthompson@nvidia.com>
> > Sent: Tuesday, March 18, 2025 5:48 PM
> > To: Shravan Ramani <shravankr@nvidia.com>; bp@alien8.de;
> > tony.luck@intel.com; james.morse@arm.com; mchehab@kernel.org;
> > rric@kernel.org
> > Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; David Thompson
> > <davthompson@nvidia.com>
> > Subject: [PATCH] EDAC/bluefield: dont use bluefield_edac_readl result on error
> > 
> > The "bluefield_edac_readl()" routine returns an uninitialized result during error
> > paths. In those cases the calling routine should not use the uninitialized result.
> > The driver should simply log the error, and then return early.
> > 
> > Fixes: e41967575474 ("EDAC/bluefield: Use Arm SMC for EMI access on
> > BlueField-2")
> > Signed-off-by: David Thompson <davthompson@nvidia.com>
> > Reviewed-by: Shravan Kumar Ramani <shravankr@nvidia.com>
> > ---
> >  drivers/edac/bluefield_edac.c | 20 +++++++++++++++-----
> >  1 file changed, 15 insertions(+), 5 deletions(-)
> > 
> 
> Refreshing this review...
> 
> Does anyone have feedback on this EDAC driver patch?

Looks like it fell through the cracks... :-\

Queued now.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette