From: David Thompson <davthompson@nvidia.com>
To: Shravan Ramani <shravankr@nvidia.com>,
"bp@alien8.de" <bp@alien8.de>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"rric@kernel.org" <rric@kernel.org>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] EDAC/bluefield: dont use bluefield_edac_readl result on error
Date: Thu, 22 May 2025 15:41:23 +0000 [thread overview]
Message-ID: <PH7PR12MB590226280DF463501FA9D0F8C799A@PH7PR12MB5902.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20250318214747.12271-1-davthompson@nvidia.com>
> -----Original Message-----
> From: David Thompson <davthompson@nvidia.com>
> Sent: Tuesday, March 18, 2025 5:48 PM
> To: Shravan Ramani <shravankr@nvidia.com>; bp@alien8.de;
> tony.luck@intel.com; james.morse@arm.com; mchehab@kernel.org;
> rric@kernel.org
> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; David Thompson
> <davthompson@nvidia.com>
> Subject: [PATCH] EDAC/bluefield: dont use bluefield_edac_readl result on error
>
> The "bluefield_edac_readl()" routine returns an uninitialized result during error
> paths. In those cases the calling routine should not use the uninitialized result.
> The driver should simply log the error, and then return early.
>
> Fixes: e41967575474 ("EDAC/bluefield: Use Arm SMC for EMI access on
> BlueField-2")
> Signed-off-by: David Thompson <davthompson@nvidia.com>
> Reviewed-by: Shravan Kumar Ramani <shravankr@nvidia.com>
> ---
> drivers/edac/bluefield_edac.c | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
Refreshing this review...
Does anyone have feedback on this EDAC driver patch?
Thanks, Dave
next prev parent reply other threads:[~2025-05-22 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 21:47 David Thompson
2025-05-22 15:41 ` David Thompson [this message]
2025-05-22 16:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR12MB590226280DF463501FA9D0F8C799A@PH7PR12MB5902.namprd12.prod.outlook.com \
--to=davthompson@nvidia.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=shravankr@nvidia.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®