* [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER
@ 2025-05-23 12:11 Arnd Bergmann
2025-05-23 12:16 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2025-05-23 12:11 UTC (permalink / raw)
To: Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Linus Walleij
Cc: Arnd Bergmann, Jessica Zhang, Dmitry Baryshkov, Danila Tikhonov,
Jakob Hauser, Jerome Brunet, AngeloGioacchino Del Regno,
Sebastian Reichel, Hironori KIKUCHI, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added driver uses the DSC helper module, but does not
select its Kconfig symbol, so configurations are possible that
cause a link failure:
ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-novatek-nt37801.ko] undefined!
Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/panel/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 721581d425b4..cfebb08e8a62 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -522,6 +522,8 @@ config DRM_PANEL_NOVATEK_NT37801
depends on OF
depends on DRM_MIPI_DSI
depends on BACKLIGHT_CLASS_DEVICE
+ select DRM_DISPLAY_DSC_HELPER
+ select DRM_DISPLAY_HELPER
help
Say Y here if you want to enable support for Novatek NT37801 (or
NT37810) AMOLED DSI Video Mode LCD panel module with 1440x3200
--
2.39.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER
2025-05-23 12:11 [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER Arnd Bergmann
@ 2025-05-23 12:16 ` Krzysztof Kozlowski
2025-05-23 20:56 ` Dmitry Baryshkov
2025-05-23 20:58 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-23 12:16 UTC (permalink / raw)
To: Arnd Bergmann, Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Linus Walleij
Cc: Arnd Bergmann, Jessica Zhang, Dmitry Baryshkov, Danila Tikhonov,
Jakob Hauser, Jerome Brunet, AngeloGioacchino Del Regno,
Sebastian Reichel, Hironori KIKUCHI, dri-devel, linux-kernel
On 23/05/2025 14:11, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added driver uses the DSC helper module, but does not
> select its Kconfig symbol, so configurations are possible that
> cause a link failure:
>
> ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-novatek-nt37801.ko] undefined!
>
> Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
Indeed, I wrote the driver first without DSC and forgot about it later.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER
2025-05-23 12:11 [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER Arnd Bergmann
2025-05-23 12:16 ` Krzysztof Kozlowski
@ 2025-05-23 20:56 ` Dmitry Baryshkov
2025-05-23 20:58 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-05-23 20:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Linus Walleij, Arnd Bergmann, Jessica Zhang,
Danila Tikhonov, Jakob Hauser, Jerome Brunet,
AngeloGioacchino Del Regno, Sebastian Reichel, Hironori KIKUCHI,
dri-devel, linux-kernel
On Fri, May 23, 2025 at 02:11:22PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added driver uses the DSC helper module, but does not
> select its Kconfig symbol, so configurations are possible that
> cause a link failure:
>
> ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-novatek-nt37801.ko] undefined!
>
> Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/panel/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER
2025-05-23 12:11 [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER Arnd Bergmann
2025-05-23 12:16 ` Krzysztof Kozlowski
2025-05-23 20:56 ` Dmitry Baryshkov
@ 2025-05-23 20:58 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-05-23 20:58 UTC (permalink / raw)
To: Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Krzysztof Kozlowski, Linus Walleij, Arnd Bergmann
Cc: Arnd Bergmann, Jessica Zhang, Dmitry Baryshkov, Danila Tikhonov,
Jakob Hauser, Jerome Brunet, AngeloGioacchino Del Regno,
Sebastian Reichel, Hironori KIKUCHI, dri-devel, linux-kernel
On Fri, 23 May 2025 14:11:22 +0200, Arnd Bergmann wrote:
> The newly added driver uses the DSC helper module, but does not
> select its Kconfig symbol, so configurations are possible that
> cause a link failure:
>
> ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-novatek-nt37801.ko] undefined!
>
>
> [...]
Applied to drm-misc-next-fixes, thanks!
[1/1] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER
commit: 022546cdbf26ec6f42af7e2706702d5703df42f6
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-23 20:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-23 12:11 [PATCH] drm/panel: nt37801: select CONFIG_DRM_DISPLAY_DSC_HELPER Arnd Bergmann
2025-05-23 12:16 ` Krzysztof Kozlowski
2025-05-23 20:56 ` Dmitry Baryshkov
2025-05-23 20:58 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®