* [PATCH] ASoC: qdsp6: fix compile-testing without CONFIG_OF
@ 2025-05-23 12:11 Arnd Bergmann
2025-05-23 12:33 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-05-23 12:11 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Wesley Cheng, Greg Kroah-Hartman
Cc: Arnd Bergmann, Dan Carpenter, Dmitry Baryshkov, linux-sound,
linux-arm-msm, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The driver builds cleanly only when CONFIG_OF is enabled, otherwise the
compiler notices an unused symbol:
sound/soc/qcom/qdsp6/q6usb.c:401:34: error: 'q6usb_dai_device_id' defined but not used [-Werror=unused-const-variable=]
The driver does not support legacy board files, so the of_match_ptr()
annotation has no use here and can be removed to avoid the warning.
Fixes: e0dd9240f13a ("ASoC: qcom: qdsp6: Fetch USB offload mapped card and PCM device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/qcom/qdsp6/q6usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6usb.c b/sound/soc/qcom/qdsp6/q6usb.c
index adba0446f301..ebe0c2425927 100644
--- a/sound/soc/qcom/qdsp6/q6usb.c
+++ b/sound/soc/qcom/qdsp6/q6usb.c
@@ -407,7 +407,7 @@ MODULE_DEVICE_TABLE(of, q6usb_dai_device_id);
static struct platform_driver q6usb_dai_platform_driver = {
.driver = {
.name = "q6usb-dai",
- .of_match_table = of_match_ptr(q6usb_dai_device_id),
+ .of_match_table = q6usb_dai_device_id,
},
.probe = q6usb_dai_dev_probe,
/*
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: qdsp6: fix compile-testing without CONFIG_OF
2025-05-23 12:11 [PATCH] ASoC: qdsp6: fix compile-testing without CONFIG_OF Arnd Bergmann
@ 2025-05-23 12:33 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2025-05-23 12:33 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Wesley Cheng, Arnd Bergmann, Dan Carpenter,
Dmitry Baryshkov, linux-sound, linux-arm-msm, linux-kernel
On Fri, May 23, 2025 at 02:11:47PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver builds cleanly only when CONFIG_OF is enabled, otherwise the
> compiler notices an unused symbol:
>
> sound/soc/qcom/qdsp6/q6usb.c:401:34: error: 'q6usb_dai_device_id' defined but not used [-Werror=unused-const-variable=]
>
> The driver does not support legacy board files, so the of_match_ptr()
> annotation has no use here and can be removed to avoid the warning.
>
> Fixes: e0dd9240f13a ("ASoC: qcom: qdsp6: Fetch USB offload mapped card and PCM device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/qcom/qdsp6/q6usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I'll take this in the USB tree as that's where the offending commit came
from.
Thanks!
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-23 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-23 12:11 [PATCH] ASoC: qdsp6: fix compile-testing without CONFIG_OF Arnd Bergmann
2025-05-23 12:33 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®