* [PATCH] ARM: dts: bcm958625-meraki-mx6x: Use #pwm-cells = <3>
@ 2025-05-27 18:13 Uwe Kleine-König
2025-05-27 22:40 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2025-05-27 18:13 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ray Jui,
Scott Branden, Rafał Miłecki, Florian Fainelli
Cc: Broadcom internal kernel review list, devicetree,
linux-arm-kernel, linux-kernel
bcm-nsp.dtsi has #pwm-cells = <3> as is specified in the binding. So to
also use that correct value for bcm958625-meraki-mx6x the property
overriding that value just has to be dropped. This fixes a few warnings
like:
arch/arm/boot/dts/broadcom/bcm958625-meraki-mx65.dtb: pwm@31000: #pwm-cells: 3 was expected
from schema $id: http://devicetree.org/schemas/pwm/brcm,iproc-pwm.yaml#
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
.../boot/dts/broadcom/bcm958625-meraki-mx6x-common.dtsi | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/broadcom/bcm958625-meraki-mx6x-common.dtsi b/arch/arm/boot/dts/broadcom/bcm958625-meraki-mx6x-common.dtsi
index 71a8b77b46f4..7e71aecb7251 100644
--- a/arch/arm/boot/dts/broadcom/bcm958625-meraki-mx6x-common.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm958625-meraki-mx6x-common.dtsi
@@ -17,21 +17,21 @@ pwm-leds {
led-1 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_RED>;
- pwms = <&pwm 1 50000>;
+ pwms = <&pwm 1 50000 0>;
max-brightness = <255>;
};
led-2 {
function = LED_FUNCTION_POWER;
color = <LED_COLOR_ID_GREEN>;
- pwms = <&pwm 2 50000>;
+ pwms = <&pwm 2 50000 0>;
max-brightness = <255>;
};
led-3 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_BLUE>;
- pwms = <&pwm 3 50000>;
+ pwms = <&pwm 3 50000 0>;
max-brightness = <255>;
};
};
@@ -132,7 +132,6 @@ pwm_leds: pwm_leds {
&pwm {
status = "okay";
- #pwm-cells = <2>;
};
&uart0 {
base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
--
2.47.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: bcm958625-meraki-mx6x: Use #pwm-cells = <3>
2025-05-27 18:13 [PATCH] ARM: dts: bcm958625-meraki-mx6x: Use #pwm-cells = <3> Uwe Kleine-König
@ 2025-05-27 22:40 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2025-05-27 22:40 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Ray Jui, Scott Branden,
Rafał Miłecki, Florian Fainelli
Cc: Florian Fainelli, devicetree, linux-arm-kernel, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
On Tue, 27 May 2025 20:13:18 +0200, Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
> bcm-nsp.dtsi has #pwm-cells = <3> as is specified in the binding. So to
> also use that correct value for bcm958625-meraki-mx6x the property
> overriding that value just has to be dropped. This fixes a few warnings
> like:
>
> arch/arm/boot/dts/broadcom/bcm958625-meraki-mx65.dtb: pwm@31000: #pwm-cells: 3 was expected
> from schema $id: http://devicetree.org/schemas/pwm/brcm,iproc-pwm.yaml#
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-27 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-27 18:13 [PATCH] ARM: dts: bcm958625-meraki-mx6x: Use #pwm-cells = <3> Uwe Kleine-König
2025-05-27 22:40 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®