From: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
To: krzk@kernel.org
Cc: abd.masalkhi@gmail.com, arnd@arndb.de, conor+dt@kernel.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
robh@kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: Add Device Tree binding for ST M24LR control interface
Date: Sun, 1 Jun 2025 07:31:47 +0000 [thread overview]
Message-ID: <20250601073147.2019266-1-abd.masalkhi@gmail.com> (raw)
In-Reply-To: <852ef4fd-6c26-4f79-a1d4-b3e37926ed7a@kernel.org>
Hi Krzysztof,
Thank you for your review.
> Drop quotes. So this is I2C mux or EEPROM?
The system parameter sector and the EEPROM do not share a continuous address
space, each starts at address 0 and spans its own internal region. This
overlapping addressing creates ambiguity if treated as a single memory space.
Additionally, there's a synchronization issue: during multi-page writes to
the EEPROM, if a control command (e.g., a lock) is issued mid-operation,
it may result in partial or inconsistent writes.
To address both challenges, the driver uses a mux-based design:
1- The m24lr_ctl driver acts as a gate for EEPROM access.
2- It provides exclusive, serialized access and handles the control interface.
3- The EEPROM itself is exposed as a child node using the standard at24 driver.
This separation ensures reliable operation and a clean, maintainable
architecture.
> That's not a misc device, but eeprom. Place it in appropriate directory.
Given the above, I'm unsure if placing it under eeprom/ is the best choice.
Would you suggest still placing it eeprom or under somewhere else maybe i2c/
(e.g., i2c/i2c-mux-stm24lr.yaml)?
Best regards,
Abd-Alrhman Masalkhi
next prev parent reply other threads:[~2025-06-01 7:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-31 8:11 [PATCH 0/3] Add control driver for ST M24LR RFID/NFC EEPROM chips Abd-Alrhman Masalkhi
2025-05-31 8:11 ` [PATCH 1/3] dt-bindings: misc: Add binding for ST M24LR control interface Abd-Alrhman Masalkhi
2025-05-31 9:25 ` Rob Herring (Arm)
2025-05-31 13:37 ` Krzysztof Kozlowski
2025-06-01 7:31 ` Abd-Alrhman Masalkhi [this message]
2025-05-31 8:11 ` [PATCH 2/3] misc: add sysfs control driver for ST M24LR series RFID/NFC chips Abd-Alrhman Masalkhi
2025-05-31 8:24 ` Greg KH
2025-05-31 8:25 ` Greg KH
2025-06-01 2:19 ` kernel test robot
2025-06-01 3:21 ` kernel test robot
2025-05-31 8:11 ` [PATCH 3/3] MAINTAINERS: Add entry for ST M24LR control driver Abd-Alrhman Masalkhi
2025-05-31 13:37 ` Krzysztof Kozlowski
2025-06-01 15:42 [PATCH v2 1/3] dt-bindings: eeprom: Add ST M24LR control interface Krzysztof Kozlowski
2025-06-02 3:48 ` [PATCH v2 1/3] dt-bindings: Add Device Tree binding for " Abd-Alrhman Masalkhi
2025-06-02 6:28 ` Krzysztof Kozlowski
2025-06-02 17:23 ` Abd-Alrhman Masalkhi
2025-06-02 18:11 ` Krzysztof Kozlowski
2025-06-02 17:47 ` Abd-Alrhman Masalkhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250601073147.2019266-1-abd.masalkhi@gmail.com \
--to=abd.masalkhi@gmail.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®