[PATCH] samples: vfio-mdev: mtty.c: delete MODULE_VERSION

[PATCH] samples: vfio-mdev: mtty.c: delete MODULE_VERSION

[Xose Vazquez Perez]

Reminiscence of ancient times when modules were developed outside the kernel.

Cc: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: KVM ML <kvm@vger.kernel.org>
Cc: KERNEL ML <linux-kernel@vger.kernel.org>
---
 samples/vfio-mdev/mtty.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
index 59eefe2fed10..f9f7472516c9 100644
--- a/samples/vfio-mdev/mtty.c
+++ b/samples/vfio-mdev/mtty.c
@@ -35,7 +35,6 @@
  * #defines
  */
 
-#define VERSION_STRING  "0.1"
 #define DRIVER_AUTHOR   "NVIDIA Corporation"
 
 #define MTTY_CLASS_NAME "mtty"
@@ -2057,5 +2056,4 @@ module_exit(mtty_dev_exit)
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");
-MODULE_VERSION(VERSION_STRING);
 MODULE_AUTHOR(DRIVER_AUTHOR);
-- 
2.49.0

Re: [PATCH] samples: vfio-mdev: mtty.c: delete MODULE_VERSION

[Alex Williamson]

On Sat, 31 May 2025 18:18:36 +0200
Xose Vazquez Perez <xose.vazquez@gmail.com> wrote:

> Reminiscence of ancient times when modules were developed outside the kernel.

s/Reminiscence/Reminiscent/

I think there are likely better arguments that could be made for
removal though, ex. citing specific policies or discussions.

> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: KVM ML <kvm@vger.kernel.org>
> Cc: KERNEL ML <linux-kernel@vger.kernel.org>

Signed-off-by?

See Developer's Certificate of Origin:
Documentation/process/submitting-patches.rst

Thanks,
Alex

> ---
>  samples/vfio-mdev/mtty.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index 59eefe2fed10..f9f7472516c9 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -35,7 +35,6 @@
>   * #defines
>   */
>  
> -#define VERSION_STRING  "0.1"
>  #define DRIVER_AUTHOR   "NVIDIA Corporation"
>  
>  #define MTTY_CLASS_NAME "mtty"
> @@ -2057,5 +2056,4 @@ module_exit(mtty_dev_exit)
>  
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("Test driver that simulate serial port over PCI");
> -MODULE_VERSION(VERSION_STRING);
>  MODULE_AUTHOR(DRIVER_AUTHOR);