[PATCH RFC 0/2] arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

[PATCH RFC 0/2] arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

[Aaron Kling via B4 Relay]

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
Aaron Kling (2):
      dt-bindings: arm: tegra: Document Jetson Nano Devkits
      arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

 Documentation/devicetree/bindings/arm/tegra.yaml   |  5 +++
 arch/arm64/boot/dts/nvidia/Makefile                |  2 +
 arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts | 43 ++++++++++++++++++++++
 3 files changed, 50 insertions(+)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250513-p3452-059708ca9993

Best regards,
-- 
Aaron Kling <webgeek1234@gmail.com>

[PATCH RFC 1/2] dt-bindings: arm: tegra: Document Jetson Nano Devkits

[Aaron Kling via B4 Relay]

From: Aaron Kling <webgeek1234@gmail.com>

Add compatibles for the Tegra210 Jetson Nano Developer Kits

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 Documentation/devicetree/bindings/arm/tegra.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml
index 9cae3268a8274fd3a38580939c79a6f21de48a3f..d06d6474776ec679080aed62cab729af73ade53a 100644
--- a/Documentation/devicetree/bindings/arm/tegra.yaml
+++ b/Documentation/devicetree/bindings/arm/tegra.yaml
@@ -173,6 +173,11 @@ properties:
               - nvidia,p2371-2180
               - nvidia,p2571
               - nvidia,p2894-0050-a08
+              - nvidia,p3450-0000
+          - const: nvidia,tegra210
+      - items:
+          - const: nvidia,p3541-0000
+          - const: nvidia,p3450-0000
           - const: nvidia,tegra210
       - description: Jetson TX2 Developer Kit
         items:

-- 
2.49.0

[PATCH RFC 2/2] arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

[Aaron Kling via B4 Relay]

From: Aaron Kling <webgeek1234@gmail.com>

This devkit is very similar to P3450, except it has less ram, no display
port, and only 3 usb host ports. Derive from P3450 and disable the
hardware that is unavailable.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 arch/arm64/boot/dts/nvidia/Makefile                |  2 +
 arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts | 43 ++++++++++++++++++++++
 2 files changed, 45 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/Makefile b/arch/arm64/boot/dts/nvidia/Makefile
index 0fbb8a494dba5089d9b7243e766bd6028b7f3744..2989550e0d482e0dde09c1ff89930f7eb7b5b644 100644
--- a/arch/arm64/boot/dts/nvidia/Makefile
+++ b/arch/arm64/boot/dts/nvidia/Makefile
@@ -3,6 +3,7 @@
 # Enables support for device-tree overlays
 DTC_FLAGS_tegra210-p2371-2180 := -@
 DTC_FLAGS_tegra210-p3450-0000 := -@
+DTC_FLAGS_tegra210-p3541-0000 := -@
 DTC_FLAGS_tegra186-p2771-0000 := -@
 DTC_FLAGS_tegra186-p3509-0000+p3636-0001 := -@
 DTC_FLAGS_tegra194-p2972-0000 := -@
@@ -18,6 +19,7 @@ dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p3450-0000.dtb
+dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p3541-0000.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb
 dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2894-0050-a08.dtb
 dtb-$(CONFIG_ARCH_TEGRA_186_SOC) += tegra186-p2771-0000.dtb
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts b/arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts
new file mode 100644
index 0000000000000000000000000000000000000000..b86bd7f411088df1e48f4c2a61deaeae1f35d23e
--- /dev/null
+++ b/arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts
@@ -0,0 +1,43 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+
+#include "tegra210-p3450-0000.dts"
+
+/ {
+	model = "NVIDIA Jetson Nano 2GB Developer Kit";
+	compatible = "nvidia,p3541-0000", "nvidia,p3450-0000", "nvidia,tegra210";
+
+	memory@80000000 {
+		reg = <0x0 0x80000000 0x0 0x80000000>;
+	};
+
+	host1x@50000000 {
+		sor@54540000 {
+			status = "disabled";
+		};
+
+		dpaux@545c0000 {
+			status = "disabled";
+		};
+	};
+
+	padctl@7009f000 {
+		ports {
+			usb2-0 {
+				vbus-supply = <&vdd_5v0_sys>;
+			};
+
+			usb2-1 {
+				vbus-supply = <&vdd_5v0_usb>;
+			};
+
+			usb2-2 {
+				vbus-supply = <&vdd_5v0_usb>;
+			};
+
+			usb3-0 {
+				/delete-property/ vbus-supply;
+			};
+		};
+	};
+};

-- 
2.49.0

Re: [PATCH RFC 0/2] arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

[Aaron Kling]

On Sun, Jun 8, 2025 at 11:24 PM Aaron Kling via B4 Relay
<devnull+webgeek1234.gmail.com@kernel.org> wrote:
>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> Aaron Kling (2):
>       dt-bindings: arm: tegra: Document Jetson Nano Devkits
>       arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support
>
>  Documentation/devicetree/bindings/arm/tegra.yaml   |  5 +++
>  arch/arm64/boot/dts/nvidia/Makefile                |  2 +
>  arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts | 43 ++++++++++++++++++++++
>  3 files changed, 50 insertions(+)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250513-p3452-059708ca9993
>
> Best regards,
> --
> Aaron Kling <webgeek1234@gmail.com>

This is sent as an RFC, because it doesn't fully work. In my tests,
this boots and everything I can see works, except for hdmi. The
hotplug detect pin never changes, regardless of hdmi plug state. This
works as expected on the downstream 4.9 kernel. Based on the
downstream kernel dt for p3541, it's almost identical to p3540, and
I've mirrored those differences in this series. Things like the hpd
pin are the same. I'm failing to see why hpd would work on p3450, but
not on p3541, when using the same boot stack. Does anyone know why
this doesn't work?

Sincerely,
Aaron Kling

Re: [PATCH RFC 0/2] arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

[Rob Herring (Arm)]

On Sun, 08 Jun 2025 23:24:34 -0500, Aaron Kling wrote:
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> Aaron Kling (2):
>       dt-bindings: arm: tegra: Document Jetson Nano Devkits
>       arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support
> 
>  Documentation/devicetree/bindings/arm/tegra.yaml   |  5 +++
>  arch/arm64/boot/dts/nvidia/Makefile                |  2 +
>  arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts | 43 ++++++++++++++++++++++
>  3 files changed, 50 insertions(+)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250513-p3452-059708ca9993
> 
> Best regards,
> --
> Aaron Kling <webgeek1234@gmail.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/nvidia/' for 20250608-p3452-v1-0-4c2c1d7e4310@gmail.com:

arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /pcie@1003000: failed to match any schema with compatible: ['nvidia,tegra210-pcie']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /host1x@50000000/tsec@54100000: failed to match any schema with compatible: ['nvidia,tegra210-tsec']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /host1x@50000000/tsec@54500000: failed to match any schema with compatible: ['nvidia,tegra210-tsec']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /gpu@57000000: failed to match any schema with compatible: ['nvidia,gm20b']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /interrupt-controller@60004000: failed to match any schema with compatible: ['nvidia,tegra210-ictlr']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /dma@60020000: failed to match any schema with compatible: ['nvidia,tegra210-apbdma', 'nvidia,tegra148-apbdma']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /dma@60020000: failed to match any schema with compatible: ['nvidia,tegra210-apbdma', 'nvidia,tegra148-apbdma']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /i2c@7000d000/pmic@3c: failed to match any schema with compatible: ['maxim,max77620']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /memory-controller@70019000: failed to match any schema with compatible: ['nvidia,tegra210-mc']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: external-memory-controller@7001b000 (nvidia,tegra210-emc): '#cooling-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/memory-controllers/nvidia,tegra210-emc.yaml#
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /clock@70110000: failed to match any schema with compatible: ['nvidia,tegra210-dfll']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: usb-phy@7d000000 (nvidia,tegra210-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed:
	['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy'] is too long
	'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra124-usb-phy', 'nvidia,tegra114-usb-phy']
	'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra30-usb-phy', 'nvidia,tegra20-usb-phy']
	from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra20-usb-phy.yaml#
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /usb-phy@7d000000: failed to match any schema with compatible: ['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: usb-phy@7d004000 (nvidia,tegra210-usb-phy): compatible: 'oneOf' conditional failed, one must be fixed:
	['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy'] is too long
	'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra124-usb-phy', 'nvidia,tegra114-usb-phy']
	'nvidia,tegra210-usb-phy' is not one of ['nvidia,tegra30-usb-phy', 'nvidia,tegra20-usb-phy']
	from schema $id: http://devicetree.org/schemas/phy/nvidia,tegra20-usb-phy.yaml#
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: /usb-phy@7d004000: failed to match any schema with compatible: ['nvidia,tegra210-usb-phy', 'nvidia,tegra30-usb-phy']
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: cpu@0 (arm,cortex-a57): 'operating-points' is a dependency of 'clock-latency'
	from schema $id: http://devicetree.org/schemas/arm/cpus.yaml#
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: cpu@0 (arm,cortex-a57): Unevaluated properties are not allowed ('clock-latency' was unexpected)
	from schema $id: http://devicetree.org/schemas/arm/cpus.yaml#
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: thermal-zones: cpu-thermal:cooling-maps: 'cpu-active', 'cpu-critical', 'cpu-hot', 'cpu-passive' do not match any of the regexes: '^map[-a-zA-Z0-9]*$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dtb: thermal-zones: mem-thermal:cooling-maps: 'dram-active', 'dram-passive' do not match any of the regexes: '^map[-a-zA-Z0-9]*$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#

Re: [PATCH RFC 0/2] arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

On Sun, Jun 08, 2025 at 11:25:53PM -0500, Aaron Kling wrote:
> On Sun, Jun 8, 2025 at 11:24 PM Aaron Kling via B4 Relay
> <devnull+webgeek1234.gmail.com@kernel.org> wrote:
> >
> > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > ---
> > Aaron Kling (2):
> >       dt-bindings: arm: tegra: Document Jetson Nano Devkits
> >       arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support
> >
> >  Documentation/devicetree/bindings/arm/tegra.yaml   |  5 +++
> >  arch/arm64/boot/dts/nvidia/Makefile                |  2 +
> >  arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts | 43 ++++++++++++++++++++++
> >  3 files changed, 50 insertions(+)
> > ---
> > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > change-id: 20250513-p3452-059708ca9993
> >
> > Best regards,
> > --
> > Aaron Kling <webgeek1234@gmail.com>
> 
> This is sent as an RFC, because it doesn't fully work. In my tests,
> this boots and everything I can see works, except for hdmi. The
> hotplug detect pin never changes, regardless of hdmi plug state. This
> works as expected on the downstream 4.9 kernel. Based on the
> downstream kernel dt for p3541, it's almost identical to p3540, and
> I've mirrored those differences in this series. Things like the hpd
> pin are the same. I'm failing to see why hpd would work on p3450, but
> not on p3541, when using the same boot stack. Does anyone know why
> this doesn't work?

My recollection is that the HPD pin essentially loops back the +5V pin,
so that would be my prime suspect. Other than that I suppose it could be
a pinmux issue where HPD is muxed as something else.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH RFC 0/2] arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

[Aaron Kling]

On Tue, Jun 10, 2025 at 4:15 AM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Sun, Jun 08, 2025 at 11:25:53PM -0500, Aaron Kling wrote:
> > On Sun, Jun 8, 2025 at 11:24 PM Aaron Kling via B4 Relay
> > <devnull+webgeek1234.gmail.com@kernel.org> wrote:
> > >
> > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > > ---
> > > Aaron Kling (2):
> > >       dt-bindings: arm: tegra: Document Jetson Nano Devkits
> > >       arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support
> > >
> > >  Documentation/devicetree/bindings/arm/tegra.yaml   |  5 +++
> > >  arch/arm64/boot/dts/nvidia/Makefile                |  2 +
> > >  arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts | 43 ++++++++++++++++++++++
> > >  3 files changed, 50 insertions(+)
> > > ---
> > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > > change-id: 20250513-p3452-059708ca9993
> > >
> > > Best regards,
> > > --
> > > Aaron Kling <webgeek1234@gmail.com>
> >
> > This is sent as an RFC, because it doesn't fully work. In my tests,
> > this boots and everything I can see works, except for hdmi. The
> > hotplug detect pin never changes, regardless of hdmi plug state. This
> > works as expected on the downstream 4.9 kernel. Based on the
> > downstream kernel dt for p3541, it's almost identical to p3540, and
> > I've mirrored those differences in this series. Things like the hpd
> > pin are the same. I'm failing to see why hpd would work on p3450, but
> > not on p3541, when using the same boot stack. Does anyone know why
> > this doesn't work?
>
> My recollection is that the HPD pin essentially loops back the +5V pin,
> so that would be my prime suspect. Other than that I suppose it could be
> a pinmux issue where HPD is muxed as something else.

This got me looking at which regulators got removed from the power
tree in my changes and it looks like the 3v3 usb hub one is the
operable difference. If I do the following in the new p3541 dts, hpd
works. This supply is not used downstream in p3541 for usb and is
instead replaced with a 5v0 regulator tied to gpio pi2. While looking
into this, I see that I got the usb power tree mapping wrong in v1 and
am fixing for v2.

+       /* This supply is associated with hdmi hotplug and needs to remain on */
+       regulator-vdd-hub-3v3 {
+               regulator-always-on;
+       };

This seems like a kludge, though. The implication is that whatever
gpio pa6 is wired to for p3541 is related to hpd somehow. I'm not sure
if the rail / wiring is different from p3450. Seems like it would have
to be. Any thoughts on this, Thierry? Maybe a better way to map the
dependency?

Sincerely,
Aaron

Re: [PATCH RFC 0/2] arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 3688 bytes --]

On Tue, Jun 10, 2025 at 02:45:53PM -0500, Aaron Kling wrote:
> On Tue, Jun 10, 2025 at 4:15 AM Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > On Sun, Jun 08, 2025 at 11:25:53PM -0500, Aaron Kling wrote:
> > > On Sun, Jun 8, 2025 at 11:24 PM Aaron Kling via B4 Relay
> > > <devnull+webgeek1234.gmail.com@kernel.org> wrote:
> > > >
> > > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > > > ---
> > > > Aaron Kling (2):
> > > >       dt-bindings: arm: tegra: Document Jetson Nano Devkits
> > > >       arm64: tegra: Add NVIDIA Jetson Nano 2GB Developer Kit support
> > > >
> > > >  Documentation/devicetree/bindings/arm/tegra.yaml   |  5 +++
> > > >  arch/arm64/boot/dts/nvidia/Makefile                |  2 +
> > > >  arch/arm64/boot/dts/nvidia/tegra210-p3541-0000.dts | 43 ++++++++++++++++++++++
> > > >  3 files changed, 50 insertions(+)
> > > > ---
> > > > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > > > change-id: 20250513-p3452-059708ca9993
> > > >
> > > > Best regards,
> > > > --
> > > > Aaron Kling <webgeek1234@gmail.com>
> > >
> > > This is sent as an RFC, because it doesn't fully work. In my tests,
> > > this boots and everything I can see works, except for hdmi. The
> > > hotplug detect pin never changes, regardless of hdmi plug state. This
> > > works as expected on the downstream 4.9 kernel. Based on the
> > > downstream kernel dt for p3541, it's almost identical to p3540, and
> > > I've mirrored those differences in this series. Things like the hpd
> > > pin are the same. I'm failing to see why hpd would work on p3450, but
> > > not on p3541, when using the same boot stack. Does anyone know why
> > > this doesn't work?
> >
> > My recollection is that the HPD pin essentially loops back the +5V pin,
> > so that would be my prime suspect. Other than that I suppose it could be
> > a pinmux issue where HPD is muxed as something else.
> 
> This got me looking at which regulators got removed from the power
> tree in my changes and it looks like the 3v3 usb hub one is the
> operable difference. If I do the following in the new p3541 dts, hpd
> works. This supply is not used downstream in p3541 for usb and is
> instead replaced with a 5v0 regulator tied to gpio pi2. While looking
> into this, I see that I got the usb power tree mapping wrong in v1 and
> am fixing for v2.
> 
> +       /* This supply is associated with hdmi hotplug and needs to remain on */
> +       regulator-vdd-hub-3v3 {
> +               regulator-always-on;
> +       };
> 
> This seems like a kludge, though. The implication is that whatever
> gpio pa6 is wired to for p3541 is related to hpd somehow. I'm not sure
> if the rail / wiring is different from p3450. Seems like it would have
> to be. Any thoughts on this, Thierry? Maybe a better way to map the
> dependency?

Let me look at the board schematics: The +5V pin on the HDMI connector
is supplied by VDD_5V0_HDMI_CON, which in turn is the output of a switch
that is supplied aby VDD_5V_IN and controlled using VDD_3V3_HDMI. The
latter is supplied by VDD_3V3_SYS and controlled by MOD_SLEEP*.
VDD_3V3_SYS is supplied by VDD_5V_IN and controlled by SYS_RST*.

Looking at the module schematics, MOD_SLEEP is indeed mapped to GPIO
PA6.

Despite the ominous name, MOD_SLEEP seems to be used exclusively for
HDMI HPD and some LED control, so it sure sounds like that's the right
GPIO to use as enable pin in the HDMI supply. Maybe all you need to do
is use a phandle reference to that HDMI supply in the SOR node's
hdmi-supply property? That should make sure that the regulator gets
enabled when HDMI is in use.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]