From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: jonas.gorski@gmail.com, florian.fainelli@broadcom.com,
andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, vivien.didelot@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dgcbueu@gmail.com
Cc: "Álvaro Fernández Rojas" <noltari@gmail.com>
Subject: [PATCH net-next v4 00/14] net: dsa: b53: fix BCM5325 support
Date: Sat, 14 Jun 2025 09:59:46 +0200 [thread overview]
Message-ID: <20250614080000.1884236-1-noltari@gmail.com> (raw)
These patches get the BCM5325 switch working with b53.
The existing brcm legacy tag only works with BCM63xx switches.
We need to add a new legacy tag for BCM5325 and BCM5365 switches, which
require including the FCS and length.
I'm not really sure that everything here is correct since I don't work for
Broadcom and all this is based on the public datasheet available for the
BCM5325 and my own experiments with a Huawei HG556a (BCM6358).
Both sets of patches have been merged due to the change requested by Jonas
about BRCM_HDR register access depending on legacy tags.
v4: introduce changes requested by Jonas and other improvements:
- Fix line length warning.
- Introduce variant_id field in b53_device.
- Move B53_VLAN_ID_IDX BCM5325M check to variants patch.
- Reduce number of ARL buckets for BCM5325E.
- Disable ARLIO_PAGE->VLAN_ID_IDX access for BCM5325M.
- Avoid in_range() confusion.
- Ensure PD_MODE_POWER_DOWN_PORT(0) is cleared.
- Improve B53_PD_MODE_CTRL_25 register defines.
v3: introduce changes requested by Florian, Jonas and Jakub:
- Improve brcm legacy tag Kconfig description, use __le32 and crc32_le().
- Detect BCM5325 variants as requested by Florian.
- B53_VLAN_ID_IDX exists in newer BCM5325E switches.
- Check for legacy tag protocols instead of is5325() for B53_BRCM_HDR.
- Use in_range() helper for B53_PD_MODE_CTRL_25.
v2: introduce changes requested by Jonas, Florian and Vladimir:
- Add b53_arl_to_entry_25 function.
- Add b53_arl_from_entry_25 function.
- Add b53_arl_read_25 function, fixing usage of ARLTBL_VALID_25 and
ARLTBL_VID_MASK_25.
- Change b53_set_forwarding function flow.
- Disallow BR_LEARNING on b53_br_flags_pre() for BCM5325.
- Drop rate control registers.
- Move B53_PD_MODE_CTRL_25 to b53_setup_port().
- Replace swab32 with cpu_to_le32.
Florian Fainelli (1):
net: dsa: b53: add support for FDB operations on 5325/5365
Álvaro Fernández Rojas (13):
net: dsa: tag_brcm: legacy: reorganize functions
net: dsa: tag_brcm: add support for legacy FCS tags
net: dsa: b53: support legacy FCS tags
net: dsa: b53: detect BCM5325 variants
net: dsa: b53: prevent FAST_AGE access on BCM5325
net: dsa: b53: prevent SWITCH_CTRL access on BCM5325
net: dsa: b53: fix IP_MULTICAST_CTRL on BCM5325
net: dsa: b53: prevent DIS_LEARNING access on BCM5325
net: dsa: b53: prevent BRCM_HDR access on older devices
net: dsa: b53: prevent GMII_PORT_OVERRIDE_CTRL access on BCM5325
net: dsa: b53: fix unicast/multicast flooding on BCM5325
net: dsa: b53: fix b53_imp_vlan_setup for BCM5325
net: dsa: b53: ensure BCM5325 PHYs are enabled
drivers/net/dsa/b53/Kconfig | 1 +
drivers/net/dsa/b53/b53_common.c | 284 ++++++++++++++++++++++++-------
drivers/net/dsa/b53/b53_priv.h | 48 ++++++
drivers/net/dsa/b53/b53_regs.h | 27 ++-
include/net/dsa.h | 2 +
net/dsa/Kconfig | 16 +-
net/dsa/tag_brcm.c | 119 ++++++++++---
7 files changed, 408 insertions(+), 89 deletions(-)
--
2.39.5
next reply other threads:[~2025-06-14 8:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 7:59 Álvaro Fernández Rojas [this message]
2025-06-14 7:59 ` [PATCH net-next v4 01/14] net: dsa: tag_brcm: legacy: reorganize functions Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 02/14] net: dsa: tag_brcm: add support for legacy FCS tags Álvaro Fernández Rojas
2025-06-17 16:09 ` Florian Fainelli
2025-06-14 7:59 ` [PATCH net-next v4 03/14] net: dsa: b53: support " Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 04/14] net: dsa: b53: detect BCM5325 variants Álvaro Fernández Rojas
2025-06-17 16:10 ` Florian Fainelli
2025-06-14 7:59 ` [PATCH net-next v4 05/14] net: dsa: b53: add support for FDB operations on 5325/5365 Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 06/14] net: dsa: b53: prevent FAST_AGE access on BCM5325 Álvaro Fernández Rojas
2025-06-17 16:10 ` Florian Fainelli
2025-06-14 7:59 ` [PATCH net-next v4 07/14] net: dsa: b53: prevent SWITCH_CTRL " Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 08/14] net: dsa: b53: fix IP_MULTICAST_CTRL " Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 09/14] net: dsa: b53: prevent DIS_LEARNING access " Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 10/14] net: dsa: b53: prevent BRCM_HDR access on older devices Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 11/14] net: dsa: b53: prevent GMII_PORT_OVERRIDE_CTRL access on BCM5325 Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 12/14] net: dsa: b53: fix unicast/multicast flooding " Álvaro Fernández Rojas
2025-06-17 16:18 ` Florian Fainelli
2025-06-14 7:59 ` [PATCH net-next v4 13/14] net: dsa: b53: fix b53_imp_vlan_setup for BCM5325 Álvaro Fernández Rojas
2025-06-14 8:00 ` [PATCH net-next v4 14/14] net: dsa: b53: ensure BCM5325 PHYs are enabled Álvaro Fernández Rojas
2025-06-17 16:11 ` Florian Fainelli
2025-06-18 0:56 ` [PATCH net-next v4 00/14] net: dsa: b53: fix BCM5325 support Jakub Kicinski
2025-06-18 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250614080000.1884236-1-noltari@gmail.com \
--to=noltari@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dgcbueu@gmail.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®