From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: jonas.gorski@gmail.com, florian.fainelli@broadcom.com,
andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, vivien.didelot@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dgcbueu@gmail.com
Cc: "Álvaro Fernández Rojas" <noltari@gmail.com>
Subject: [PATCH net-next v4 10/14] net: dsa: b53: prevent BRCM_HDR access on older devices
Date: Sat, 14 Jun 2025 09:59:56 +0200 [thread overview]
Message-ID: <20250614080000.1884236-11-noltari@gmail.com> (raw)
In-Reply-To: <20250614080000.1884236-1-noltari@gmail.com>
Older switches don't implement BRCM_HDR register so we should avoid
reading or writing it.
Fixes: b409a9efa183 ("net: dsa: b53: Move Broadcom header setup to b53")
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
drivers/net/dsa/b53/b53_common.c | 5 +++++
1 file changed, 5 insertions(+)
v4: no changes
v3: add changes requested by Jonas:
- Check for legacy tag protocols instead of is5325().
v2: no changes
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index daf7c1906711..2bcbb003b1fd 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -730,6 +730,11 @@ void b53_brcm_hdr_setup(struct dsa_switch *ds, int port)
hdr_ctl |= GC_FRM_MGMT_PORT_M;
b53_write8(dev, B53_MGMT_PAGE, B53_GLOBAL_CONFIG, hdr_ctl);
+ /* B53_BRCM_HDR not present on devices with legacy tags */
+ if (dev->tag_protocol == DSA_TAG_PROTO_BRCM_LEGACY ||
+ dev->tag_protocol == DSA_TAG_PROTO_BRCM_LEGACY_FCS)
+ return;
+
/* Enable Broadcom tags for IMP port */
b53_read8(dev, B53_MGMT_PAGE, B53_BRCM_HDR, &hdr_ctl);
if (tag_en)
--
2.39.5
next prev parent reply other threads:[~2025-06-14 8:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 7:59 [PATCH net-next v4 00/14] net: dsa: b53: fix BCM5325 support Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 01/14] net: dsa: tag_brcm: legacy: reorganize functions Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 02/14] net: dsa: tag_brcm: add support for legacy FCS tags Álvaro Fernández Rojas
2025-06-17 16:09 ` Florian Fainelli
2025-06-14 7:59 ` [PATCH net-next v4 03/14] net: dsa: b53: support " Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 04/14] net: dsa: b53: detect BCM5325 variants Álvaro Fernández Rojas
2025-06-17 16:10 ` Florian Fainelli
2025-06-14 7:59 ` [PATCH net-next v4 05/14] net: dsa: b53: add support for FDB operations on 5325/5365 Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 06/14] net: dsa: b53: prevent FAST_AGE access on BCM5325 Álvaro Fernández Rojas
2025-06-17 16:10 ` Florian Fainelli
2025-06-14 7:59 ` [PATCH net-next v4 07/14] net: dsa: b53: prevent SWITCH_CTRL " Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 08/14] net: dsa: b53: fix IP_MULTICAST_CTRL " Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 09/14] net: dsa: b53: prevent DIS_LEARNING access " Álvaro Fernández Rojas
2025-06-14 7:59 ` Álvaro Fernández Rojas [this message]
2025-06-14 7:59 ` [PATCH net-next v4 11/14] net: dsa: b53: prevent GMII_PORT_OVERRIDE_CTRL " Álvaro Fernández Rojas
2025-06-14 7:59 ` [PATCH net-next v4 12/14] net: dsa: b53: fix unicast/multicast flooding " Álvaro Fernández Rojas
2025-06-17 16:18 ` Florian Fainelli
2025-06-14 7:59 ` [PATCH net-next v4 13/14] net: dsa: b53: fix b53_imp_vlan_setup for BCM5325 Álvaro Fernández Rojas
2025-06-14 8:00 ` [PATCH net-next v4 14/14] net: dsa: b53: ensure BCM5325 PHYs are enabled Álvaro Fernández Rojas
2025-06-17 16:11 ` Florian Fainelli
2025-06-18 0:56 ` [PATCH net-next v4 00/14] net: dsa: b53: fix BCM5325 support Jakub Kicinski
2025-06-18 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250614080000.1884236-11-noltari@gmail.com \
--to=noltari@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dgcbueu@gmail.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®