From: Sukrut Bellary <sbellary@baylibre.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Angelo Compagnucci" <angelo.compagnucci@gmail.com>
Cc: Sukrut Bellary <sbellary@baylibre.com>,
Nishanth Menon <nm@ti.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 3/5] iio: adc: ti-adc128s052: cleanup changes
Date: Sat, 14 Jun 2025 02:15:02 -0700 [thread overview]
Message-ID: <20250614091504.575685-4-sbellary@baylibre.com> (raw)
In-Reply-To: <20250614091504.575685-1-sbellary@baylibre.com>
Arrange device IDs in alphabetical and numerical order. new device ID addition
can follow the same convention. Also, arrange the structures in order.
This is a cosmetic change only, and the functionality remains unchanged.
Co-developed-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sukrut Bellary <sbellary@baylibre.com>
---
drivers/iio/adc/ti-adc128s052.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
index 2b206745e53d..fbf15c83c127 100644
--- a/drivers/iio/adc/ti-adc128s052.c
+++ b/drivers/iio/adc/ti-adc128s052.c
@@ -112,27 +112,27 @@ static int adc128_read_raw(struct iio_dev *indio_dev,
#define ADC128_VOLTAGE_CHANNEL(num) _ADC128_VOLTAGE_CHANNEL(num, 12)
-static const struct iio_chan_spec adc128s052_channels[] = {
+static const struct iio_chan_spec adc122s021_channels[] = {
ADC128_VOLTAGE_CHANNEL(0),
ADC128_VOLTAGE_CHANNEL(1),
- ADC128_VOLTAGE_CHANNEL(2),
- ADC128_VOLTAGE_CHANNEL(3),
- ADC128_VOLTAGE_CHANNEL(4),
- ADC128_VOLTAGE_CHANNEL(5),
- ADC128_VOLTAGE_CHANNEL(6),
- ADC128_VOLTAGE_CHANNEL(7),
};
-static const struct iio_chan_spec adc122s021_channels[] = {
+static const struct iio_chan_spec adc124s021_channels[] = {
ADC128_VOLTAGE_CHANNEL(0),
ADC128_VOLTAGE_CHANNEL(1),
+ ADC128_VOLTAGE_CHANNEL(2),
+ ADC128_VOLTAGE_CHANNEL(3),
};
-static const struct iio_chan_spec adc124s021_channels[] = {
+static const struct iio_chan_spec adc128s052_channels[] = {
ADC128_VOLTAGE_CHANNEL(0),
ADC128_VOLTAGE_CHANNEL(1),
ADC128_VOLTAGE_CHANNEL(2),
ADC128_VOLTAGE_CHANNEL(3),
+ ADC128_VOLTAGE_CHANNEL(4),
+ ADC128_VOLTAGE_CHANNEL(5),
+ ADC128_VOLTAGE_CHANNEL(6),
+ ADC128_VOLTAGE_CHANNEL(7),
};
static const char * const bd79104_regulators[] = { "iovdd" };
@@ -216,27 +216,27 @@ static int adc128_probe(struct spi_device *spi)
}
static const struct of_device_id adc128_of_match[] = {
- { .compatible = "ti,adc128s052", .data = &adc128s052_config },
+ { .compatible = "rohm,bd79104", .data = &bd79104_config },
{ .compatible = "ti,adc122s021", .data = &adc122s021_config },
{ .compatible = "ti,adc122s051", .data = &adc122s021_config },
{ .compatible = "ti,adc122s101", .data = &adc122s021_config },
{ .compatible = "ti,adc124s021", .data = &adc124s021_config },
{ .compatible = "ti,adc124s051", .data = &adc124s021_config },
{ .compatible = "ti,adc124s101", .data = &adc124s021_config },
- { .compatible = "rohm,bd79104", .data = &bd79104_config },
+ { .compatible = "ti,adc128s052", .data = &adc128s052_config },
{ }
};
MODULE_DEVICE_TABLE(of, adc128_of_match);
static const struct spi_device_id adc128_id[] = {
- { "adc128s052", (kernel_ulong_t)&adc128s052_config },
{ "adc122s021", (kernel_ulong_t)&adc122s021_config },
{ "adc122s051", (kernel_ulong_t)&adc122s021_config },
{ "adc122s101", (kernel_ulong_t)&adc122s021_config },
{ "adc124s021", (kernel_ulong_t)&adc124s021_config },
{ "adc124s051", (kernel_ulong_t)&adc124s021_config },
{ "adc124s101", (kernel_ulong_t)&adc124s021_config },
- { "bd79104", (kernel_ulong_t)&bd79104_config },
+ { "adc128s052", (kernel_ulong_t)&adc128s052_config },
+ { "bd79104", (kernel_ulong_t)&bd79104_config },
{ }
};
MODULE_DEVICE_TABLE(spi, adc128_id);
--
2.34.1
next prev parent reply other threads:[~2025-06-14 9:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 9:14 [PATCH v4 0/5] iio: adc: ti-adc128s052: Add support for adc102s051 Sukrut Bellary
2025-06-14 9:15 ` [PATCH v4 1/5] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family Sukrut Bellary
2025-06-16 7:19 ` Krzysztof Kozlowski
2025-06-28 19:34 ` Sukrut Bellary
2025-06-14 9:15 ` [PATCH v4 2/5] iio: adc: ti-adc128s052: Use shift and realbits Sukrut Bellary
2025-06-14 13:27 ` Jonathan Cameron
2025-06-28 20:01 ` Sukrut Bellary
2025-06-29 16:26 ` Jonathan Cameron
2025-06-30 1:10 ` Sukrut Bellary
2025-06-14 9:15 ` Sukrut Bellary [this message]
2025-06-16 5:56 ` [PATCH v4 3/5] iio: adc: ti-adc128s052: cleanup changes Matti Vaittinen
2025-06-14 9:15 ` [PATCH v4 4/5] iio: adc: ti-adc128s052: Add lower resolution devices support Sukrut Bellary
2025-06-14 18:45 ` Andy Shevchenko
2025-06-28 23:09 ` Sukrut Bellary
2025-06-28 23:30 ` David Lechner
2025-06-29 6:06 ` Andy Shevchenko
2025-06-30 1:02 ` Sukrut Bellary
2025-06-14 9:15 ` [PATCH v4 5/5] MAINTAINERS: maintainer for TI's ADCs' driver ti-adc128s052 Sukrut Bellary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250614091504.575685-4-sbellary@baylibre.com \
--to=sbellary@baylibre.com \
--cc=andy@kernel.org \
--cc=angelo.compagnucci@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nm@ti.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®