* [PATCH v1] ACPI: PM: Set .detach in acpi_general_pm_domain definition
@ 2025-06-16 18:20 Rafael J. Wysocki
2025-06-17 5:56 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2025-06-16 18:20 UTC (permalink / raw)
To: Linux PM
Cc: Linux ACPI, LKML, Mika Westerberg, Andy Shevchenko, Heikki Krogerus
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Instead of setting the .detach callback pointer for acpi_general_pm_domain
every time it is attached to a device, which is confusing, set it once
in the definition of acpi_general_pm_domain.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/device_pm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/acpi/device_pm.c
+++ b/drivers/acpi/device_pm.c
@@ -1362,6 +1362,8 @@
}
#endif /* CONFIG_PM_SLEEP */
+static void acpi_dev_pm_detach(struct device *dev, bool power_off);
+
static struct dev_pm_domain acpi_general_pm_domain = {
.ops = {
.runtime_suspend = acpi_subsys_runtime_suspend,
@@ -1382,6 +1384,7 @@
.restore_early = acpi_subsys_restore_early,
#endif
},
+ .detach = acpi_dev_pm_detach,
};
/**
@@ -1465,7 +1468,6 @@
acpi_device_wakeup_disable(adev);
}
- dev->pm_domain->detach = acpi_dev_pm_detach;
return 1;
}
EXPORT_SYMBOL_GPL(acpi_dev_pm_attach);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ACPI: PM: Set .detach in acpi_general_pm_domain definition
2025-06-16 18:20 [PATCH v1] ACPI: PM: Set .detach in acpi_general_pm_domain definition Rafael J. Wysocki
@ 2025-06-17 5:56 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2025-06-17 5:56 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux PM, Linux ACPI, LKML, Andy Shevchenko, Heikki Krogerus
On Mon, Jun 16, 2025 at 08:20:28PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Instead of setting the .detach callback pointer for acpi_general_pm_domain
> every time it is attached to a device, which is confusing, set it once
> in the definition of acpi_general_pm_domain.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-17 5:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-16 18:20 [PATCH v1] ACPI: PM: Set .detach in acpi_general_pm_domain definition Rafael J. Wysocki
2025-06-17 5:56 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®