* [PATCH][next] wifi: ath11k: Make read-only const array svc_id static const
@ 2025-06-19 8:20 Colin Ian King
2025-06-26 16:38 ` Vasanthakumar Thiagarajan
2025-06-26 23:15 ` Jeff Johnson
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2025-06-19 8:20 UTC (permalink / raw)
To: Jeff Johnson, linux-wireless, ath11k; +Cc: kernel-janitors, linux-kernel
Don't populate the read-only array svc_id on the stack at run time,
instead make it static const.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/ath/ath11k/htc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/htc.c b/drivers/net/wireless/ath/ath11k/htc.c
index 23054ab29a5e..4571d01cc33d 100644
--- a/drivers/net/wireless/ath/ath11k/htc.c
+++ b/drivers/net/wireless/ath/ath11k/htc.c
@@ -497,7 +497,7 @@ static u8 ath11k_htc_get_credit_allocation(struct ath11k_htc *htc,
static int ath11k_htc_setup_target_buffer_assignments(struct ath11k_htc *htc)
{
struct ath11k_htc_svc_tx_credits *serv_entry;
- u32 svc_id[] = {
+ static const u32 svc_id[] = {
ATH11K_HTC_SVC_ID_WMI_CONTROL,
ATH11K_HTC_SVC_ID_WMI_CONTROL_MAC1,
ATH11K_HTC_SVC_ID_WMI_CONTROL_MAC2,
--
2.49.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] wifi: ath11k: Make read-only const array svc_id static const
2025-06-19 8:20 [PATCH][next] wifi: ath11k: Make read-only const array svc_id static const Colin Ian King
@ 2025-06-26 16:38 ` Vasanthakumar Thiagarajan
2025-06-26 23:15 ` Jeff Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Vasanthakumar Thiagarajan @ 2025-06-26 16:38 UTC (permalink / raw)
To: Colin Ian King, Jeff Johnson, linux-wireless, ath11k
Cc: kernel-janitors, linux-kernel
On 6/19/2025 1:50 PM, Colin Ian King wrote:
> Don't populate the read-only array svc_id on the stack at run time,
> instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] wifi: ath11k: Make read-only const array svc_id static const
2025-06-19 8:20 [PATCH][next] wifi: ath11k: Make read-only const array svc_id static const Colin Ian King
2025-06-26 16:38 ` Vasanthakumar Thiagarajan
@ 2025-06-26 23:15 ` Jeff Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2025-06-26 23:15 UTC (permalink / raw)
To: Jeff Johnson, linux-wireless, ath11k, Colin Ian King
Cc: kernel-janitors, linux-kernel
On Thu, 19 Jun 2025 09:20:10 +0100, Colin Ian King wrote:
> Don't populate the read-only array svc_id on the stack at run time,
> instead make it static const.
>
>
Applied, thanks!
[1/1] wifi: ath11k: Make read-only const array svc_id static const
commit: d8f07889e920493845fd628407ff0debbe96fa09
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-26 23:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-19 8:20 [PATCH][next] wifi: ath11k: Make read-only const array svc_id static const Colin Ian King
2025-06-26 16:38 ` Vasanthakumar Thiagarajan
2025-06-26 23:15 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®