Re: [PATCH v11 2/4] rust: Split `AlwaysRefCounted` into two traits

[kernel test robot <lkp@intel.com>]

Hi Oliver,

kernel test robot noticed the following build errors:

[auto build test ERROR on e04c78d86a9699d136910cfc0bdcf01087e3267e]

url:    https://github.com/intel-lab-lkp/linux/commits/Oliver-Mangold/rust-types-Add-Ownable-Owned-types/20250618-203524
base:   e04c78d86a9699d136910cfc0bdcf01087e3267e
patch link:    https://lore.kernel.org/r/20250618-unique-ref-v11-2-49eadcdc0aa6%40pm.me
patch subject: [PATCH v11 2/4] rust: Split `AlwaysRefCounted` into two traits
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250619/202506191023.smOZ1Mpy-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
rustc: rustc 1.78.0 (9b00956e5 2024-04-29)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250619/202506191023.smOZ1Mpy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506191023.smOZ1Mpy-lkp@intel.com/

All errors (new ones prefixed by >>):

   PATH=/opt/cross/clang-18/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   INFO PATH=/opt/cross/rustc-1.78.0-bindgen-0.65.1/cargo/bin:/opt/cross/clang-18/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   /usr/bin/timeout -k 100 12h /usr/bin/make KCFLAGS= -Wno-error=return-type -Wreturn-type -funsigned-char -Wundef W=1 --keep-going LLVM=1 -j32 -C source O=/kbuild/obj/consumer/x86_64-rhel-9.4-rust ARCH=x86_64 SHELL=/bin/bash rustfmtcheck
   make: Entering directory '/kbuild/src/consumer'
   make[1]: Entering directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
>> Diff in rust/kernel/mm/mmput_async.rs at line 48:
        }
    }
    
   -
    // SAFETY: We do not implement `Ownable`, thus it is okay to can obtain an `ARef<MmWithUserAsync>`
    // from a `&MmWithUserAsync`.
    unsafe impl AlwaysRefCounted for MmWithUserAsync {}
>> Diff in rust/kernel/mm/mmput_async.rs at line 48:
        }
    }
    
   -
    // SAFETY: We do not implement `Ownable`, thus it is okay to can obtain an `ARef<MmWithUserAsync>`
    // from a `&MmWithUserAsync`.
    unsafe impl AlwaysRefCounted for MmWithUserAsync {}
>> Diff in rust/kernel/mm/mmput_async.rs at line 48:
        }
    }
    
   -
    // SAFETY: We do not implement `Ownable`, thus it is okay to can obtain an `ARef<MmWithUserAsync>`
    // from a `&MmWithUserAsync`.
    unsafe impl AlwaysRefCounted for MmWithUserAsync {}
   make[2]: *** [Makefile:1825: rustfmt] Error 123
   make[2]: Target 'rustfmtcheck' not remade because of errors.
   make[1]: Leaving directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
   make[1]: *** [Makefile:248: __sub-make] Error 2
   make[1]: Target 'rustfmtcheck' not remade because of errors.
   make: *** [Makefile:248: __sub-make] Error 2
   make: Target 'rustfmtcheck' not remade because of errors.
   make: Leaving directory '/kbuild/src/consumer'
--
>> error[E0277]: the trait bound `auxiliary::Device: types::RefCounted` is not satisfied
   --> rust/kernel/device.rs:329:56
   |
   329 |         impl ::core::convert::From<&$device<$src>> for $crate::types::ARef<$device> {
   |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `types::RefCounted` is not implemented for `auxiliary::Device`
   |
   ::: rust/kernel/auxiliary.rs:250:1
   |
   250 | kernel::impl_device_context_into_aref!(Device);
   | ---------------------------------------------- in this macro invocation
   |
   = help: the following other types implement trait `types::RefCounted`:
   block::mq::request::Request<T>
   cred::Credential
   device::Device
   fs::file::File
   fs::file::LocalFile
   mm::mmput_async::MmWithUserAsync
   mm::Mm
   mm::MmWithUser
   and 4 others
   note: required by a bound in `types::ARef`
   --> rust/kernel/types.rs:478:20
   |
   478 | pub struct ARef<T: RefCounted> {
   |                    ^^^^^^^^^^ required by this bound in `ARef`
   = note: this error originates in the macro `::kernel::__impl_device_context_into_aref` which comes from the expansion of the macro `kernel::impl_device_context_into_aref` (in Nightly builds, run with -Z macro-backtrace for more info)
--
>> error[E0277]: the trait bound `auxiliary::Device: types::RefCounted` is not satisfied
   --> rust/kernel/auxiliary.rs:253:48
   |
   253 | unsafe impl crate::types::AlwaysRefCounted for Device {
   |                                                ^^^^^^ the trait `types::RefCounted` is not implemented for `auxiliary::Device`
   |
   = help: the following other types implement trait `types::RefCounted`:
   block::mq::request::Request<T>
   cred::Credential
   device::Device
   fs::file::File
   fs::file::LocalFile
   mm::mmput_async::MmWithUserAsync
   mm::Mm
   mm::MmWithUser
   and 4 others
   note: required by a bound in `types::AlwaysRefCounted`
   --> rust/kernel/types.rs:466:36
   |
   466 | pub unsafe trait AlwaysRefCounted: RefCounted {}
   |                                    ^^^^^^^^^^ required by this bound in `AlwaysRefCounted`
--
>> error[E0277]: the trait bound `auxiliary::Device: types::RefCounted` is not satisfied
   --> rust/kernel/device.rs:330:45
   |
   330 |             fn from(dev: &$device<$src>) -> Self {
   |                                             ^^^^ the trait `types::RefCounted` is not implemented for `auxiliary::Device`
   |
   ::: rust/kernel/auxiliary.rs:250:1
   |
   250 | kernel::impl_device_context_into_aref!(Device);
   | ---------------------------------------------- in this macro invocation
   |
   = help: the following other types implement trait `types::RefCounted`:
   block::mq::request::Request<T>
   cred::Credential
   device::Device
   fs::file::File
   fs::file::LocalFile
   mm::mmput_async::MmWithUserAsync
   mm::Mm
   mm::MmWithUser
   and 4 others
   note: required by a bound in `types::ARef`
   --> rust/kernel/types.rs:478:20
   |
   478 | pub struct ARef<T: RefCounted> {
   |                    ^^^^^^^^^^ required by this bound in `ARef`
   = note: this error originates in the macro `::kernel::__impl_device_context_into_aref` which comes from the expansion of the macro `kernel::impl_device_context_into_aref` (in Nightly builds, run with -Z macro-backtrace for more info)
--
>> error[E0277]: the trait bound `auxiliary::Device: types::RefCounted` is not satisfied
   --> rust/kernel/device.rs:331:17
   |
   331 |                 (&**dev).into()
   |                 ^^^^^^^^^^^^^^^ the trait `types::RefCounted` is not implemented for `auxiliary::Device`
   |
   ::: rust/kernel/auxiliary.rs:250:1
   |
   250 | kernel::impl_device_context_into_aref!(Device);
   | ---------------------------------------------- in this macro invocation
   |
   = help: the following other types implement trait `types::RefCounted`:
   block::mq::request::Request<T>
   cred::Credential
   device::Device
   fs::file::File
   fs::file::LocalFile
   mm::mmput_async::MmWithUserAsync
   mm::Mm
   mm::MmWithUser
   and 4 others
   note: required by a bound in `types::ARef`
   --> rust/kernel/types.rs:478:20
   |
   478 | pub struct ARef<T: RefCounted> {
   |                    ^^^^^^^^^^ required by this bound in `ARef`
   = note: this error originates in the macro `::kernel::__impl_device_context_into_aref` which comes from the expansion of the macro `kernel::impl_device_context_into_aref` (in Nightly builds, run with -Z macro-backtrace for more info)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki