From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Willy Tarreau <w@1wt.eu>
Subject: [PATCH 4/4] tools/nolibc: add missing memchr() to string.h
Date: Fri, 20 Jun 2025 12:02:51 +0200 [thread overview]
Message-ID: <20250620100251.9877-5-w@1wt.eu> (raw)
In-Reply-To: <20250620100251.9877-1-w@1wt.eu>
Surprisingly we forgot to add this common one. It was added with a
per-arch guard allowing to later implement it in arch-specific asm
code like was done for a few other ones.
The test verifies that we don't search past the indicated length.
Signed-off-by: Willy Tarreau <w@1wt.eu>
---
tools/include/nolibc/string.h | 15 +++++++++++++++
tools/testing/selftests/nolibc/nolibc-test.c | 2 ++
2 files changed, 17 insertions(+)
diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h
index 163a17e7dd38b..4000926f44ac4 100644
--- a/tools/include/nolibc/string.h
+++ b/tools/include/nolibc/string.h
@@ -93,6 +93,21 @@ void *memset(void *dst, int b, size_t len)
}
#endif /* #ifndef NOLIBC_ARCH_HAS_MEMSET */
+#ifndef NOLIBC_ARCH_HAS_MEMCHR
+static __attribute__((unused))
+void *memchr(const void *s, int c, size_t len)
+{
+ char *p = (char *)s;
+
+ while (len--) {
+ if (*p == (char)c)
+ return p;
+ p++;
+ }
+ return NULL;
+}
+#endif /* #ifndef NOLIBC_ARCH_HAS_MEMCHR */
+
static __attribute__((unused))
char *strchr(const char *s, int c)
{
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index dbe13000fb1ac..d832566265296 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -1524,6 +1524,8 @@ int run_stdlib(int min, int max)
CASE_TEST(abs); EXPECT_EQ(1, abs(-10), 10); break;
CASE_TEST(abs_noop); EXPECT_EQ(1, abs(10), 10); break;
CASE_TEST(difftime); EXPECT_ZR(1, test_difftime()); break;
+ CASE_TEST(memchr_foobar6_o); EXPECT_STREQ(1, memchr("foobar", 'o', 6), "oobar"); break;
+ CASE_TEST(memchr_foobar3_b); EXPECT_STRZR(1, memchr("foobar", 'b', 3)); break;
case __LINE__:
return ret; /* must be last */
--
2.17.5
next prev parent reply other threads:[~2025-06-20 10:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 10:02 [PATCH 0/4] tools/nolibc: assorted fixes and small updates Willy Tarreau
2025-06-20 10:02 ` [PATCH 1/4] tools/nolibc: fix misleading help message regarding installation path Willy Tarreau
2025-06-20 10:02 ` [PATCH 2/4] tools/nolibc: add the more portable inttypes.h Willy Tarreau
2025-06-20 10:02 ` [PATCH 3/4] tools/nolibc: move FD_* definitions to sys/select.h Willy Tarreau
2025-06-21 8:21 ` Thomas Weißschuh
2025-06-22 7:19 ` Willy Tarreau
2025-06-22 19:58 ` Thomas Weißschuh
2025-06-23 2:56 ` Willy Tarreau
2025-06-29 8:46 ` Willy Tarreau
2025-06-29 8:53 ` Thomas Weißschuh
2025-06-29 9:25 ` Willy Tarreau
2025-06-29 9:37 ` Thomas Weißschuh
2025-06-29 9:40 ` Willy Tarreau
2025-06-29 15:10 ` Willy Tarreau
2025-06-29 15:54 ` Thomas Weißschuh
2025-06-29 16:08 ` Willy Tarreau
2025-06-29 16:14 ` Thomas Weißschuh
2025-06-29 16:19 ` Willy Tarreau
2025-06-29 16:27 ` Thomas Weißschuh
2025-06-29 17:56 ` Willy Tarreau
2025-06-20 10:02 ` Willy Tarreau [this message]
2025-06-21 8:27 ` [PATCH 4/4] tools/nolibc: add missing memchr() to string.h Thomas Weißschuh
2025-06-21 8:42 ` Willy Tarreau
2025-06-22 19:56 ` Thomas Weißschuh
2025-06-23 3:01 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620100251.9877-5-w@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®