From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Willy Tarreau <w@1wt.eu>
Cc: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] tools/nolibc: move FD_* definitions to sys/select.h
Date: Sun, 29 Jun 2025 18:14:01 +0200 [thread overview]
Message-ID: <2322d3a1-a5ff-40ec-ad7e-1580f85d95f4@t-8ch.de> (raw)
In-Reply-To: <20250629160823.GA2302@1wt.eu>
On 2025-06-29 18:08:23+0200, Willy Tarreau wrote:
> On Sun, Jun 29, 2025 at 05:54:02PM +0200, Thomas Weißschuh wrote:
> > I saw the same issue, but only because of the changes to types.h.
> > And these should not be necessary in the first place.
>
> You mean fd_set definition ? It's solely a matter of includes ordering
> in fact, since it depends on FD_SETSIZE.
No, I mean the '#include "sys/select.h"' in "types.h".
That breaks the dependency order, as it pulls in all kinds of other
stuff into the beginning of "types.h" which themselves depend on
definitions of "types.h".
> > The below works nicely for me:
>
> OK. Do you prefer that we take that one or just a stub ? I'm personally
> fine with both.
I prefer moving the code.
next prev parent reply other threads:[~2025-06-29 16:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 10:02 [PATCH 0/4] tools/nolibc: assorted fixes and small updates Willy Tarreau
2025-06-20 10:02 ` [PATCH 1/4] tools/nolibc: fix misleading help message regarding installation path Willy Tarreau
2025-06-20 10:02 ` [PATCH 2/4] tools/nolibc: add the more portable inttypes.h Willy Tarreau
2025-06-20 10:02 ` [PATCH 3/4] tools/nolibc: move FD_* definitions to sys/select.h Willy Tarreau
2025-06-21 8:21 ` Thomas Weißschuh
2025-06-22 7:19 ` Willy Tarreau
2025-06-22 19:58 ` Thomas Weißschuh
2025-06-23 2:56 ` Willy Tarreau
2025-06-29 8:46 ` Willy Tarreau
2025-06-29 8:53 ` Thomas Weißschuh
2025-06-29 9:25 ` Willy Tarreau
2025-06-29 9:37 ` Thomas Weißschuh
2025-06-29 9:40 ` Willy Tarreau
2025-06-29 15:10 ` Willy Tarreau
2025-06-29 15:54 ` Thomas Weißschuh
2025-06-29 16:08 ` Willy Tarreau
2025-06-29 16:14 ` Thomas Weißschuh [this message]
2025-06-29 16:19 ` Willy Tarreau
2025-06-29 16:27 ` Thomas Weißschuh
2025-06-29 17:56 ` Willy Tarreau
2025-06-20 10:02 ` [PATCH 4/4] tools/nolibc: add missing memchr() to string.h Willy Tarreau
2025-06-21 8:27 ` Thomas Weißschuh
2025-06-21 8:42 ` Willy Tarreau
2025-06-22 19:56 ` Thomas Weißschuh
2025-06-23 3:01 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2322d3a1-a5ff-40ec-ad7e-1580f85d95f4@t-8ch.de \
--to=linux@weissschuh.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®