* [PATCH v2] staging: media: atomisp: fix coding style in ia_css_output.host.c
@ 2025-06-21 14:32 LiangCheng Wang
2025-06-21 18:26 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: LiangCheng Wang @ 2025-06-21 14:32 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, LiangCheng Wang
Fix two checkpatch.pl ERRORs:
- Use tab instead of space for indentation
- Move trailing statement to next line after if statement
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
This patch fixes coding style violations detected by checkpatch.pl in the atomisp driver under staging.
- Use tabs instead of spaces for indentation
- Move trailing `if` statements to multiline format
This cleanup improves code readability and follows Linux kernel coding standards.
---
Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.
Link to v1: https://lore.kernel.org/r/20250621-bar-v1-1-5a3e7004462c@gmail.com
---
.../atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
index d09365e0c47104dbffbd455bfd649b9079f88c9c..044c7d3706f486ba7cae5941ac598044c831b6c2 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
@@ -74,7 +74,7 @@ int ia_css_output0_config(struct sh_css_isp_output_isp_config *to,
}
int ia_css_output1_config(struct sh_css_isp_output_isp_config *to,
- const struct ia_css_output1_configuration *from,
+ const struct ia_css_output1_configuration *from,
unsigned int size)
{
return ia_css_output_config(to, (const struct ia_css_output_configuration *)from, size);
@@ -127,7 +127,8 @@ ia_css_output_dump(
const struct sh_css_isp_output_params *output,
unsigned int level)
{
- if (!output) return;
+ if (!output)
+ return;
ia_css_debug_dtrace(level, "Horizontal Output Flip:\n");
ia_css_debug_dtrace(level, "\t%-32s = %d\n",
"enable", output->enable_hflip);
---
base-commit: 3f75bfff44be0646580fe4efda45d646f9c1693b
change-id: 20250621-bar-573b8b40fb80
Best regards,
--
LiangCheng Wang <zaq14760@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: fix coding style in ia_css_output.host.c
2025-06-21 14:32 [PATCH v2] staging: media: atomisp: fix coding style in ia_css_output.host.c LiangCheng Wang
@ 2025-06-21 18:26 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-06-21 18:26 UTC (permalink / raw)
To: LiangCheng Wang
Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-kernel,
linux-staging
On Sat, Jun 21, 2025 at 5:32 PM LiangCheng Wang <zaq14760@gmail.com> wrote:
>
> Fix two checkpatch.pl ERRORs:
> - Use tab instead of space for indentation
> - Move trailing statement to next line after if statement
...
> int ia_css_output1_config(struct sh_css_isp_output_isp_config *to,
And what about this big space between 'g' and '*'?
> - const struct ia_css_output1_configuration *from,
> + const struct ia_css_output1_configuration *from,
> unsigned int size)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-21 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-21 14:32 [PATCH v2] staging: media: atomisp: fix coding style in ia_css_output.host.c LiangCheng Wang
2025-06-21 18:26 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®