Re: [PATCH] vfio/pci: print vfio-device name to fdinfo

[Alex Mastro <amastro@fb.com>]

Hi Alex, thanks for the prompt feedback.

On Mon, 23 Jun 2025 16:18:31 -0600 Alex Williamson <alex.williamson@redhat.com> wrote:
> TBH, I don't think we need a callback, just use dev_name() in
> vfio_main.  The group interface always requires the name, in some cases
> it can require further information, but we seem to have forgotten that
> in the cdev interface anyway :-\

Sounds good -- I'll follow up on this in v2.

> > +#include <linux/seq_file.h>
> 
> Only where we're doing the seq_print do we need to include this.

Ah, I only added it due to the direct reference to `struct seq_file *` in this
file, but will keep this in mind. I do see that it's transitively visible via
vfio.h's include.

> I think you're missing an update to Documentation/filesystems/proc.rst
> as well.

TIL about this documentation (section 3.8), but it looks to be focused more on
common fs/* pieces like eventfd, signalfd, and such. I didn't see any drivers/*
precedence, but would not be opposed to being the first. Do you think it still
makes sense to add there?

Thanks,
Alex