From: Jason Gunthorpe <jgg@ziepe.ca>
To: Alex Mastro <amastro@fb.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
peterx@redhat.com, kbusch@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/pci: print vfio-device name to fdinfo
Date: Tue, 24 Jun 2025 15:58:25 -0300 [thread overview]
Message-ID: <20250624185825.GA213144@ziepe.ca> (raw)
In-Reply-To: <20250624185327.1250843-1-amastro@fb.com>
On Tue, Jun 24, 2025 at 11:53:25AM -0700, Alex Mastro wrote:
> On Tue, 24 Jun 2025 15:16:16 -0300 Jason Gunthorpe <jgg@ziepe.ca> wrote:
> > There will be a symlink under /sys/class/vfio-xx/XX pointing to the
> > <pci sysfs path>/vfio-dev/X directory
> >
> > And another symlink under /sys/dev/char/XX:XX doing the same.
>
> Got it, thanks. The issue does seem solved for the vfio cdev case, then.
I wonder if we could arrange things so that if the cdev path is turned
on then the device FD created by the ioctl would report the same
/dev/vfio/X information? I've never looked at how this works, but
maybe it is easy?
Even if userspace is not using the cdev it does exist and is still
logically affiliated with the ioctl FD.
Then we'd have a nice consistent user experience.
Jason
prev parent reply other threads:[~2025-06-24 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 21:02 Alex Mastro
2025-06-23 21:50 ` Keith Busch
2025-06-23 22:18 ` Alex Williamson
2025-06-23 23:14 ` Alex Mastro
2025-06-24 0:56 ` Jason Gunthorpe
2025-06-24 16:23 ` Alex Williamson
2025-06-24 18:12 ` Jason Gunthorpe
2025-06-24 16:35 ` Alex Mastro
2025-06-24 18:16 ` Jason Gunthorpe
2025-06-24 18:53 ` Alex Mastro
2025-06-24 18:58 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624185825.GA213144@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=amastro@fb.com \
--cc=kbusch@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®