From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: git@apitzsch.eu
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Ricardo Ribalda <ribalda@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] media: i2c: imx214: Remove unneeded parentheses
Date: Sun, 29 Jun 2025 19:56:44 +0300 [thread overview]
Message-ID: <20250629165644.GI24912@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20250629-imx214_fixes-v1-1-873eb94ad635@apitzsch.eu>
On Sun, Jun 29, 2025 at 04:49:20PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@apitzsch.eu>
>
> The parentheses are not needed to calculate bit_rate_mbps.
>
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx214.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index a0cef9e61b41be8ea76a6d6e4b8c9fc4060cfa0f..8e9b5c9c93b0888f3d6be857168711edaf050db3 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -1029,8 +1029,8 @@ static int imx214_start_streaming(struct imx214 *imx214)
> return ret;
> }
>
> - bit_rate_mbps = (imx214->pll.pixel_rate_csi / 1000000)
> - * imx214->pll.bits_per_pixel;
> + bit_rate_mbps = imx214->pll.pixel_rate_csi / 1000000
> + * imx214->pll.bits_per_pixel;
> ret = cci_write(imx214->regmap, IMX214_REG_REQ_LINK_BIT_RATE,
> IMX214_LINK_BIT_RATE_MBPS(bit_rate_mbps), NULL);
> if (ret) {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2025-06-29 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 14:49 [PATCH 0/5] media: i2c: imx214: Add some style improvements André Apitzsch via B4 Relay
2025-06-29 14:49 ` [PATCH 1/5] media: i2c: imx214: Remove unneeded parentheses André Apitzsch via B4 Relay
2025-06-29 16:56 ` Laurent Pinchart [this message]
2025-06-29 14:49 ` [PATCH 2/5] media: i2c: imx214: Drop dev argument from imx214_parse_fwnode() André Apitzsch via B4 Relay
2025-06-29 16:57 ` Laurent Pinchart
2025-06-29 14:49 ` [PATCH 3/5] media: i2c: imx214: Use __free(fwnode_handle) André Apitzsch via B4 Relay
2025-06-29 17:16 ` Laurent Pinchart
2025-06-29 14:49 ` [PATCH 4/5] media: i2c: imx214: Move imx214_pll_update to imx214_ctrls_init André Apitzsch via B4 Relay
2025-06-29 17:18 ` Laurent Pinchart
2025-06-29 14:49 ` [PATCH 5/5] media: i2c: imx214: Separat legacy link frequency check from PLL calculation André Apitzsch via B4 Relay
2025-06-29 17:05 ` Markus Elfring
2025-06-29 17:20 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250629165644.GI24912@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=git@apitzsch.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=ribalda@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®