mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: git@apitzsch.eu
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Ricardo Ribalda <ribalda@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] media: i2c: imx214: Drop dev argument from imx214_parse_fwnode()
Date: Sun, 29 Jun 2025 19:57:12 +0300	[thread overview]
Message-ID: <20250629165712.GJ24912@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20250629-imx214_fixes-v1-2-873eb94ad635@apitzsch.eu>

On Sun, Jun 29, 2025 at 04:49:21PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@apitzsch.eu>
> 
> The device can be accessed from struct imx214.
> 
> Signed-off-by: André Apitzsch <git@apitzsch.eu>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/imx214.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 8e9b5c9c93b0888f3d6be857168711edaf050db3..d9193bafa3cbb8fec2679200c38d30077d1b11bd 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -1324,10 +1324,11 @@ static int imx214_identify_module(struct imx214 *imx214)
>  	return 0;
>  }
>  
> -static int imx214_parse_fwnode(struct device *dev, struct imx214 *imx214)
> +static int imx214_parse_fwnode(struct imx214 *imx214)
>  {
>  	struct v4l2_fwnode_endpoint *bus_cfg = &imx214->bus_cfg;
>  	struct fwnode_handle *endpoint;
> +	struct device *dev = imx214->dev;
>  	unsigned int i;
>  	int ret;
>  
> @@ -1415,7 +1416,7 @@ static int imx214_probe(struct i2c_client *client)
>  		return dev_err_probe(dev, PTR_ERR(imx214->regmap),
>  				     "failed to initialize CCI\n");
>  
> -	ret = imx214_parse_fwnode(dev, imx214);
> +	ret = imx214_parse_fwnode(imx214);
>  	if (ret)
>  		return ret;
>  

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2025-06-29 16:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-29 14:49 [PATCH 0/5] media: i2c: imx214: Add some style improvements André Apitzsch via B4 Relay
2025-06-29 14:49 ` [PATCH 1/5] media: i2c: imx214: Remove unneeded parentheses André Apitzsch via B4 Relay
2025-06-29 16:56   ` Laurent Pinchart
2025-06-29 14:49 ` [PATCH 2/5] media: i2c: imx214: Drop dev argument from imx214_parse_fwnode() André Apitzsch via B4 Relay
2025-06-29 16:57   ` Laurent Pinchart [this message]
2025-06-29 14:49 ` [PATCH 3/5] media: i2c: imx214: Use __free(fwnode_handle) André Apitzsch via B4 Relay
2025-06-29 17:16   ` Laurent Pinchart
2025-06-29 14:49 ` [PATCH 4/5] media: i2c: imx214: Move imx214_pll_update to imx214_ctrls_init André Apitzsch via B4 Relay
2025-06-29 17:18   ` Laurent Pinchart
2025-06-29 14:49 ` [PATCH 5/5] media: i2c: imx214: Separat legacy link frequency check from PLL calculation André Apitzsch via B4 Relay
2025-06-29 17:05   ` Markus Elfring
2025-06-29 17:20   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250629165712.GJ24912@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=git@apitzsch.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=ribalda@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®