* [PATCH RESEND] nvme: Fix incorrect cdw15 value in passthru error logging
@ 2025-06-28 18:12 Alok Tiwari
2025-06-30 6:34 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Alok Tiwari @ 2025-06-28 18:12 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi, martin.petersen, linux-nvme
Cc: alok.a.tiwari, linux-kernel, darren.kenny
Fix an error in nvme_log_err_passthru() where cdw14 was incorrectly
printed twice instead of cdw15. This fix ensures accurate logging of
the full passthrough command payload.
Fixes: 9f079dda1433 ("nvme: allow passthru cmd error logging")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
Corrected Christoph Hellwig's email ID
added Reviewed-by Martin K. Petersen
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index e533d791955d..2ae36bce615e 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -386,7 +386,7 @@ static void nvme_log_err_passthru(struct request *req)
nr->cmd->common.cdw12,
nr->cmd->common.cdw13,
nr->cmd->common.cdw14,
- nr->cmd->common.cdw14);
+ nr->cmd->common.cdw15);
}
enum nvme_disposition {
--
2.47.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] nvme: Fix incorrect cdw15 value in passthru error logging
2025-06-28 18:12 [PATCH RESEND] nvme: Fix incorrect cdw15 value in passthru error logging Alok Tiwari
@ 2025-06-30 6:34 ` Christoph Hellwig
2025-06-30 6:35 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2025-06-30 6:34 UTC (permalink / raw)
To: Alok Tiwari
Cc: kbusch, axboe, hch, sagi, martin.petersen, linux-nvme,
linux-kernel, darren.kenny
Thanks,
applied to nvme-6.16.
I fixed up the commit message to include a Fixes tag and drop the
mailing list reference.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] nvme: Fix incorrect cdw15 value in passthru error logging
2025-06-30 6:34 ` Christoph Hellwig
@ 2025-06-30 6:35 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2025-06-30 6:35 UTC (permalink / raw)
To: Alok Tiwari
Cc: kbusch, axboe, hch, sagi, martin.petersen, linux-nvme,
linux-kernel, darren.kenny
On Mon, Jun 30, 2025 at 08:34:30AM +0200, Christoph Hellwig wrote:
> I fixed up the commit message to include a Fixes tag and drop the
> mailing list reference.
Please ignore this, it was meant for another patch I applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-30 6:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-28 18:12 [PATCH RESEND] nvme: Fix incorrect cdw15 value in passthru error logging Alok Tiwari
2025-06-30 6:34 ` Christoph Hellwig
2025-06-30 6:35 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®