From: Devarsh Thakkar <devarsht@ti.com>
To: <vkoul@kernel.org>, <kishon@kernel.org>,
<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <aradhya.bhatia@linux.dev>, <s-jain1@ti.com>, <r-donadkar@ti.com>,
<tomi.valkeinen@ideasonboard.com>, <j-choudhary@ti.com>,
<a0512644@ti.com>, <devarsht@ti.com>
Subject: [PATCH v4 0/2] Fix PLL lock timeout and calibration wait time
Date: Fri, 4 Jul 2025 18:29:13 +0530 [thread overview]
Message-ID: <20250704125915.1224738-1-devarsht@ti.com> (raw)
This fixes PLL lockup and O_CMN_READY timeout by moving the polling
function after common state machine gets enabled. Also fix the
calibration wait time to optimize the polling time.
NOTE: This needs to be applied on top of
https://lore.kernel.org/all/20250618-cdns-dsi-impro-v4-4-862c841dbe02@ideasonboard.com/
https://lore.kernel.org/all/20250618-cdns-dsi-impro-v4-5-862c841dbe02@ideasonboard.com/
from the series:
https://lore.kernel.org/all/20250618-cdns-dsi-impro-v4-0-862c841dbe02@ideasonboard.com/
Changelog:
V4:
- Optimize wait_for_pll_lock, wait_for_cmn_ready calls to oneline
using conditional operator
- Remove superflous init for ret variable in cdns_dphy_configure
- Enable pll and psm ref clocks before configuring PLL
- Update commit message to refer to TRM
- Rebased on top of:
https://lore.kernel.org/all/20250618-cdns-dsi-impro-v4-4-862c841dbe02@ideasonboard.com/
https://lore.kernel.org/all/20250618-cdns-dsi-impro-v4-5-862c841dbe02@ideasonboard.com/
from the series:
https://lore.kernel.org/all/20250618-cdns-dsi-impro-v4-0-862c841dbe02@ideasonboard.com/
V3:
- Use read-modify-write for using calibrated value for PLL
lock time
- Move out PLL clock configuration part to power_on function
V2: Separate patch for calibration logic and
return error code on polling
Previous versions:
V3: https://lore.kernel.org/all/20250502033451.2291330-1-devarsht@ti.com/
V2: https://lore.kernel.org/all/20250326152320.3835249-1-devarsht@ti.com/
V1: https://lore.kernel.org/all/20241230125319.941372-1-devarsht@ti.com/
Test logs:
Link: https://gist.github.com/devarsht/d08d851399ca327e5594266a8d66d478
Rangediff:
V3->V4:
https://gist.github.com/devarsht/e4db52e1f4aec2d45596b3ed019e92ef
V2->V3:
https://gist.github.com/devarsht/c4d2c4f6715ec7aa4df4cb2c7991b7aa
Devarsh Thakkar (2):
phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY polling
phy: cadence: cdns-dphy: Update calibration wait time for startup
state machine
drivers/phy/cadence/cdns-dphy.c | 126 ++++++++++++++++++++++++--------
1 file changed, 94 insertions(+), 32 deletions(-)
--
2.39.1
next reply other threads:[~2025-07-04 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 12:59 Devarsh Thakkar [this message]
2025-07-04 12:59 ` [PATCH v4 1/2] phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY polling Devarsh Thakkar
2025-07-05 3:02 ` kernel test robot
2025-07-10 11:35 ` Devarsh Thakkar
2025-07-11 11:14 ` Harikrishna Shenoy
2025-07-04 12:59 ` [PATCH v4 2/2] phy: cadence: cdns-dphy: Update calibration wait time for startup state machine Devarsh Thakkar
2025-07-11 8:12 ` Harikrishna Shenoy
2025-07-23 8:06 ` Tomi Valkeinen
2025-07-23 12:41 ` Devarsh Thakkar
2025-07-23 9:37 ` [PATCH v4 0/2] Fix PLL lock timeout and calibration wait time Tomi Valkeinen
2025-09-10 16:47 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704125915.1224738-1-devarsht@ti.com \
--to=devarsht@ti.com \
--cc=a0512644@ti.com \
--cc=aradhya.bhatia@linux.dev \
--cc=j-choudhary@ti.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=r-donadkar@ti.com \
--cc=s-jain1@ti.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®