From: Devarsh Thakkar <devarsht@ti.com>
To: <vkoul@kernel.org>, <kishon@kernel.org>,
<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <aradhya.bhatia@linux.dev>, <s-jain1@ti.com>, <r-donadkar@ti.com>,
<tomi.valkeinen@ideasonboard.com>, <j-choudhary@ti.com>,
<a0512644@ti.com>, <devarsht@ti.com>
Subject: [PATCH v4 2/2] phy: cadence: cdns-dphy: Update calibration wait time for startup state machine
Date: Fri, 4 Jul 2025 18:29:15 +0530 [thread overview]
Message-ID: <20250704125915.1224738-3-devarsht@ti.com> (raw)
In-Reply-To: <20250704125915.1224738-1-devarsht@ti.com>
Do read-modify-write so that we re-use the characterized reset value as
specified in TRM [1] to program calibration wait time which defines number
of cycles to wait for after startup state machine is in bandgap enable
state.
This fixes PLL lock timeout error faced while using RPi DSI Panel on TI's
AM62L and J721E SoC since earlier calibration wait time was getting
overwritten to zero value thus failing the PLL to lockup and causing
timeout.
[1] AM62P TRM (Section 14.8.6.3.2.1.1 DPHY_TX_DPHYTX_CMN0_CMN_DIG_TBIT2):
Link: https://www.ti.com/lit/pdf/spruj83
Cc: stable@vger.kernel.org
Fixes: 7a343c8bf4b5 ("phy: Add Cadence D-PHY support")
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
V4: No change
V3:
- Do read-modify-write to preserve reset value for calibration wait
time
V2:
Introduced this as as separate patch
drivers/phy/cadence/cdns-dphy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dphy.c
index da8de0a9d086..24a25606996c 100644
--- a/drivers/phy/cadence/cdns-dphy.c
+++ b/drivers/phy/cadence/cdns-dphy.c
@@ -30,6 +30,7 @@
#define DPHY_CMN_SSM DPHY_PMA_CMN(0x20)
#define DPHY_CMN_SSM_EN BIT(0)
+#define DPHY_CMN_SSM_CAL_WAIT_TIME GENMASK(8, 1)
#define DPHY_CMN_TX_MODE_EN BIT(9)
#define DPHY_CMN_PWM DPHY_PMA_CMN(0x40)
@@ -410,7 +411,8 @@ static int cdns_dphy_power_on(struct phy *phy)
writel(reg, dphy->regs + DPHY_BAND_CFG);
/* Start TX state machine. */
- writel(DPHY_CMN_SSM_EN | DPHY_CMN_TX_MODE_EN,
+ reg = readl(dphy->regs + DPHY_CMN_SSM);
+ writel((reg & DPHY_CMN_SSM_CAL_WAIT_TIME) | DPHY_CMN_SSM_EN | DPHY_CMN_TX_MODE_EN,
dphy->regs + DPHY_CMN_SSM);
ret = cdns_dphy_wait_for_pll_lock(dphy);
--
2.39.1
next prev parent reply other threads:[~2025-07-04 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 12:59 [PATCH v4 0/2] Fix PLL lock timeout and calibration wait time Devarsh Thakkar
2025-07-04 12:59 ` [PATCH v4 1/2] phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY polling Devarsh Thakkar
2025-07-05 3:02 ` kernel test robot
2025-07-10 11:35 ` Devarsh Thakkar
2025-07-11 11:14 ` Harikrishna Shenoy
2025-07-04 12:59 ` Devarsh Thakkar [this message]
2025-07-11 8:12 ` [PATCH v4 2/2] phy: cadence: cdns-dphy: Update calibration wait time for startup state machine Harikrishna Shenoy
2025-07-23 8:06 ` Tomi Valkeinen
2025-07-23 12:41 ` Devarsh Thakkar
2025-07-23 9:37 ` [PATCH v4 0/2] Fix PLL lock timeout and calibration wait time Tomi Valkeinen
2025-09-10 16:47 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704125915.1224738-3-devarsht@ti.com \
--to=devarsht@ti.com \
--cc=a0512644@ti.com \
--cc=aradhya.bhatia@linux.dev \
--cc=j-choudhary@ti.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=r-donadkar@ti.com \
--cc=s-jain1@ti.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®