[PATCH] pinctrl: samsung: Fix gs101 irq chip

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH] pinctrl: samsung: Fix gs101 irq chip
@ 2025-07-02 12:15 Peter Griffin
  2025-07-02 12:47 ` André Draszik
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Peter Griffin @ 2025-07-02 12:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Sylwester Nawrocki, Alim Akhtar, Linus Walleij
  Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc,
	linux-gpio, linux-kernel, André Draszik, Peter Griffin

When adding the dedicated gs101_wkup_irq_chip struct to support the eint
wakeup mask the .eint_con, eint_mask and .eint_pend fields were missed. The
result is that irqs on gs101 for the buttons etc are broken.

Reported-by: André Draszik <andre.draszik@linaro.org>
Fixes: 2642f55d44ce ("pinctrl: samsung: add support for gs101 wakeup mask programming")
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
Note: no Closes tag as issue was reported on private chat. Permission has
been obtained for using the Reported-by tag.
---
 drivers/pinctrl/samsung/pinctrl-exynos.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index 5554768d465fe0d8bf6e423b2e835965cde5d8f5..81fe0b08a9af5682421e5a5533a6cb4c9561cd24 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -665,6 +665,9 @@ static const struct exynos_irq_chip gs101_wkup_irq_chip __initconst = {
 		.irq_request_resources = exynos_irq_request_resources,
 		.irq_release_resources = exynos_irq_release_resources,
 	},
+	.eint_con = EXYNOS7_WKUP_ECON_OFFSET,
+	.eint_mask = EXYNOS7_WKUP_EMASK_OFFSET,
+	.eint_pend = EXYNOS7_WKUP_EPEND_OFFSET,
 	.eint_num_wakeup_reg = 3,
 	.eint_wake_mask_reg = GS101_EINT_WAKEUP_MASK,
 	.set_eint_wakeup_mask = gs101_pinctrl_set_eint_wakeup_mask,

---
base-commit: 2aeda9592360c200085898a258c4754bfe879921
change-id: 20250702-fix-gs101-irqchip-8d12d369440c

Best regards,
-- 
Peter Griffin <peter.griffin@linaro.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pinctrl: samsung: Fix gs101 irq chip
  2025-07-02 12:15 [PATCH] pinctrl: samsung: Fix gs101 irq chip Peter Griffin
@ 2025-07-02 12:47 ` André Draszik
  2025-07-05  5:07 ` kernel test robot
  2025-07-05  8:52 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: André Draszik @ 2025-07-02 12:47 UTC (permalink / raw)
  To: Peter Griffin, Krzysztof Kozlowski, Sylwester Nawrocki,
	Alim Akhtar, Linus Walleij
  Cc: Krzysztof Kozlowski, linux-arm-kernel, linux-samsung-soc,
	linux-gpio, linux-kernel

On Wed, 2025-07-02 at 13:15 +0100, Peter Griffin wrote:
> When adding the dedicated gs101_wkup_irq_chip struct to support the eint
> wakeup mask the .eint_con, eint_mask and .eint_pend fields were missed. The
> result is that irqs on gs101 for the buttons etc are broken.
> 
> Reported-by: André Draszik <andre.draszik@linaro.org>
> Fixes: 2642f55d44ce ("pinctrl: samsung: add support for gs101 wakeup mask programming")
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> Note: no Closes tag as issue was reported on private chat. Permission has
> been obtained for using the Reported-by tag.

Tested-by: André Draszik <andre.draszik@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pinctrl: samsung: Fix gs101 irq chip
  2025-07-02 12:15 [PATCH] pinctrl: samsung: Fix gs101 irq chip Peter Griffin
  2025-07-02 12:47 ` André Draszik
@ 2025-07-05  5:07 ` kernel test robot
  2025-07-05  8:52 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-07-05  5:07 UTC (permalink / raw)
  To: Peter Griffin, Krzysztof Kozlowski, Sylwester Nawrocki,
	Alim Akhtar, Linus Walleij
  Cc: llvm, oe-kbuild-all, linux-arm-kernel, linux-samsung-soc,
	linux-gpio, linux-kernel, André Draszik, Peter Griffin

Hi Peter,

kernel test robot noticed the following build errors:

[auto build test ERROR on 2aeda9592360c200085898a258c4754bfe879921]

url:    https://github.com/intel-lab-lkp/linux/commits/Peter-Griffin/pinctrl-samsung-Fix-gs101-irq-chip/20250702-201914
base:   2aeda9592360c200085898a258c4754bfe879921
patch link:    https://lore.kernel.org/r/20250702-fix-gs101-irqchip-v1-1-ccc84b44ad72%40linaro.org
patch subject: [PATCH] pinctrl: samsung: Fix gs101 irq chip
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20250705/202507051248.6qkGauvn-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250705/202507051248.6qkGauvn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507051248.6qkGauvn-lkp@intel.com/

All errors (new ones prefixed by >>):

   include/linux/lockdep.h:279:7: note: expanded from macro 'lockdep_assert'
     279 |         do { WARN_ON(debug_locks && !(cond)); } while (0)
         |              ^
   include/asm-generic/bug.h:132:3: note: expanded from macro 'WARN_ON'
     132 |                 __WARN();                                               \
         |                 ^
   note: (skipping 3 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
      10 | #define __stringify(x...)       __stringify_1(x)
         |                                 ^
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
       9 | #define __stringify_1(x...)     #x
         |                                 ^
   <scratch space>:15:1: note: expanded from here
      15 | ".pushsection __bug_table, \"aw\"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, \"aMS\", @progbits, 1; 10002: .string \"\" \"drivers/net/wireless/realtek/rtw88/hci.h\"; .popsection; .long 10002b - .; .short 197; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;"
         | ^
   <inline asm>:1:134: note: instantiated into assembly here
       1 |         .pushsection __bug_table, "aw"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, "aMS", @progbits, 1; 10002: .string "" "drivers/net/wireless/realtek/rtw88/hci.h"; .popsection; .long 10002b - .; .short 197; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;
         |                                                                                                                                             ^
   In file included from drivers/net/wireless/realtek/rtw88/rtw8822c.c:6:
   In file included from drivers/net/wireless/realtek/rtw88/main.h:2136:
   drivers/net/wireless/realtek/rtw88/hci.h:197:2: error: unexpected token
     197 |         lockdep_assert_held(&rtwdev->mutex);
         |         ^
   include/linux/lockdep.h:285:2: note: expanded from macro 'lockdep_assert_held'
     285 |         lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
         |         ^
   include/linux/lockdep.h:279:7: note: expanded from macro 'lockdep_assert'
     279 |         do { WARN_ON(debug_locks && !(cond)); } while (0)
         |              ^
   include/asm-generic/bug.h:132:3: note: expanded from macro 'WARN_ON'
     132 |                 __WARN();                                               \
         |                 ^
   note: (skipping 3 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
      10 | #define __stringify(x...)       __stringify_1(x)
         |                                 ^
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
       9 | #define __stringify_1(x...)     #x
         |                                 ^
   <scratch space>:15:1: note: expanded from here
      15 | ".pushsection __bug_table, \"aw\"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, \"aMS\", @progbits, 1; 10002: .string \"\" \"drivers/net/wireless/realtek/rtw88/hci.h\"; .popsection; .long 10002b - .; .short 197; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;"
         | ^
   <inline asm>:1:134: note: instantiated into assembly here
       1 |         .pushsection __bug_table, "aw"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, "aMS", @progbits, 1; 10002: .string "" "drivers/net/wireless/realtek/rtw88/hci.h"; .popsection; .long 10002b - .; .short 197; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;
         |                                                                                                                                             ^
   In file included from drivers/net/wireless/realtek/rtw88/rtw8822c.c:6:
   In file included from drivers/net/wireless/realtek/rtw88/main.h:2136:
   drivers/net/wireless/realtek/rtw88/hci.h:186:2: error: unexpected token
     186 |         lockdep_assert_held(&rtwdev->mutex);
         |         ^
   include/linux/lockdep.h:285:2: note: expanded from macro 'lockdep_assert_held'
     285 |         lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
         |         ^
   include/linux/lockdep.h:279:7: note: expanded from macro 'lockdep_assert'
     279 |         do { WARN_ON(debug_locks && !(cond)); } while (0)
         |              ^
   include/asm-generic/bug.h:132:3: note: expanded from macro 'WARN_ON'
     132 |                 __WARN();                                               \
         |                 ^
   note: (skipping 3 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
      10 | #define __stringify(x...)       __stringify_1(x)
         |                                 ^
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
       9 | #define __stringify_1(x...)     #x
         |                                 ^
   <scratch space>:12:1: note: expanded from here
      12 | ".pushsection __bug_table, \"aw\"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, \"aMS\", @progbits, 1; 10002: .string \"\" \"drivers/net/wireless/realtek/rtw88/hci.h\"; .popsection; .long 10002b - .; .short 186; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;"
         | ^
   <inline asm>:1:134: note: instantiated into assembly here
       1 |         .pushsection __bug_table, "aw"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, "aMS", @progbits, 1; 10002: .string "" "drivers/net/wireless/realtek/rtw88/hci.h"; .popsection; .long 10002b - .; .short 186; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;
         |                                                                                                                                             ^
   In file included from drivers/net/wireless/realtek/rtw88/rtw8822c.c:6:
   In file included from drivers/net/wireless/realtek/rtw88/main.h:2136:
   drivers/net/wireless/realtek/rtw88/hci.h:186:2: error: unexpected token
     186 |         lockdep_assert_held(&rtwdev->mutex);
         |         ^
   include/linux/lockdep.h:285:2: note: expanded from macro 'lockdep_assert_held'
     285 |         lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
         |         ^
   include/linux/lockdep.h:279:7: note: expanded from macro 'lockdep_assert'
     279 |         do { WARN_ON(debug_locks && !(cond)); } while (0)
         |              ^
   include/asm-generic/bug.h:132:3: note: expanded from macro 'WARN_ON'
     132 |                 __WARN();                                               \
         |                 ^
   note: (skipping 3 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
      10 | #define __stringify(x...)       __stringify_1(x)
         |                                 ^
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
       9 | #define __stringify_1(x...)     #x
         |                                 ^
   <scratch space>:12:1: note: expanded from here
      12 | ".pushsection __bug_table, \"aw\"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, \"aMS\", @progbits, 1; 10002: .string \"\" \"drivers/net/wireless/realtek/rtw88/hci.h\"; .popsection; .long 10002b - .; .short 186; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;"
         | ^
   <inline asm>:1:134: note: instantiated into assembly here
       1 |         .pushsection __bug_table, "aw"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, "aMS", @progbits, 1; 10002: .string "" "drivers/net/wireless/realtek/rtw88/hci.h"; .popsection; .long 10002b - .; .short 186; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;
         |                                                                                                                                             ^
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:4364:6: error: unexpected token
    4364 |         if (WARN_ON(bw > RTW_CHANNEL_WIDTH_40 || nrx >= RTW_RF_PATH_MAX))
         |             ^
   include/asm-generic/bug.h:132:3: note: expanded from macro 'WARN_ON'
     132 |                 __WARN();                                               \
         |                 ^
   include/asm-generic/bug.h:109:19: note: expanded from macro '__WARN'
     109 | #define __WARN()                __WARN_FLAGS("", BUGFLAG_TAINT(TAINT_WARN))
         |                                 ^
   arch/loongarch/include/asm/bug.h:47:2: note: expanded from macro '__WARN_FLAGS'
      47 |         __BUG_FLAGS(cond_str, BUGFLAG_WARNING|(flags), ANNOTATE_REACHABLE(10001b));\
         |         ^
   note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
      10 | #define __stringify(x...)       __stringify_1(x)
         |                                 ^
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
       9 | #define __stringify_1(x...)     #x
         |                                 ^
   <scratch space>:42:1: note: expanded from here
      42 | ".pushsection __bug_table, \"aw\"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, \"aMS\", @progbits, 1; 10002: .string \"\" \"drivers/net/wireless/realtek/rtw88/rtw8822c.c\"; .popsection; .long 10002b - .; .short 4364; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;"
         | ^
   <inline asm>:1:134: note: instantiated into assembly here
       1 |         .pushsection __bug_table, "aw"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, "aMS", @progbits, 1; 10002: .string "" "drivers/net/wireless/realtek/rtw88/rtw8822c.c"; .popsection; .long 10002b - .; .short 4364; .short (1 << 0)|(((9) << 8)); .popsection; 10001: break 1;
         |                                                                                                                                             ^
   In file included from drivers/net/wireless/realtek/rtw88/rtw8822c.c:6:
   In file included from drivers/net/wireless/realtek/rtw88/main.h:2136:
   drivers/net/wireless/realtek/rtw88/hci.h:248:2: error: unexpected token
     248 |         WARN(addr & 0x3, "should be 4-byte aligned, addr = 0x%08x\n", addr);
         |         ^
   include/asm-generic/bug.h:141:3: note: expanded from macro 'WARN'
     141 |                 __WARN_printf(TAINT_WARN, format);                      \
         |                 ^
   include/asm-generic/bug.h:113:3: note: expanded from macro '__WARN_printf'
     113 |                 __WARN_FLAGS("", BUGFLAG_NO_CUT_HERE | BUGFLAG_TAINT(taint));\
         |                 ^
   arch/loongarch/include/asm/bug.h:47:2: note: expanded from macro '__WARN_FLAGS'
      47 |         __BUG_FLAGS(cond_str, BUGFLAG_WARNING|(flags), ANNOTATE_REACHABLE(10001b));\
         |         ^
   note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
      10 | #define __stringify(x...)       __stringify_1(x)
         |                                 ^
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
       9 | #define __stringify_1(x...)     #x
         |                                 ^
   <scratch space>:18:1: note: expanded from here
      18 | ".pushsection __bug_table, \"aw\"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, \"aMS\", @progbits, 1; 10002: .string \"\" \"drivers/net/wireless/realtek/rtw88/hci.h\"; .popsection; .long 10002b - .; .short 248; .short (1 << 0)|((1 << 3) | ((9) << 8)); .popsection; 10001: break 1;"
         | ^
   <inline asm>:1:134: note: instantiated into assembly here
       1 |         .pushsection __bug_table, "aw"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, "aMS", @progbits, 1; 10002: .string "" "drivers/net/wireless/realtek/rtw88/hci.h"; .popsection; .long 10002b - .; .short 248; .short (1 << 0)|((1 << 3) | ((9) << 8)); .popsection; 10001: break 1;
         |                                                                                                                                             ^
   In file included from drivers/net/wireless/realtek/rtw88/rtw8822c.c:6:
   In file included from drivers/net/wireless/realtek/rtw88/main.h:2136:
   drivers/net/wireless/realtek/rtw88/hci.h:248:2: error: unexpected token
     248 |         WARN(addr & 0x3, "should be 4-byte aligned, addr = 0x%08x\n", addr);
         |         ^
   include/asm-generic/bug.h:141:3: note: expanded from macro 'WARN'
     141 |                 __WARN_printf(TAINT_WARN, format);                      \
         |                 ^
   include/asm-generic/bug.h:113:3: note: expanded from macro '__WARN_printf'
     113 |                 __WARN_FLAGS("", BUGFLAG_NO_CUT_HERE | BUGFLAG_TAINT(taint));\
         |                 ^
   arch/loongarch/include/asm/bug.h:47:2: note: expanded from macro '__WARN_FLAGS'
      47 |         __BUG_FLAGS(cond_str, BUGFLAG_WARNING|(flags), ANNOTATE_REACHABLE(10001b));\
         |         ^
   note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
      10 | #define __stringify(x...)       __stringify_1(x)
         |                                 ^
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
       9 | #define __stringify_1(x...)     #x
         |                                 ^
   <scratch space>:18:1: note: expanded from here
      18 | ".pushsection __bug_table, \"aw\"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, \"aMS\", @progbits, 1; 10002: .string \"\" \"drivers/net/wireless/realtek/rtw88/hci.h\"; .popsection; .long 10002b - .; .short 248; .short (1 << 0)|((1 << 3) | ((9) << 8)); .popsection; 10001: break 1;"
         | ^
   <inline asm>:1:134: note: instantiated into assembly here
       1 |         .pushsection __bug_table, "aw"; .align 2; 10000: .long 10001f - .; .pushsection .rodata.str, "aMS", @progbits, 1; 10002: .string "" "drivers/net/wireless/realtek/rtw88/hci.h"; .popsection; .long 10002b - .; .short 248; .short (1 << 0)|((1 << 3) | ((9) << 8)); .popsection; 10001: break 1;
         |                                                                                                                                             ^
   In file included from drivers/net/wireless/realtek/rtw88/rtw8822c.c:6:
   In file included from drivers/net/wireless/realtek/rtw88/main.h:2136:
   drivers/net/wireless/realtek/rtw88/hci.h:197:2: error: unexpected token
     197 |         lockdep_assert_held(&rtwdev->mutex);
         |         ^
   include/linux/lockdep.h:285:2: note: expanded from macro 'lockdep_assert_held'
     285 |         lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
         |         ^
   include/linux/lockdep.h:279:7: note: expanded from macro 'lockdep_assert'
     279 |         do { WARN_ON(debug_locks && !(cond)); } while (0)
         |              ^
   include/asm-generic/bug.h:132:3: note: expanded from macro 'WARN_ON'
     132 |                 __WARN();                                               \
         |                 ^
   note: (skipping 3 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
   include/linux/stringify.h:10:27: note: expanded from macro '__stringify'
      10 | #define __stringify(x...)       __stringify_1(x)
         |                                 ^
   include/linux/stringify.h:9:29: note: expanded from macro '__stringify_1'
       9 | #define __stringify_1(x...)     #x
         |                                 ^
   <scratch space>:15:1: note: expanded from here


vim +4364 drivers/net/wireless/realtek/rtw88/rtw8822c.c

479c4ee931a677c Tzu-En Huang 2019-09-09  4353  
479c4ee931a677c Tzu-En Huang 2019-09-09  4354  #define RTW_CCK_PD_MAX 255
479c4ee931a677c Tzu-En Huang 2019-09-09  4355  #define RTW_CCK_CS_MAX 31
479c4ee931a677c Tzu-En Huang 2019-09-09  4356  #define RTW_CCK_CS_ERR1 27
479c4ee931a677c Tzu-En Huang 2019-09-09  4357  #define RTW_CCK_CS_ERR2 29
479c4ee931a677c Tzu-En Huang 2019-09-09  4358  static void
479c4ee931a677c Tzu-En Huang 2019-09-09  4359  rtw8822c_phy_cck_pd_set_reg(struct rtw_dev *rtwdev,
479c4ee931a677c Tzu-En Huang 2019-09-09  4360  			    s8 pd_diff, s8 cs_diff, u8 bw, u8 nrx)
479c4ee931a677c Tzu-En Huang 2019-09-09  4361  {
479c4ee931a677c Tzu-En Huang 2019-09-09  4362  	u32 pd, cs;
479c4ee931a677c Tzu-En Huang 2019-09-09  4363  
479c4ee931a677c Tzu-En Huang 2019-09-09 @4364  	if (WARN_ON(bw > RTW_CHANNEL_WIDTH_40 || nrx >= RTW_RF_PATH_MAX))
479c4ee931a677c Tzu-En Huang 2019-09-09  4365  		return;
479c4ee931a677c Tzu-En Huang 2019-09-09  4366  
479c4ee931a677c Tzu-En Huang 2019-09-09  4367  	pd = rtw_read32_mask(rtwdev,
479c4ee931a677c Tzu-En Huang 2019-09-09  4368  			     rtw8822c_cck_pd_reg[bw][nrx].reg_pd,
479c4ee931a677c Tzu-En Huang 2019-09-09  4369  			     rtw8822c_cck_pd_reg[bw][nrx].mask_pd);
479c4ee931a677c Tzu-En Huang 2019-09-09  4370  	cs = rtw_read32_mask(rtwdev,
479c4ee931a677c Tzu-En Huang 2019-09-09  4371  			     rtw8822c_cck_pd_reg[bw][nrx].reg_cs,
479c4ee931a677c Tzu-En Huang 2019-09-09  4372  			     rtw8822c_cck_pd_reg[bw][nrx].mask_cs);
479c4ee931a677c Tzu-En Huang 2019-09-09  4373  	pd += pd_diff;
479c4ee931a677c Tzu-En Huang 2019-09-09  4374  	cs += cs_diff;
479c4ee931a677c Tzu-En Huang 2019-09-09  4375  	if (pd > RTW_CCK_PD_MAX)
479c4ee931a677c Tzu-En Huang 2019-09-09  4376  		pd = RTW_CCK_PD_MAX;
479c4ee931a677c Tzu-En Huang 2019-09-09  4377  	if (cs == RTW_CCK_CS_ERR1 || cs == RTW_CCK_CS_ERR2)
479c4ee931a677c Tzu-En Huang 2019-09-09  4378  		cs++;
479c4ee931a677c Tzu-En Huang 2019-09-09  4379  	else if (cs > RTW_CCK_CS_MAX)
479c4ee931a677c Tzu-En Huang 2019-09-09  4380  		cs = RTW_CCK_CS_MAX;
479c4ee931a677c Tzu-En Huang 2019-09-09  4381  	rtw_write32_mask(rtwdev,
479c4ee931a677c Tzu-En Huang 2019-09-09  4382  			 rtw8822c_cck_pd_reg[bw][nrx].reg_pd,
479c4ee931a677c Tzu-En Huang 2019-09-09  4383  			 rtw8822c_cck_pd_reg[bw][nrx].mask_pd,
479c4ee931a677c Tzu-En Huang 2019-09-09  4384  			 pd);
479c4ee931a677c Tzu-En Huang 2019-09-09  4385  	rtw_write32_mask(rtwdev,
479c4ee931a677c Tzu-En Huang 2019-09-09  4386  			 rtw8822c_cck_pd_reg[bw][nrx].reg_cs,
479c4ee931a677c Tzu-En Huang 2019-09-09  4387  			 rtw8822c_cck_pd_reg[bw][nrx].mask_cs,
479c4ee931a677c Tzu-En Huang 2019-09-09  4388  			 cs);
760bb2abfef252a Ping-Ke Shih 2020-11-09  4389  
760bb2abfef252a Ping-Ke Shih 2020-11-09  4390  	rtw_dbg(rtwdev, RTW_DBG_PHY,
760bb2abfef252a Ping-Ke Shih 2020-11-09  4391  		"is_linked=%d, bw=%d, nrx=%d, cs_ratio=0x%x, pd_th=0x%x\n",
760bb2abfef252a Ping-Ke Shih 2020-11-09  4392  		rtw_is_assoc(rtwdev), bw, nrx, cs, pd);
479c4ee931a677c Tzu-En Huang 2019-09-09  4393  }
479c4ee931a677c Tzu-En Huang 2019-09-09  4394  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pinctrl: samsung: Fix gs101 irq chip
  2025-07-02 12:15 [PATCH] pinctrl: samsung: Fix gs101 irq chip Peter Griffin
  2025-07-02 12:47 ` André Draszik
  2025-07-05  5:07 ` kernel test robot
@ 2025-07-05  8:52 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-05  8:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Sylwester Nawrocki, Alim Akhtar,
	Linus Walleij, Peter Griffin
  Cc: linux-arm-kernel, linux-samsung-soc, linux-gpio, linux-kernel,
	André Draszik


On Wed, 02 Jul 2025 13:15:24 +0100, Peter Griffin wrote:
> When adding the dedicated gs101_wkup_irq_chip struct to support the eint
> wakeup mask the .eint_con, eint_mask and .eint_pend fields were missed. The
> result is that irqs on gs101 for the buttons etc are broken.
> 
> 

Applied, thanks!

[1/1] pinctrl: samsung: Fix gs101 irq chip
      https://git.kernel.org/pinctrl/samsung/c/683d532dfc9657ab8aae25204f378352ed144646

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-05  8:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-02 12:15 [PATCH] pinctrl: samsung: Fix gs101 irq chip Peter Griffin
2025-07-02 12:47 ` André Draszik
2025-07-05  5:07 ` kernel test robot
2025-07-05  8:52 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®