mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Chen, Yu C" <yu.c.chen@intel.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	kernel test robot <oliver.sang@intel.com>,
	oe-lkp@lists.linux.dev, lkp@intel.com,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Valentin Schneider <vschneid@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	aubrey.li@linux.intel.com
Subject: Re: [PATCH] lib/smp_processor_id: Make migration check unconditional of SMP
Date: Thu, 10 Jul 2025 12:13:16 +0200	[thread overview]
Message-ID: <20250710101316.GJ1613376@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <cf437def-4542-4b73-b62b-ae9b304d40be@intel.com>

On Thu, Jul 10, 2025 at 04:32:57PM +0800, Chen, Yu C wrote:
> On 7/10/2025 4:27 PM, Sebastian Andrzej Siewior wrote:
> > Commit cac5cefbade90 ("sched/smp: Make SMP unconditional")
> > migrate_disable() even on UP builds.
> > Commit 06ddd17521bf1 ("sched/smp: Always define is_percpu_thread() and
> > scheduler_ipi()") made is_percpu_thread() check the affinity mask
> > instead replying always true for UP mask.
> > 
> > As a consequence smp_processor_id() now complains if invoked within a
> > migrate_disable() section because is_percpu_thread() checks its mask and
> > the migration check is left out.
> > 
> > Make migration check unconditional of SMP.
> > 
> > Fixes: cac5cefbade90 ("sched/smp: Make SMP unconditional")
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Closes: https://lore.kernel.org/oe-lkp/202507100448.6b88d6f1-lkp@intel.com
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> 
> From my understanding,
> 
> Reviewed-by: Chen Yu <yu.c.chen@intel.com>

Thanks; let me go stick this in a tree somewhere.

  reply	other threads:[~2025-07-10 10:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10  2:58 [tip:sched/core] [sched/smp] 06ddd17521: BUG:using_smp_processor_id()in_preemptible kernel test robot
2025-07-10  3:18 ` Chen, Yu C
2025-07-10  6:25   ` Sebastian Andrzej Siewior
2025-07-10  8:00     ` Chen, Yu C
2025-07-10  8:11       ` Sebastian Andrzej Siewior
2025-07-10  8:27         ` [PATCH] lib/smp_processor_id: Make migration check unconditional of SMP Sebastian Andrzej Siewior
2025-07-10  8:32           ` Chen, Yu C
2025-07-10 10:13             ` Peter Zijlstra [this message]
2025-07-11 12:41           ` [tip: sched/core] " tip-bot2 for Sebastian Andrzej Siewior
2025-07-10  8:29         ` [tip:sched/core] [sched/smp] 06ddd17521: BUG:using_smp_processor_id()in_preemptible Chen, Yu C
2025-07-10 10:47           ` Sebastian Andrzej Siewior
2025-07-10 11:31             ` Chen, Yu C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250710101316.GJ1613376@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=aubrey.li@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=x86@kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®