[PATCH] media: staging: atomisp: stylefix

[PATCH] media: staging: atomisp: stylefix

[sina hosseinizad]

change the spaces at the beginning of the line to tabs

Signed-off-by: sina hosseinizad <sina.hz@gmail.com>
---
My first contribution to the linux kernel, so starting out with a stylefix
---
 drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
index bc97fa2c374c..bd3a017490ef 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
@@ -2347,7 +2347,7 @@ int atomisp_css_video_configure_output(struct atomisp_sub_device *asd,
 }
 
 int atomisp_css_video_configure_viewfinder(
-    struct atomisp_sub_device *asd,
+	struct atomisp_sub_device *asd,
     unsigned int width, unsigned int height,
     unsigned int min_width,
     enum ia_css_frame_format format)
-- 
2.39.5

Re: [PATCH] media: staging: atomisp: stylefix

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 5:27 PM sina hosseinizad <sina.hz@gmail.com> wrote:
>
> change the spaces at the beginning of the line to tabs

You have to respect English grammar and punctuation.

>  int atomisp_css_video_configure_viewfinder(
> -    struct atomisp_sub_device *asd,
> +       struct atomisp_sub_device *asd,
>      unsigned int width, unsigned int height,
>      unsigned int min_width,
>      enum ia_css_frame_format format)

As a standalone this is useless change and just a churn. Try to find
something better to fix, please.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] media: staging: atomisp: stylefix

[Dan Carpenter]

On Mon, Jul 14, 2025 at 04:26:45PM +0200, sina hosseinizad wrote:
> change the spaces at the beginning of the line to tabs
> 
> Signed-off-by: sina hosseinizad <sina.hz@gmail.com>

You probably want to capitalize your name.  It's supposed to be written
like you would write it on a legal document.  (These Signed off by lines
are supposed to be like a legal thing which says that you haven't stolen
any code or violated any copy rights in this patch).

> ---
> My first contribution to the linux kernel, so starting out with a stylefix
> ---
>  drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> index bc97fa2c374c..bd3a017490ef 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
> @@ -2347,7 +2347,7 @@ int atomisp_css_video_configure_output(struct atomisp_sub_device *asd,
>  }
>  
>  int atomisp_css_video_configure_viewfinder(
> -    struct atomisp_sub_device *asd,
> +	struct atomisp_sub_device *asd,
>      unsigned int width, unsigned int height,

The other lines don't match now.

regards,
dan carpenter

>      unsigned int min_width,
>      enum ia_css_frame_format format)
> -- 
> 2.39.5
>