From: Zijiang Huang <huangzjsmile@gmail.com>
To: tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Zijiang Huang <kerayhuang@tencent.com>,
Hao Peng <flyingpeng@tencent.com>
Subject: [PATCH 2/2] cgroup: Fix reference count leak when cft->open is NULL
Date: Fri, 18 Jul 2025 19:54:09 +0800 [thread overview]
Message-ID: <20250718115409.878122-2-kerayhuang@tencent.com> (raw)
In-Reply-To: <20250718115409.878122-1-kerayhuang@tencent.com>
When cft->open is NULL, it will cause ctx namespace reference count leak.
Signed-off-by: Zijiang Huang <kerayhuang@tencent.com>
Reviewed-by: Hao Peng <flyingpeng@tencent.com>
---
kernel/cgroup/cgroup.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index a723b7dc6e4e..9bde0f4be687 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -4134,8 +4134,10 @@ static int cgroup_file_open(struct kernfs_open_file *of)
get_cgroup_ns(ctx->ns);
of->priv = ctx;
- if (!cft->open)
+ if (!cft->open) {
+ get_cgroup_ns(ctx->ns);
return 0;
+ }
ret = cft->open(of);
if (ret) {
--
2.43.5
next prev parent reply other threads:[~2025-07-18 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 11:54 [PATCH 1/2] cgroup-v1: Fix missing mutex_unlock in error paths Zijiang Huang
2025-07-18 11:54 ` Zijiang Huang [this message]
2025-07-18 12:48 ` [PATCH 2/2] cgroup: Fix reference count leak when cft->open is NULL Markus Elfring
2025-07-18 12:55 ` Michal Koutný
2025-07-18 12:23 ` [PATCH 1/2] cgroup-v1: Fix missing mutex_unlock in error paths Markus Elfring
2025-07-18 12:55 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718115409.878122-2-kerayhuang@tencent.com \
--to=huangzjsmile@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=flyingpeng@tencent.com \
--cc=hannes@cmpxchg.org \
--cc=kerayhuang@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®