From: Markus Elfring <Markus.Elfring@web.de>
To: Zijiang Huang <kerayhuang@tencent.com>, cgroups@vger.kernel.org
Cc: "Zijiang Huang" <huangzjsmile@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"Hao Peng" <flyingpeng@tencent.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>, "Tejun Heo" <tj@kernel.org>
Subject: Re: [PATCH 1/2] cgroup-v1: Fix missing mutex_unlock in error paths
Date: Fri, 18 Jul 2025 14:23:30 +0200 [thread overview]
Message-ID: <ccda6da0-5157-4520-a22d-437467ada3e1@web.de> (raw)
In-Reply-To: <20250718115409.878122-1-kerayhuang@tencent.com>
> In the function, after acquiring the mutex with mutex_lock, multiple return
> paths (such as returning ERR_PTR, NULL, or normal pointers)fail to call
> mutex_unlock to release the lock, which could lead to deadlock risks.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16-rc6#n94
Will a cover letter become helpful for such a patch series?
Regards,
Markus
next prev parent reply other threads:[~2025-07-18 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 11:54 Zijiang Huang
2025-07-18 11:54 ` [PATCH 2/2] cgroup: Fix reference count leak when cft->open is NULL Zijiang Huang
2025-07-18 12:48 ` Markus Elfring
2025-07-18 12:55 ` Michal Koutný
2025-07-18 12:23 ` Markus Elfring [this message]
2025-07-18 12:55 ` [PATCH 1/2] cgroup-v1: Fix missing mutex_unlock in error paths Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccda6da0-5157-4520-a22d-437467ada3e1@web.de \
--to=markus.elfring@web.de \
--cc=cgroups@vger.kernel.org \
--cc=flyingpeng@tencent.com \
--cc=hannes@cmpxchg.org \
--cc=huangzjsmile@gmail.com \
--cc=kerayhuang@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®