From: Peng Fan <peng.fan@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Luca Weiss <luca.weiss@fairphone.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs
Date: Mon, 21 Jul 2025 21:17:04 +0800 [thread overview]
Message-ID: <20250721131704.GA27698@nxa18884-linux.ap.freescale.net> (raw)
In-Reply-To: <2d7707cc-0a49-47a6-b222-9032f08bac0c@kernel.org>
On Mon, Jul 21, 2025 at 01:38:59PM +0200, Krzysztof Kozlowski wrote:
>On 21/07/2025 08:42, Peng Fan wrote:
>>> +
>>> + interrupt-names:
>>> + minItems: 6
>>> + maxItems: 6
>>
>> Ditto.
>>
>> Do you need to define the list?
>
>
>Did you read the entire binding? It reminds me Frank's comment as well -
I DO.
>instead of actually checking you just ask question which you would find
>answer by yourselves if you really opened the code.
I see there is a list in pas-common with entries listed. So just wonder
here is there a need to list all 6 entries. Not qcom developer, just
go through the list and see what I could do.
Things could be improved if ask language is not welcomed. Or I am
doing something wrong here?
>
>>
>>> +
>>> + qcom,qmp:
>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>> + description: Reference to the AOSS side-channel message RAM.
>>> +
>>> + smd-edge: false
>>> +
>>> + firmware-name:
>>> + $ref: /schemas/types.yaml#/definitions/string-array
>>> + minItems: 1
>>> + items:
>>> + - description: Firmware name of the Hexagon core
>>> + - description: Firmware name of the Hexagon Devicetree
>>> +
>>> + memory-region:
>>> + minItems: 1
>>> + items:
>>> + - description: Memory region for core Firmware authentication
>>> + - description: Memory region for Devicetree Firmware authentication
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - memory-region
>>> +
>>> +allOf:
>>> + - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + enum:
>>> + - qcom,milos-adsp-pas
>>> + - qcom,milos-cdsp-pas
>>> + then:
>>> + properties:
>>> + memory-region:
>>> + minItems: 2
>>> + maxItems: 2
>>> + firmware-name:
>>> + minItems: 2
>>> + maxItems: 2
>>
>> Just keep minItems if maxItems is same value.
>
>
>This is not a correct advice.
Sorry for this. I may need to find out more in dt-schema.
Regards,
Peng
>
>
>Best regards,
>Krzysztof
next prev parent reply other threads:[~2025-07-21 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 11:13 [PATCH v3 0/2] Add support for remoteprocs on Milos SoC Luca Weiss
2025-07-09 11:13 ` [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs Luca Weiss
2025-07-09 22:30 ` Rob Herring (Arm)
2025-07-17 7:20 ` Luca Weiss
2025-07-21 6:42 ` Peng Fan
2025-07-21 11:38 ` Krzysztof Kozlowski
2025-07-21 13:17 ` Peng Fan [this message]
2025-07-09 11:13 ` [PATCH v3 2/2] remoteproc: qcom: pas: Add Milos remoteproc support Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250721131704.GA27698@nxa18884-linux.ap.freescale.net \
--to=peng.fan@oss.nxp.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®